[kudu-CR] KUDU-2612 p2: introduce transaction status management

2020-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16044 ) Change subject: KUDU-2612 p2: introduce transaction status management .. Patch Set 2: (9 comments) I did a quick first pass. Overall

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 7: Code-Review+2 (3 comments)

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 5: > Patch Set 5:

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 4: (2 comments)

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-22 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#5). Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-22 Thread Greg Solovyev (Code Review)
Greg Solovyev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16101 Change subject: [client] KUDU-3152 fix predicates on DATE column .. [client] KUDU-3152 fix predicates on DATE column Add a missing

[kudu-CR] [WIP] Implement owner privileges

2020-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 ) Change subject: [WIP] Implement owner privileges .. Patch Set 3: (9 comments)

[kudu-CR] [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()

2020-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16034 ) Change subject: [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() .. [consensus] KUDU-2727 lock-free

[kudu-CR] [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()

2020-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16034 ) Change subject: [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() .. Patch Set 6: > Seems you have benchmarked this here:

[kudu-CR] [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()

2020-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16034 ) Change subject: [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() .. Patch Set 6: Code-Review+2 Seems you have benchmarked

[kudu-CR] [WIP] Add all with grant and changing ownership

2020-06-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16071 ) Change subject: [WIP] Add all with grant and changing ownership .. Patch Set 3: (3 comments) Perhaps consider separating the delegate

[kudu-CR] [benchmarks] add blocking queue-test scenarios

2020-06-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16100 Change subject: [benchmarks] add blocking_queue-test scenarios .. [benchmarks] add blocking_queue-test scenarios Added a couple of

[kudu-CR] [WIP] Add all with grant and changing ownership

2020-06-22 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16071 to look at the new patch set (#3). Change subject: [WIP] Add all with grant and changing ownership

[kudu-CR] [WIP] Implement owner privileges

2020-06-22 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16072 to look at the new patch set (#3). Change subject: [WIP] Implement owner privileges

[kudu-CR] WIP KUDU-16 pt 3: add per-scan-token limits

2020-06-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9923 ) Change subject: WIP KUDU-16 pt 3: add per-scan-token limits .. Patch Set 1: Revisiting this. I was a bit surprised to see the limit used