Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 )
Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16036/4/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/16036/4/src/kudu/client/predicate-test.cc@1513 PS4, Line 1513: TEST_F(PredicateTest, TestDisabledBloomFilterWithRepeatedStrings) { > Just to make sure we have all our iterators covered, could also add a case Thanks for these suggestions! http://gerrit.cloudera.org:8080/#/c/16036/4/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: http://gerrit.cloudera.org:8080/#/c/16036/4/src/kudu/common/generic_iterators-test.cc@819 PS4, Line 819: ASSERT_EQ(0, spec.predicates().size()) : < > nit: hmm typically we treat ASSERTs as function calls w.r.t spacing, which Done -- To view, visit http://gerrit.cloudera.org:8080/16036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10197800a01a1b34c7821ac879caf8d272cab8dd Gerrit-Change-Number: 16036 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 22 Jun 2020 23:40:40 +0000 Gerrit-HasComments: Yes
