[kudu-CR] KUDU-3476: Make replica placement range and table aware

2023-06-16 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 ) Change subject: KUDU-3476: Make replica placement range and table aware .. Patch Set 6: (7 comments) This is the first pass. I need s

[kudu-CR] [server] KUDU-1945 Auto incrementing column Upsert support

2023-06-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20061 ) Change subject: [server] KUDU-1945 Auto_incrementing column Upsert support .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 2: (1 comment) http://gerrit.clouder

[kudu-CR] [client] KUDU-1945 Add upsert support

2023-06-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client] KUDU-1945 Add upsert support .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/20083/1//COMM

[kudu-CR] [server] KUDU-1945 Auto incrementing column Upsert support

2023-06-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20061 ) Change subject: [server] KUDU-1945 Auto_incrementing column Upsert support .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8

[kudu-CR] [server] KUDU-1945 Auto incrementing column Upsert support

2023-06-16 Thread Abhishek Chennaka (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Yuqi Du, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20061 to look at the new patch set (#3). Change subject: [server] KUDU-1945 Auto_incrementing column Upsert support .

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-16 Thread Abhishek Chennaka (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20084 to look at the new patch set (#2). Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns ...

[kudu-CR] [client] KUDU-1945 Add upsert support

2023-06-16 Thread Abhishek Chennaka (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20083 to look at the new patch set (#2). Change subject: [client] KUDU-1945 Add upsert support .

[kudu-CR] [server] KUDU-1945 Auto incrementing column Upsert support

2023-06-16 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20061 ) Change subject: [server] KUDU-1945 Auto_incrementing column Upsert support .. Patch Set 2: (2 comments) http://gerrit.cloudera.or

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-16 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 1: (1 comment) http://gerrit.clo

[kudu-CR] [client]KUDU-1945 Add upsert support

2023-06-16 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client]KUDU-1945 Add upsert support .. Patch Set 1: (2 comments) I guess it makes sense to remove the test Clie

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-16 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 1: (1 comment) http://gerrit.clouder

[kudu-CR] [client]KUDU-1945 Add upsert support

2023-06-16 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client]KUDU-1945 Add upsert support .. Patch Set 1: (2 comments) In client-test.cc there are tests which previously

[kudu-CR] [server] KUDU-1945 Auto incrementing column Upsert support

2023-06-16 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20061 ) Change subject: [server] KUDU-1945 Auto_incrementing column Upsert support .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:80

[kudu-CR] [Tool] Show the information of a tablet

2023-06-16 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 ) Change subject: [Tool] Show the information of a tablet .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/18/src/kud

[kudu-CR] [Tool] Show the information of a tablet

2023-06-16 Thread Wang Xixu (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19501 to look at the new patch set (#20). Change subject: [Tool] Show the information of a tablet

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-06-16 Thread Code Review
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19639 to look at the new patch set (#5). Change subject: Change order of operations during InitCatalogManagerTask

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-06-16 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19639 ) Change subject: Change order of operations during InitCatalogManagerTask .. Patch Set 4: > Thanks for addressing this. Is this a part of

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-06-16 Thread Code Review
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19639 to look at the new patch set (#4). Change subject: Change order of operations during InitCatalogManagerTask

[kudu-CR] KUDU-3477 Function to get flags of minicluster daemons.

2023-06-16 Thread Anonymous Coward (Code Review)
zmarto...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19938 ) Change subject: KUDU-3477 Function to get flags of minicluster daemons. .. Patch Set 6: (3 comments) http://gerrit.cloudera.

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-16 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.clou

[kudu-CR] [KUDU-3483] Fixbug of auto flush data when table schema changed

2023-06-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed .. Patch Set 10: (4 comments) http://gerrit.cloudera.o

[kudu-CR] KUDU-1945 Add Python example for non-unique PK

2023-06-16 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19874 ) Change subject: KUDU-1945 Add Python example for non-unique PK .. KUDU-1945 Add Python example for non-unique PK In commit 3019

[kudu-CR] KUDU-1945 Add Python example for non-unique PK

2023-06-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19874 ) Change subject: KUDU-1945 Add Python example for non-unique PK .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [KUDU-3483] Log requestor info and request id for write interface

2023-06-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19950 ) Change subject: [KUDU-3483] Log requestor info and request id for write interface .. Patch Set 4: Code-Review+2 (1 comment) http://ge

[kudu-CR] [build] Change shebangs to python3

2023-06-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20079 ) Change subject: [build] Change shebangs to python3 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20079/1/thirdparty/

[kudu-CR] KUDU-3477 Function to get flags of minicluster daemons.

2023-06-16 Thread Anonymous Coward (Code Review)
Hello Zoltan Chovan, Yingchun Lai, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19938 to look at the new patch set (#6). Change subject: KUDU-3477 Function to get flags of minicluster daemons. ..

[kudu-CR] [Client] Add query id to trace the whole query process

2023-06-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [Client] Add query id to trace the whole query process .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19518 To unsubs

[kudu-CR] [Client] Add query id to trace the whole query process

2023-06-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19518 ) Change subject: [Client] Add query id to trace the whole query process .. Patch Set 3: Verified+1 Code-Review+2 > Patch Set 3: Verified

[kudu-CR] [build] Change shebangs to python3

2023-06-16 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20079 ) Change subject: [build] Change shebangs to python3 .. Patch Set 1: Code-Review+1 Tested this patch on macOS Monterey(12.2.1) M1, it wo

[kudu-CR] KUDU-3413 add tenant info in metadata for multi-tenancy

2023-06-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 add tenant info in metadata for multi-tenancy .. KUDU-3413 add tenant info in metadata for multi-tenan

[kudu-CR] [java] add buffer space limit for KuduSession

2023-06-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19918 ) Change subject: [java] add buffer space limit for KuduSession .. [java] add buffer space limit for KuduSession Currently, KuduS

[kudu-CR] KUDU-3477 Function to get flags of minicluster daemons.

2023-06-16 Thread Anonymous Coward (Code Review)
Hello Zoltan Chovan, Yingchun Lai, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19938 to look at the new patch set (#5). Change subject: KUDU-3477 Function to get flags of minicluster daemons. ..

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/20

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-16 Thread Attila Bukor (Code Review)
Hello Marton Greber, Tidy Bot, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20050 to look at the new patch set (#6). Change subject: KUDU-3448 Add support for encrypting existing keys ...