[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20600 to look at the new patch set (#7). Change subject: KUDU-3486 Master periodically request for full reports. ..

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20618 ) Change subject: [fs] fix compilation on macOS .. [fs] fix compilation on macOS After update to the very recent code in fro

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20618 ) Change subject: [fs] fix compilation on macOS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/206

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20621 ) Change subject: [thirdparty] Fix the curl missing patch .. [thirdparty] Fix the curl missing patch This is a follow-up patch fo

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [thirdparty] Fix the curl missing patch .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20621 To unsubscribe, visit ht

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20621 ) Change subject: [thirdparty] Fix the curl missing patch .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-24 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 22: (20 comments) http://gerrit.cloudera.org:8080/#/c/19479/20/src/k

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-24 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19479 to look at the new patch set (#22). Change subject: [KUDU-3447] Limit tablets copying speed ...

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20621 ) Change subject: [thirdparty] Fix the curl missing patch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [tablet] fix compilation warnings

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warnings .. [tablet] fix compilation warnings This patch fixes the following compilat

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20618 ) Change subject: [fs] fix compilation on macOS .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20618 To

[kudu-CR] [tablet] fix compilation warnings

2023-10-24 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warnings .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/2061

[kudu-CR] [tablet] fix compilation warnings

2023-10-24 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warnings .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20619

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20621 to review the following change. Change subject: [thirdparty] Fix the curl missing patch .. [thirdpart

[kudu-CR] [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20620 ) Change subject: [thirdparty] Fix the curl missing patch .. [thirdparty] Fix the curl missing patch This is a follow-up patch fo

[kudu-CR] [thirdparty] Fix the curl missing patch

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20620 ) Change subject: [thirdparty] Fix the curl missing patch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-24 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19479 to look at the new patch set (#21). Change subject: [KUDU-3447] Limit tablets copying speed ...

[kudu-CR] [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20620 Change subject: [thirdparty] Fix the curl missing patch .. [thirdparty] Fix the curl missing patch This is a follow-up patch for commit:

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20618 ) Change subject: [fs] fix compilation on macOS .. Patch Set 1: Verified+1 unrelated test failure (TSAN): MasterOptionsTest.TestRemoveMa

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [fs] fix compilation on macOS .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20618 To unsubscribe, visit http://gerr

[kudu-CR] [tablet] fix compilation warnings

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warnings .. Patch Set 2: > Patch Set 1: Code-Review+2 Thanks a lot for a quick review, Yifan

[kudu-CR] [tablet] fix compilation warnings

2023-10-24 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20619 to look at the new patch set (#2). Change subject: [tablet] fix compilation warnings .

[kudu-CR] [tablet] fix compilation warning

2023-10-24 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20619 ) Change subject: [tablet] fix compilation warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20619

[kudu-CR] [tablet] fix compilation warning

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20619 Change subject: [tablet] fix compilation warning .. [tablet] fix compilation warning src/kudu/tablet/ops/op_driver.cc:82:16: warning:

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20618 Change subject: [fs] fix compilation on macOS .. [fs] fix compilation on macOS After update to the very recent code in from the main br

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/19479/20/sr

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactors on kudu-tool-test .. Patch Set 3: Code-Review+1 (8 comments) http://gerrit.cloudera.org:8080/#/c/2059

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 20: (19 comments) http://gerrit.cloudera.org:8080/#/c/19479/20/s

[kudu-CR] [compaction] Skip memory allocation for ancient undo deltas

2023-10-24 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20546 ) Change subject: [compaction] Skip memory allocation for ancient undo deltas .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] [rpc] add hostname in Messenger to use it in ServerNegotiation

2023-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20609 ) Change subject: [rpc] add hostname in Messenger to use it in ServerNegotiation .. [rpc] add hostname in Messenger to use it in

[kudu-CR] [duplication] KUDU-3290 Support write ops to kafka with kafka client

2023-10-24 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19909 ) Change subject: [duplication] KUDU-3290 Support write ops to kafka with kafka client .. Patch Set 8: (8 comments) http://gerrit.cloudera

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactors on kudu-tool-test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2059

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20600 to look at the new patch set (#6). Change subject: KUDU-3486 Master periodically request for full reports. ..

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Master periodically request for full reports. .. Patch Set 5: (2 comments) Thank you for the review! http:

[kudu-CR] Fix a unit test in aarch64 system

2023-10-24 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#4). Change subject: Fix a unit test in aarch64 system .. Fix a unit t

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Master periodically request for full reports. .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Master periodically request for full reports. .. Patch Set 5: > Patch Set 4: > > (1 comment) Tombstone repl

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20600 to look at the new patch set (#5). Change subject: KUDU-3486 Master periodically request for full reports. ..

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Master periodically request for full reports. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-24 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactors on kudu-tool-test .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20597/3/s

[kudu-CR] KUDU-3486 Master periodically request for full reports.

2023-10-24 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Master periodically request for full reports. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] Fix a unit test in aarch64 system

2023-10-24 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG Com

[kudu-CR] Fix a unit test in aarch64 system

2023-10-24 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#3). Change subject: Fix a unit test in aarch64 system .. Fix a unit t

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-10-24 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [rpc] add hostname in Messenger to use it in ServerNegotiation

2023-10-24 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20609 ) Change subject: [rpc] add hostname in Messenger to use it in ServerNegotiation .. Patch Set 4: Code-Review+2 -- To view, visit ht