[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/5114 To unsubscribe, visit

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-17 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Patch Set 2: I do agree with clarifying the comments either way though -- To view, visit

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-17 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Patch Set 2: Ah, i see, so in that case are you thinking we should use the nocopy routine to

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Patch Set 2: > didnt finish my sentence above...given the way python handles the > semantics for

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Patch Set 2: > Was this more for parity's sake or did you need this exposed? The > libkudu_client

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-16 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Patch Set 2: didnt finish my sentence above...given the way python handles the semantics for

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-16 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Patch Set 2: Was this more for parity's sake or did you need this exposed? The libkudu_client

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. [python] added KuduPartialRow::SetNoCopy{Binary,String}() Added missing cython mappings for

[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2016-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5114 Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. [python] added KuduPartialRow::SetNoCopy{Binary,String}()