[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5894 To unsubscrib

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5894 To unsubscri

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. [thirdparty] Avoid building tsan on macOS on specific dep builds Specific dependency bu

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 2: Verified+1 Overriding jenkins (unrelated jenkins flakes). also tested this

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5894/1/thirdparty/build-t

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5894 to look at the new patch set (#2). Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds ...

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5894/1/thirdparty/build-thirdparty

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5894/1/thirdparty/build-thirdpart

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5894 To unsubscri

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: OK I was misremembering - ASAN has always worked on macOS (at least as far back a

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: woops that was the ASAN docs. Interesting, though. I didn't think ASAN was supp

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: uh oh... checkout https://clang.llvm.org/docs/AddressSanitizer.html#supported-pla

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: What command is failing for you? I remember in the past that something like ./th

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5894 Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. [thirdparty] Avoid building tsan on macOS on sp