[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add time/watermark based garbage collection to ResultTracker .. Add time/watermark based garbage collection to ResultTracker This adds time and watermark

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Verified+1 the test failure was some weird dist-test flakiness that I'm looking into

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/result_tracker.

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/re

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: kicked off dist-test runs with 1000 of each of the integration tests here: http://dis

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#18). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/2941/ -- To view, visit http:/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (6 comments) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/CMakeLists.txt

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: Yea, gerrit's poor at dealing with renames. git show -M does a better job. For your

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (6 comments) It's pretty tough to review exactly_once_rpc-test.cc since gerrit is sho

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2929/ -- To view, visit http:/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#17). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (8 comments) http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/integration-tests/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (8 comments) http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/integration-tests/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2925/ -- To view, visit http:/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#16). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/rpc/service_if.cc F

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/3628/15//COMMIT_MSG Commit Message:

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: Code-Review+1 (7 comments) http://gerrit.cloudera.org:8080/#/c/3628/15//COMMIT_MSG

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2892/ -- To view, visit http:/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#15). Change subject: Add time/watermark based garbage collection to ResultTracker ..

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2848/ -- To view, visit http:/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#14). Change subject: Add time/watermark based garbage collection to ResultTracker ..

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 13: (11 comments) http://gerrit.cloudera.org:8080/#/c/3628/13/src/kudu/rpc/exactly_once_

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 13: looking over this stuff tonight, just a note: seems like this is lacking actually _t