Adar Dembo has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit
Adar Dembo has submitted this change and it was merged.
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Don't build kudu_test_* if NO_TESTS set
Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Reviewed-on:
Henry Robinson has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Patch Set 2:
> If you volunteer to make the changes I'm fine with it. I can point you in the
> right direction.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5711
to look at the new patch set (#3).
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Don't build
Adar Dembo has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Patch Set 2:
> My reason is that adding set(NO_TESTS 1) in an Impala
> CMakefile.txts looks weird if it doesn't
Henry Robinson has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Patch Set 2:
My reason is that adding set(NO_TESTS 1) in an Impala CMakefile.txts looks
weird if it doesn't
Adar Dembo has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Patch Set 2:
The change makes sense, but the variable rename isn't free; we have Jenkins job
configs and packaging code
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5711
to look at the new patch set (#2).
Change subject: Don't build kudu_test_* if NO_TESTS set
..
Don't build
