[kudu-CR] log: shut down appender thread when idle

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log: shut down appender thread when idle .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6856/1/src/kudu/consensus/log.cc File

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 8: (4 comments) I only took a quick look at rev 8; there are a bunch of review

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6850 to look at the new patch set (#4). Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. KUDU-2001 Add

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6850/3/src/kudu/tablet/delta_tracker.h File

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 8: (4 comments)

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#10). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()

2017-05-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [util] updated output from TryRunLsof() .. [util] updated output from TryRunLsof() TryRunLsof() should not conclude it's called because of an error

[kudu-CR] cmake: fix protoc dependency typo

2017-05-11 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: cmake: fix protoc dependency typo .. cmake: fix protoc dependency typo The effect of this typo was that protoc would always be statically linked. Since

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#9). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 6: (7 comments) Also hit all the comments that somehow got missed from PS6.

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#24). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] [webui] Improvements for when there's many tablets & cleanup

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [webui] Improvements for when there's many tablets & cleanup .. Patch Set 1: (4 comments) Do the pages look OK and load reasonably quickly when the number of

[kudu-CR] WIP: threadpool: token-based sequencing

2017-05-11 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6874 to review the following change. Change subject: WIP: threadpool: token-based sequencing .. WIP: threadpool:

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: spark: add support for fault tolerant scanner .. Patch Set 7: (1 comment)

[kudu-CR] Bump glog to 0.3.5

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump glog to 0.3.5 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6871 To unsubscribe, visit

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6850/3/src/kudu/tablet/delta_tracker.h File

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 4: -Code-Review Huh. It occurs to me that this needs tests. :) -- To view, visit

[kudu-CR] log: fix some incorrect assumptions on BlockingQueue shutdown

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log: fix some incorrect assumptions on BlockingQueue shutdown .. log: fix some incorrect assumptions on BlockingQueue shutdown There was an incorrect

[kudu-CR] [catalog manager tsk-itest] shortened test's run-time

2017-05-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager_tsk-itest] shortened test's run-time .. Patch Set 1: Code-Review+2 have you tested this on dist-test with stress? +2ing in case yes but

[kudu-CR] [catalog manager tsk-itest] shortened test's run-time

2017-05-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager_tsk-itest] shortened test's run-time .. Patch Set 1: > have you tested this on dist-test with stress? +2ing in case yes > but if not I'd

[kudu-CR] [catalog manager tsk-itest] shortened test's run-time

2017-05-11 Thread Alexey Serbin (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6854 to look at the new patch set (#2). Change subject: [catalog_manager_tsk-itest] shortened test's run-time

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-11 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6853/3/src/kudu/util/async_logger.cc File

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-11 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#4). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-11 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#5). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-11 Thread Patrik Sundberg (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6827 to look at the new patch set (#7). Change subject: KUDU-1988: add support for advertised host:port info. ..

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit

[kudu-CR] KUDU-2001 Add UNDO size to tablet on-disk size

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size .. Patch Set 2: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/7839/ : FAILURE Known, unrelated

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#2). Change subject: KUDU-586. Upgrade to protobuf 3 .. KUDU-586. Upgrade to protobuf 3 Upgrades Kudu to use protoc 3.3.0 and adds `syntax = "proto2”;` to the proto files. Does not

[kudu-CR] log: shut down appender thread when idle

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log: shut down appender thread when idle .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/6856/1/src/kudu/consensus/log-test.cc File

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#7). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] faststring: add shrink to fit()

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: faststring: add shrink_to_fit() .. faststring: add shrink_to_fit() This adds a shrink_to_fit() method which reallocates the underlying buffer of a

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 2: Code-Review+1 Will upload 3.3 later this morning -- To view, visit http://gerrit.cloudera.org:8080/6857 To

[kudu-CR] [catalog manager tsk-itest] shortened test's run-time

2017-05-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager_tsk-itest] shortened test's run-time .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6854 To

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 6: (10 comments)

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#19). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] WIP Don't suicide on EIO

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6773 to look at the new patch set (#5). Change subject: WIP Don't suicide on EIO .. WIP Don't suicide on EIO Rather

[kudu-CR](branch-1.3.x) [flags] fixed typo in group flag validation logic

2017-05-11 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6864 to review the following change. Change subject: [flags] fixed typo in group flag validation logic ..

[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()

2017-05-11 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6863 to look at the new patch set (#2). Change subject: [util] updated output from TryRunLsof() .. [util]

[kudu-CR](branch-1.3.x) KUDU-1941: more validation for RPC auth flags

2017-05-11 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6862 to look at the new patch set (#2). Change subject: KUDU-1941: more validation for RPC auth flags ..

[kudu-CR] [catalog manager tsk-itest] shortened test's run-time

2017-05-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [catalog_manager_tsk-itest] shortened test's run-time .. [catalog_manager_tsk-itest] shortened test's run-time The longer the test runs the more tables

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#20). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] [doc] Remove beta upgrade reference

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doc] Remove beta upgrade reference .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6858 To unsubscribe, visit

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#8). Change subject: Refactor ConsensusStatePB to hold committed and pending configs

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#30). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

[kudu-CR] WIP Don't suicide on EIO

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6773 to look at the new patch set (#6). Change subject: WIP Don't suicide on EIO .. WIP Don't suicide on EIO Rather

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Grant Henke (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6857 to look at the new patch set (#3). Change subject: KUDU-586. Upgrade to protobuf 3 ..

[kudu-CR] [doc] Remove beta upgrade reference

2017-05-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6858 Change subject: [doc] Remove beta upgrade reference .. [doc] Remove beta upgrade reference Change-Id:

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#31). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

[kudu-CR] [java-client] Update protoc and simplify the maven build

2017-05-11 Thread Grant Henke (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6846 to look at the new patch set (#6). Change subject: [java-client] Update protoc and simplify the maven build

[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2005: actionable error messages from webserver .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6861 To unsubscribe, visit

[kudu-CR] [java-client] Update protoc and simplify the maven build

2017-05-11 Thread Grant Henke (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6846 to look at the new patch set (#7). Change subject: [java-client] Update protoc and simplify the maven build

[kudu-CR] [flags] fixed typo in group flag validation logic

2017-05-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6860 Change subject: [flags] fixed typo in group flag validation logic .. [flags] fixed typo in group flag validation logic This is a

[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver

2017-05-11 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6861 to review the following change. Change subject: KUDU-2005: actionable error messages from webserver ..

[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()

2017-05-11 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6863 to review the following change. Change subject: [util] updated output from TryRunLsof() .. [util]

[kudu-CR](branch-1.3.x) KUDU-1941: more validation for RPC auth flags

2017-05-11 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6862 to review the following change. Change subject: KUDU-1941: more validation for RPC auth flags ..

[kudu-CR] [java-client] Update protoc and simplify the maven build

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Update protoc and simplify the maven build .. Patch Set 5: (2 comments)

[kudu-CR](branch-1.3.x) KUDU-2005: actionable error messages from webserver

2017-05-11 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2005: actionable error messages from webserver .. KUDU-2005: actionable error messages from webserver As it turned out, squeasel outputs only

[kudu-CR] [java-client] Update protoc and simplify the maven build

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Update protoc and simplify the maven build .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-586. Upgrade to protobuf 3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6857 To unsubscribe, visit

[kudu-CR] [flags] fixed typo in group flag validation logic

2017-05-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [flags] fixed typo in group flag validation logic .. [flags] fixed typo in group flag validation logic This is a follow-up for

[kudu-CR] [flags] fixed typo in group flag validation logic

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [flags] fixed typo in group flag validation logic .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6860 To unsubscribe, visit

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#21). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] WIP Allow external miniclusters to use many data dirs

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#4). Change subject: WIP Allow external miniclusters to use many data dirs .. WIP

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 21: (8 comments) http://gerrit.cloudera.org:8080/#/c/6636/18/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#22). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] log: shut down appender thread when idle

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log: shut down appender thread when idle .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/6856/1/src/kudu/consensus/log-test.cc File

[kudu-CR] log: shut down appender thread when idle

2017-05-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6856 to look at the new patch set (#2). Change subject: log: shut down appender thread when idle .. log:

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#23). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/6636/18/src/kudu/fs/data_dirs.cc File

[kudu-CR] cmake: fix protoc dependency typo

2017-05-11 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6869 to review the following change. Change subject: cmake: fix protoc dependency typo .. cmake: fix protoc dependency typo

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/6636/23/src/kudu/fs/data_dirs.cc File

[kudu-CR] cmake: fix protoc dependency typo

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: cmake: fix protoc dependency typo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6869 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-1941: more validation for RPC auth flags

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1941: more validation for RPC auth flags .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6862 To unsubscribe, visit

[kudu-CR](branch-1.3.x) [util] updated output from TryRunLsof()

2017-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] updated output from TryRunLsof() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6863 To unsubscribe, visit

[kudu-CR] KUDU-586. Upgrade to protobuf 3

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-586. Upgrade to protobuf 3 .. KUDU-586. Upgrade to protobuf 3 Upgrades Kudu to use protoc 3.3.0 and adds `syntax = "proto2”;` to the proto files.

[kudu-CR] [java-client] Update protoc and simplify the maven build

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] Update protoc and simplify the maven build .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6846 To unsubscribe,

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-11 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#32). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

[kudu-CR] [java-client] Update protoc and simplify the maven build

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java-client] Update protoc and simplify the maven build .. [java-client] Update protoc and simplify the maven build This patch simplifies the Java build