[kudu-CR] [tests] clean-up on kudu::client::ScanToStrings

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7027 Change subject: [tests] clean-up on kudu::client::ScanToStrings .. [tests] clean-up on kudu::client::ScanToStrings With this patch,

[kudu-CR] Move CreateTableForTesting into registration-test

Alexey Serbin has posted comments on this change. Change subject: Move CreateTableForTesting into registration-test .. Patch Set 3: Code-Review+2 LGTM The only nit is unused master::GetTableLocationsRequestPB in

[kudu-CR](gh-pages) WIP: Kudu Consistency Blog Post Pt1

Andrew Wong has posted comments on this change. Change subject: WIP: Kudu Consistency Blog Post Pt1 .. Patch Set 3: (32 comments) Really appreciated explicit definitions of what and when things happen. I think the section

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7037 Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027 retry scan RPC if negotiation times out This patch

[kudu-CR] consensus: Get rid of LockFor*() methods

Mike Percy has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 10: (11 comments) http://gerrit.cloudera.org:8080/#/c/7012/8/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] consensus: Get rid of LockFor*() methods

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7012 to look at the new patch set (#11). Change subject: consensus: Get rid of LockFor*() methods .. consensus: Get rid

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#2). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] consensus: Get rid of LockFor*() methods

Alexey Serbin has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/7012/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] consensus: Get rid of LockFor*() methods

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7012 to look at the new patch set (#12). Change subject: consensus: Get rid of LockFor*() methods .. consensus: Get rid

[kudu-CR] consensus: Get rid of LockFor*() methods

Alexey Serbin has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 12: Code-Review+2 (3 comments) LGTM. You might be interested to get more feedback from Todd.

[kudu-CR] [tests] clean-up on kudu::client::ScanToStrings

Alexey Serbin has submitted this change and it was merged. Change subject: [tests] clean-up on kudu::client::ScanToStrings .. [tests] clean-up on kudu::client::ScanToStrings With this patch, kudu::client::ScanToStrings()

[kudu-CR] KUDU-1125 (part 1) catalog manager: try to avoid unnecessarily rewriting tablet info

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1125 (part 1) catalog_manager: try to avoid unnecessarily rewriting tablet info .. KUDU-1125 (part 1) catalog_manager: try to avoid unnecessarily

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

Alexey Serbin has posted comments on this change. Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7032/1/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

Andrew Wong has posted comments on this change. Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7032/1/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7025 to look at the new patch set (#3). Change subject: [tests] InvalidTokenDuringSeparateWorkloads test ..

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

Todd Lipcon has posted comments on this change. Change subject: [tests] InvalidTokenDuringSeparateWorkloads test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7025 To unsubscribe, visit

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

Alexey Serbin has posted comments on this change. Change subject: [tests] InvalidTokenDuringSeparateWorkloads test .. Patch Set 2: Code-Review+2 carrying over Todd's +2 -- To view, visit http://gerrit.cloudera.org:8080/7025

[kudu-CR] consensus: Add DCHECK(is locked()) in all unlocked methods

Todd Lipcon has posted comments on this change. Change subject: consensus: Add DCHECK(is_locked()) in all unlocked methods .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7013 To unsubscribe,

[kudu-CR] consensus: Get rid of LockFor*() methods

Todd Lipcon has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 10: think you missed a couple comments on the previous rev? -- To view, visit

[kudu-CR] Move CreateTableForTesting into registration-test

Alexey Serbin has posted comments on this change. Change subject: Move CreateTableForTesting into registration-test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6961 To unsubscribe, visit

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

Alexey Serbin has posted comments on this change. Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7032/1/src/kudu/consensus/consensus_queue.cc

[kudu-CR] Move CreateTableForTesting into registration-test

Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6961 to look at the new patch set (#4). Change subject: Move CreateTableForTesting into registration-test

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

Todd Lipcon has posted comments on this change. Change subject: [tests] InvalidTokenDuringSeparateWorkloads test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7025 To unsubscribe, visit

[kudu-CR] consensus: Add DCHECK(is locked()) in all unlocked methods

Alexey Serbin has posted comments on this change. Change subject: consensus: Add DCHECK(is_locked()) in all unlocked methods .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7013 To unsubscribe,

[kudu-CR] Move CreateTableForTesting into registration-test

Todd Lipcon has submitted this change and it was merged. Change subject: Move CreateTableForTesting into registration-test .. Move CreateTableForTesting into registration-test This utility function was only used in one spot,

[kudu-CR] KUDU-1914 Add positive .htpasswd test case

Hello Hao Hao, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7026 to look at the new patch set (#2). Change subject: KUDU-1914 Add positive .htpasswd test case

[kudu-CR] disk failure: make DataDirManager failure-aware

Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7028 Change subject: disk failure: make DataDirManager failure-aware .. disk failure: make DataDirManager failure-aware The DataDirManager

[kudu-CR] disk failure: coordinate IO error handling

Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7029 Change subject: disk failure: coordinate IO error handling .. disk failure: coordinate IO error handling I/O errors are spawned when

[kudu-CR] disk failure: basic test coverage for disk failure

Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7031 Change subject: disk failure: basic test coverage for disk failure .. disk failure: basic test coverage for disk failure This patch adds

[kudu-CR] disk failure: handle EIOs on I/O to blocks

Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7030 Change subject: disk failure: handle EIOs on I/O to blocks .. disk failure: handle EIOs on I/O to blocks This patch adds the proper

[kudu-CR] KUDU-1914 Add positive .htpasswd test case

Todd Lipcon has posted comments on this change. Change subject: KUDU-1914 Add positive .htpasswd test case .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7026 To unsubscribe, visit

[kudu-CR] disk failure: coordinate IO error handling

Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate IO error handling .. Patch Set 1: Definitely open to feedback on the observer pattern-ish design -- To view, visit

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7025 to look at the new patch set (#2). Change subject: [tests] InvalidTokenDuringSeparateWorkloads test ..

[kudu-CR] consensus: Get rid of ReplicaState class

Todd Lipcon has posted comments on this change. Change subject: consensus: Get rid of ReplicaState class .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7007 To unsubscribe, visit

[kudu-CR] [tests] clean-up on kudu::client::ScanToStrings

Todd Lipcon has posted comments on this change. Change subject: [tests] clean-up on kudu::client::ScanToStrings .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7027 To unsubscribe, visit

[kudu-CR] consensus: Get rid of LockFor*() methods

Mike Percy has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 10: > think you missed a couple comments on the previous rev? Ah, I missed your comments in the churn. Will

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

Todd Lipcon has posted comments on this change. Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7032/1/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7032 Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. [consensus_queue] fix race in UpdateLagMetrics() TSAN reports

[kudu-CR] KUDU-1914 Add positive .htpasswd test case

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1914 Add positive .htpasswd test case .. KUDU-1914 Add positive .htpasswd test case This commit adds a test to check if a proper user/password pair

[kudu-CR] [tests] clean-up on kudu::client::ScanToStrings

Alexey Serbin has posted comments on this change. Change subject: [tests] clean-up on kudu::client::ScanToStrings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7027/1/src/kudu/client/client-test-util.h File

[kudu-CR] [tests] clean-up on kudu::client::ScanToStrings

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7027 to look at the new patch set (#2). Change subject: [tests] clean-up on kudu::client::ScanToStrings .. [tests]

[kudu-CR] [tests] InvalidTokenDuringSeparateWorkloads test

Alexey Serbin has submitted this change and it was merged. Change subject: [tests] InvalidTokenDuringSeparateWorkloads test .. [tests] InvalidTokenDuringSeparateWorkloads test Introduced new

[kudu-CR] consensus: Get rid of ReplicaState class

Mike Percy has submitted this change and it was merged. Change subject: consensus: Get rid of ReplicaState class .. consensus: Get rid of ReplicaState class Merges the logic in ReplicaState into the RaftConsensus class.

[kudu-CR] consensus: Get rid of ReplicaState class

Mike Percy has posted comments on this change. Change subject: consensus: Get rid of ReplicaState class .. Patch Set 6: Verified+1 Overriding Spark test cleanup issue: org.apache.kudu.client.NonRecoverableException: Table

[kudu-CR] [tests] clean-up on kudu::client::ScanToStrings

Todd Lipcon has posted comments on this change. Change subject: [tests] clean-up on kudu::client::ScanToStrings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7027/1/src/kudu/client/client-test-util.h File