[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12157 ) Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock .. Patch Set 9: Verified+1 Overriding Jenkins, ASAN

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12157 To

[kudu-CR] generic iterators: basic MergeIterator dominance

2019-01-14 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12197 to look at the new patch set (#6). Change subject: generic_iterators: basic MergeIterator dominance

[kudu-CR] generic iterators: assorted cleanup

2019-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 ) Change subject: generic_iterators: assorted cleanup .. Patch Set 4: (2 comments)

[kudu-CR] generic iterators: assorted cleanup

2019-01-14 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12156 to look at the new patch set (#5). Change subject: generic_iterators: assorted cleanup

[kudu-CR] generic iterators: basic MergeIterator dominance

2019-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Patch Set 6: (4 comments)

[kudu-CR] generic iterators: move iterator declarations into cc file

2019-01-14 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12223 to look at the new patch set (#2). Change subject: generic_iterators: move iterator declarations into cc file

[kudu-CR] client: avoid accessing state after scheduling retry

2019-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. client: avoid accessing state after scheduling retry I