[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17279 ) Change subject: KUDU-1884 Make Kerberos principal customizable .. Patch Set 5: (5 comments)

[kudu-CR] KUDU-3248: Match C++ replica selection behavior of Java client

2021-04-08 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17129 to look at the new patch set (#6). Change subject: KUDU-3248: Match C++ replica selection behavior of Java client

[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17279 to look at the new patch set (#6). Change subject: KUDU-1884 Make Kerberos principal customizable

[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17281 to look at the new patch set (#4). Change subject: [python] KUDU-1884 Make SASL protocol configurable

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17280 ) Change subject: [java] KUDU-1884 Make SASL proto name configurable .. Patch Set 4: Code-Review+2 (1 comment) LGTM!

[kudu-CR] KUDU-3248: Match C++ replica selection behavior of Java client

2021-04-08 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17129 to look at the new patch set (#7). Change subject: KUDU-3248: Match C++ replica selection behavior of Java client

[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3268: fix race between MM scheduler and op launch

2021-04-08 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17291 to review the following change. Change subject: KUDU-3268: fix race between MM scheduler and op launch ..

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17280 to look at the new patch set (#5). Change subject: [java] KUDU-1884 Make SASL proto name configurable

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17280 ) Change subject: [java] KUDU-1884 Make SASL proto name configurable .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17279 ) Change subject: KUDU-1884 Make Kerberos principal customizable .. Patch Set 6: (3 comments)

[kudu-CR](branch-1.14.x) KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17293 ) Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3248: Match C++ replica selection behavior of Java client

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17129 ) Change subject: KUDU-3248: Match C++ replica selection behavior of Java client .. Patch Set 7: Code-Review+1 (3 comments) LGTM, just

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [java] KUDU-1884 Make SASL proto name configurable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17280 To

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17280 ) Change subject: [java] KUDU-1884 Make SASL proto name configurable .. Patch Set 5: Verified+1 -- To view, visit

[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17279 ) Change subject: KUDU-1884 Make Kerberos principal customizable .. Patch Set 6: Code-Review+2 (2 comments) LGTM, but Grant might have

[kudu-CR] KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17291 ) Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. Patch Set 2: > Thank you for the fix! Does it makes

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17280 ) Change subject: [java] KUDU-1884 Make SASL proto name configurable .. Patch Set 5: (1 comment)

[kudu-CR](branch-1.14.x) KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17293 Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. KUDU-3268: fix race between MM scheduling and

[kudu-CR] KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17291 ) Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. Patch Set 2: Verified+1 Test failure seems unrelated to

[kudu-CR] KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17291 ) Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. KUDU-3268: fix race between MM scheduling and

[kudu-CR] KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17291 To

[kudu-CR] KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17291 to look at the new patch set (#2). Change subject: KUDU-3268: fix race between MM scheduling and unregistration

[kudu-CR] KUDU-3268: fix race between MM scheduling and unregistration

2021-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17291 ) Change subject: KUDU-3268: fix race between MM scheduling and unregistration .. Patch Set 2: Code-Review+2 Thank you for the fix!

[kudu-CR] [java] add testGet() for TableLocationsCache

2021-04-08 Thread Li Zhiming (Code Review)
Li Zhiming has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17288 Change subject: [java] add testGet() for TableLocationsCache .. [java] add testGet() for TableLocationsCache If get(key) is immediately

[kudu-CR] [java] add testGet() for TableLocationsCache

2021-04-08 Thread Li Zhiming (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17288 to look at the new patch set (#3). Change subject: [java] add testGet() for TableLocationsCache ..

[kudu-CR] [java] add testGet() for TableLocationsCache

2021-04-08 Thread Li Zhiming (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17288 to look at the new patch set (#2). Change subject: [java] add testGet() for TableLocationsCache .. [java] add

[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17279 ) Change subject: KUDU-1884 Make Kerberos principal customizable .. Patch Set 4: (9 comments)

[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17279 to look at the new patch set (#4). Change subject: KUDU-1884 Make Kerberos principal customizable

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17280 to look at the new patch set (#3). Change subject: [java] KUDU-1884 Make SASL proto name configurable

[kudu-CR] KUDU-1884 Make Kerberos principal customizable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17279 to look at the new patch set (#5). Change subject: KUDU-1884 Make Kerberos principal customizable

[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable

2021-04-08 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17281 to look at the new patch set (#3). Change subject: [python] KUDU-1884 Make SASL protocol configurable

[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 3: (3 comments)

[kudu-CR] [java] KUDU-1884 Make SASL proto name configurable

2021-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17280 ) Change subject: [java] KUDU-1884 Make SASL proto name configurable .. Patch Set 3: (4 comments)