Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17129 )
Change subject: KUDU-3248: Match C++ replica selection behavior of Java client ...................................................................... Patch Set 7: Code-Review+1 (3 comments) LGTM, just a few nits http://gerrit.cloudera.org:8080/#/c/17129/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17129/7//COMMIT_MSG@18 PS7, Line 18: seperate typo: separate http://gerrit.cloudera.org:8080/#/c/17129/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17129/7/src/kudu/client/client-test.cc@2593 PS7, Line 2593: * style nit here and elsewhere: we tend to stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/17129/7/src/kudu/client/client-test.cc@2610 PS7, Line 2610: KuduClient::CLOSEST_REPLICA, : nit: indent -- To view, visit http://gerrit.cloudera.org:8080/17129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Gerrit-Change-Number: 17129 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Apr 2021 23:26:48 +0000 Gerrit-HasComments: Yes
