[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: arena: fix alignment of NewObject<> results, use variadic template .. arena: fix alignment of NewObject<> results, use variadic template This makes two f

[kudu-CR] write transaction: allocate RowOp objects from the arena

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: write_transaction: allocate RowOp objects from the arena .. write_transaction: allocate RowOp objects from the arena This improves the memory locality of

[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: arena: fix alignment of NewObject<> results, use variadic template .. Patch Set 2: Verified+1 Jenkins issue seems unrelated (timing issue) -- To view, visit htt

[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: arena: fix alignment of NewObject<> results, use variadic template .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6492 To unsubsc

[kudu-CR] write transaction: allocate RowOp objects from the arena

2017-03-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: write_transaction: allocate RowOp objects from the arena .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6480 To unsubscri

[kudu-CR] WIP: interval tree: allow bulk queries

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6481 to look at the new patch set (#3). Change subject: WIP: interval_tree: allow bulk queries .. WIP: interval_tree: al

[kudu-CR] WIP: rowset tree: add bulk queries

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6482 to look at the new patch set (#3). Change subject: WIP: rowset_tree: add bulk queries .. WIP: rowset_tree: add bulk

[kudu-CR] interval tree: improve an O(n) loop to O(lg n)

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6496 Change subject: interval_tree: improve an O(n) loop to O(lg n) .. interval_tree: improve an O(n) loop to O(lg n) In the interval tree impl

[kudu-CR] write transaction: allocate RowOp objects from the arena

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6480 to look at the new patch set (#3). Change subject: write_transaction: allocate RowOp objects from the arena .. writ

[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6492 to look at the new patch set (#2). Change subject: arena: fix alignment of NewObject<> results, use variadic template .

[kudu-CR] WIP: check for row presence in rowset-wise order

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6483 to look at the new patch set (#5). Change subject: WIP: check for row presence in rowset-wise order .. WIP: check f

[kudu-CR] write transaction: allocate RowOp objects from the arena

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: write_transaction: allocate RowOp objects from the arena .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6480/2/src/kudu/tablet/transactions/write

[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: arena: fix alignment of NewObject<> results, use variadic template .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6492/1/src/kudu/util/memory/a

[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: arena: fix alignment of NewObject<> results, use variadic template .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6492/1//COMMIT_MSG Commit Mess

[kudu-CR] WIP: check for row presence in rowset-wise order

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6483 to look at the new patch set (#4). Change subject: WIP: check for row presence in rowset-wise order .. WIP: check f

[kudu-CR] [docs] Add security guide

2017-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6479/1/docs/security.adoc File docs/security.adoc: PS1, Line 80: For th

[kudu-CR] arena: fix alignment of NewObject<> results, use variadic template

2017-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: arena: fix alignment of NewObject<> results, use variadic template .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6492/1//COMMIT_MSG Commit Mess

[kudu-CR] fuzz-itest: fix a test failure with scan-at-snapshot

2017-03-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: fuzz-itest: fix a test failure with scan-at-snapshot .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6494/1/src/kudu/integration-tests/fuz

[kudu-CR] write transaction: allocate RowOp objects from the arena

2017-03-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: write_transaction: allocate RowOp objects from the arena .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6480/2/src/kudu/tablet/transactio

[kudu-CR] WIP: check for row presence in rowset-wise order

2017-03-27 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6483 to look at the new patch set (#3). Change subject: WIP: check for row presence in rowset-wise order .. WIP: check f

[kudu-CR] docs: Add a section for evolving gflags

2017-03-27 Thread Mike Percy (Code Review)
Hello Will Berkeley, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6489 to look at the new patch set (#2). Change subject: docs: Add a section for evolving gflags .

[kudu-CR] docs: Add a section for evolving gflags

2017-03-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: Add a section for evolving gflags .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6489/1/docs/configuration_reference_unsupported.adoc File d

[kudu-CR] docs: Add a section for evolving gflags

2017-03-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: docs: Add a section for evolving gflags .. Patch Set 1: Code-Review+1 (1 comment) Generated docs look good. http://gerrit.cloudera.org:8080/#/c/6489/1/docs/con

[kudu-CR] docs: Move documentation style guide from user guide to design-docs

2017-03-27 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: docs: Move documentation style guide from user guide to design-docs .. docs: Move documentation style guide from user guide to design-docs This isn't v

[kudu-CR] docs: Move documentation style guide from user guide to design-docs

2017-03-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: docs: Move documentation style guide from user guide to design-docs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6490 To uns

[kudu-CR] docs: Move documentation style guide from user guide to design-docs

2017-03-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: Move documentation style guide from user guide to design-docs .. Patch Set 2: Verified+1 Overriding ITClient test failure -- To view, visit http://gerrit.c

[kudu-CR] docs: Add a section for evolving gflags

2017-03-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: Add a section for evolving gflags .. Patch Set 1: Here you go: http://mpercy.github.io/kudu/docs/ -- To view, visit http://gerrit.cloudera.org:8080/6489 To

[kudu-CR] docs: Move documentation style guide from user guide to design-docs

2017-03-27 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6490 to look at the new patch set (#2). Change subject: docs: Move documentation style guide from user guide to design-docs ...

[kudu-CR] [docs] Add security guide

2017-03-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6479/1/docs/security.adoc File docs/security.adoc: Line 31: access from un

[kudu-CR] docs: Move documentation style guide from user guide to design-docs

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Move documentation style guide from user guide to design-docs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6490 To unsub

[kudu-CR] docs: Add a section for evolving gflags

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Add a section for evolving gflags .. Patch Set 1: Code-Review+1 Seems reasonable. Do you have a published copy handy? -- To view, visit http://gerrit.cloud

[kudu-CR] docs: Fix "make site"

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Fix "make site" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6488 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] docs: Fix "make site"

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: docs: Fix "make site" .. docs: Fix "make site" * "make site" was broken due to changed command-line argments on "docs/support/scripts/make_site.sh". Thi

[kudu-CR] generic iterators: avoid holding completed iters in merge/union

2017-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: generic_iterators: avoid holding completed iters in merge/union .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6460/1/src/kudu/common/generic_it

[kudu-CR] log block manager: use sparse hash map for block map

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log_block_manager: use sparse_hash_map for block map .. log_block_manager: use sparse_hash_map for block map Based on my testing, this reduces the memory

[kudu-CR] log block manager: use sparse hash map for block map

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 4: Verified+1 Test failure was unrelated (put up a fix here: http://gerrit.cloudera.org:8080/649

[kudu-CR] fuzz-itest: fix a test failure with scan-at-snapshot

2017-03-27 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6494 to review the following change. Change subject: fuzz-itest: fix a test failure with scan-at-snapshot .. fuzz-i

[kudu-CR] [docs] Add security guide

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: Dan's on PTO this week so I'll take care of reviewing and revising this one. -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Update rpc.md with authentication protocol details

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Update rpc.md with authentication protocol details .. Update rpc.md with authentication protocol details Change-Id: Iae4c296a53ee31a7a1012acaa954ec72db5ad

[kudu-CR] generic iterators: avoid holding completed iters in merge/union

2017-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: generic_iterators: avoid holding completed iters in merge/union .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6460/1/src/kudu/common/generic_it

[kudu-CR] generic iterators: avoid holding completed iters in merge/union

2017-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: generic_iterators: avoid holding completed iters in merge/union .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6460/1//COMMIT_MSG Commit Message

[kudu-CR] Spark ITBLL

2017-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Spark ITBLL .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6419/2/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTes