[kudu-CR] Random cleanups in RaftConsensus

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9267 ) Change subject: Random cleanups in RaftConsensus .. Patch Set 1: It seems TsTabletManagerITest.ReportOnReplicaHealthStatus starts

[kudu-CR] WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9266 to review the following change. Change subject: WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown

[kudu-CR] Random cleanups in RaftConsensus

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9267 to review the following change. Change subject: Random cleanups in RaftConsensus .. Random cleanups in

[kudu-CR] Add additonal form and tests for GetConsensusRole()

2018-02-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9260 ) Change subject: Add additonal form and tests for GetConsensusRole() .. Add additonal form and tests for GetConsensusRole() There

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9261 ) Change subject: cmeta: Use more efficient form of GetConsensusRole() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add additonal form and tests for GetConsensusRole()

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9260 ) Change subject: Add additonal form and tests for GetConsensusRole() .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Add additonal form and tests for GetConsensusRole()

2018-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9260 ) Change subject: Add additonal form and tests for GetConsensusRole() .. Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) > > LGTM,

[kudu-CR] Add additonal form and tests for GetConsensusRole()

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9260 to look at the new patch set (#2). Change subject: Add additonal form and tests for GetConsensusRole()

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-08 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 ) Change subject: Fix client comaptibility with gcc 4.4 .. Patch Set 2: (2 comments)

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-08 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9257 to look at the new patch set (#3). Change subject: Fix client comaptibility with gcc 4.4 ..

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9263 to review the following change. Change subject: Make tcmalloc heap sampling more useful .. Make tcmalloc heap

[kudu-CR] KUDU-1704: add java client support for READ YOUR WRITES mode

2018-02-08 Thread Hao Hao (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8847 to look at the new patch set (#4). Change subject: KUDU-1704: add java client support for READ_YOUR_WRITES mode

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-08 Thread Hao Hao (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8823 to look at the new patch set (#6). Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-08 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8804 to look at the new patch set (#12). Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 ) Change subject: Fix client comaptibility with gcc 4.4 .. Patch Set 2: (3 comments)

[kudu-CR] TSTabletManager::DeleteTabletData() should log delete type on success

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9259 ) Change subject: TSTabletManager::DeleteTabletData() should log delete_type on success .. TSTabletManager::DeleteTabletData()

[kudu-CR] TSTabletManager::DeleteTabletData() should log delete type on success

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9259 ) Change subject: TSTabletManager::DeleteTabletData() should log delete_type on success .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] Add additonal form and tests for GetConsensusRole()

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9260 ) Change subject: Add additonal form and tests for GetConsensusRole() .. Patch Set 1: (1 comment) LGTM, just a small nit/question.

[kudu-CR] thirdparty: disable the gperftools heap checker

2018-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9258 ) Change subject: thirdparty: disable the gperftools heap checker .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9262 to review the following change. Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

[kudu-CR] TSTabletManager::DeleteTabletData() should log delete type on success

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9259 to review the following change. Change subject: TSTabletManager::DeleteTabletData() should log delete_type on success

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9261 to review the following change. Change subject: cmeta: Use more efficient form of GetConsensusRole() .. cmeta: Use

[kudu-CR] Add additonal form and tests for GetConsensusRole()

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9260 to review the following change. Change subject: Add additonal form and tests for GetConsensusRole() .. Add

[kudu-CR] thirdparty: disable the gperftools heap checker

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9258 to review the following change. Change subject: thirdparty: disable the gperftools heap checker .. thirdparty:

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-08 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9257 to look at the new patch set (#2). Change subject: Fix client comaptibility with gcc 4.4 ..

[kudu-CR] [docs] Add scaling guide

2018-02-08 Thread Will Berkeley (Code Review)
Hello Alex Rodoni, Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8842 to look at the new patch set (#4). Change subject: [docs] Add scaling guide

[kudu-CR] [docs] Add scaling guide

2018-02-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8842 ) Change subject: [docs] Add scaling guide .. Patch Set 3: (7 comments)

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2018-02-08 Thread Will Berkeley (Code Review)
Hello Alex Rodoni, Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8402 to look at the new patch set (#8). Change subject: [docs] Document how to recover from a majority failed tablet

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2018-02-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 7: (5 comments)

[kudu-CR] Add log parser script

2018-02-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8229 ) Change subject: Add log parser script .. Patch Set 3: (3 comments) This is useful. In my testing, it takes from 20-30 minutes to run

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-08 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9257 Change subject: Fix client comaptibility with gcc 4.4 .. Fix client comaptibility with gcc 4.4 We expect the client lib to work with gcc

[kudu-CR] KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9252 to look at the new patch set (#2). Change subject: KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9254 to look at the new patch set (#2). Change subject: KUDU-2291 (part 3): use futex to speed up stack collection

[kudu-CR] WIP: KUDU-2291 (part 2): Add a /stacks page

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9253 to look at the new patch set (#2). Change subject: WIP: KUDU-2291 (part 2): Add a /stacks page

[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it

2018-02-08 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/9156 ) Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it .. Abandoned Superseded by https://gerrit.cloudera.org/c/9246/ -- To

[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it

2018-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9156 ) Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it .. Patch Set 2: > I think this looks good as is, but of

[kudu-CR] KUDU-2274. Shut down tombstoned replica when replacing it

2018-02-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9246 to look at the new patch set (#2). Change subject: KUDU-2274. Shut down tombstoned replica when replacing it

[kudu-CR] KUDU-2274. consensus: Remove ConsensusMetadata thread safety

2018-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9246 ) Change subject: KUDU-2274. consensus: Remove ConsensusMetadata thread safety .. Patch Set 1: (1 comment)