[kudu-CR] Various fixes for clang-tidy errors

2018-04-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9899 to look at the new patch set (#2). Change subject: Various fixes for clang-tidy errors .. Various fixes

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Upgrade to LLVM/Clang 6.0.0 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9898 To unsubscribe, visit

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Upgrade to LLVM/Clang 6.0.0 This patch contains various changes required to

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Patch Set 4: Verified+1 Code-Review+2 Failure was an existing flake:

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Patch Set 4: test failure was just a flaky test (known, fix in progress elsewhere) --

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9898 to look at the new patch set (#4). Change subject: Upgrade to LLVM/Clang 6.0.0 .. Upgrade to

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Patch Set 3: (1 comment)

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Patch Set 3: (1 comment)

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Patch Set 3: (2 comments)

[kudu-CR] Upgrade to LLVM/Clang 6.0.0

2018-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 ) Change subject: Upgrade to LLVM/Clang 6.0.0 .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-04-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 6: Verified+1 Unrelated clock sync errors:

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-04-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 5: (1 comment) > (1 comment) > > How does

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10077 To

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-04-17 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10054 to look at the new patch set (#6). Change subject: [tools] minor enhancements on 'kudu cluster ksck' output

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 6: Verified+1 -- To view, visit

[kudu-CR] [Java] Clean up kudu-hive dependencies

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10089 ) Change subject: [Java] Clean up kudu-hive dependencies .. [Java] Clean up kudu-hive dependencies Cleans up the kudu-hive

[kudu-CR] [Java] Clean up kudu-hive dependencies

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [Java] Clean up kudu-hive dependencies .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10089 To unsubscribe, visit

[kudu-CR] [Java] Clean up kudu-hive dependencies

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10089 ) Change subject: [Java] Clean up kudu-hive dependencies .. Patch Set 2: Fixed a silly typo. -- To view, visit

[kudu-CR] [Java] Clean up kudu-hive dependencies

2018-04-17 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10089 to look at the new patch set (#2). Change subject: [Java] Clean up kudu-hive dependencies .. [Java]

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2378. Fix unaligned loads of int128 from rows

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9848 ) Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. KUDU-2378. Fix unaligned loads of int128 from rows Our row

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-17 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10077 to look at the new patch set (#5). Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting

[kudu-CR] [Java] Clean up kudu-hive dependencies

2018-04-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10089 ) Change subject: [Java] Clean up kudu-hive dependencies .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2378. Fix unaligned loads of int128 from rows

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9848 ) Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Clean up kudu-hive dependencies

2018-04-17 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10089 Change subject: [Java] Clean up kudu-hive dependencies .. [Java] Clean up kudu-hive dependencies Cleans up the kudu-hive dependencies in

[kudu-CR] ksck: add virtual destructor to KsckCluster

2018-04-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10088 ) Change subject: ksck: add virtual destructor to KsckCluster .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] ksck: add virtual destructor to KsckCluster

2018-04-17 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10088 to review the following change. Change subject: ksck: add virtual destructor to KsckCluster .. ksck: add virtual

[kudu-CR] KUDU-2378. Fix unaligned loads of int128 from rows

2018-04-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9848 ) Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as a metric .. Patch Set 2: (8 comments)

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-17 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#2). Change subject: KUDU-2287 Expose election failures as a metric

[kudu-CR] KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls

2018-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9897 ) Change subject: KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls .. KUDU-2394. Fix flaky

[kudu-CR] KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls

2018-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9897 ) Change subject: KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls .. Patch Set 3: Code-Review+2 -- To view, visit