[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-18 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10077 to look at the new patch set (#7). Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting

[kudu-CR] KUDU-2412: Fix python client compilation in el6 environments

2018-04-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10114 Change subject: KUDU-2412: Fix python client compilation in el6 environments .. KUDU-2412: Fix python client compilation in el6

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 1: (1 comment) Ended up redoing this a bit for rev 2

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-18 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10106 to look at the new patch set (#2). Change subject: Modify fix_includes.py for Kudu usage, add a wrapper

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 3: (6 comments)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#3). Change subject: KUDU-2191: Metadata Upgrade Tool ..

[kudu-CR] KUDU-2191 (n/m): PoC: disallow Kudu alter column, create table operations from Hive

2018-04-18 Thread Dan Burkert (Code Review)
Hello Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10111 to review the following change. Change subject: KUDU-2191 (n/m): PoC: disallow Kudu alter column, create table operations from Hive

[kudu-CR](branch-1.7.x) KUDU-2378. Fix unaligned loads of int128 from rows

2018-04-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10110 Change subject: KUDU-2378. Fix unaligned loads of int128 from rows .. KUDU-2378. Fix unaligned loads of int128 from rows Our row format

[kudu-CR] tidy: run in parallel

2018-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10107 ) Change subject: tidy: run in parallel .. tidy: run in parallel This makes the 'tidy' target run in parallel across all cores on

[kudu-CR] iwyu: run IWYU on multiple cores

2018-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10104 ) Change subject: iwyu: run IWYU on multiple cores .. iwyu: run IWYU on multiple cores This changes iwyu_tool to use a number of

[kudu-CR] Import original fix includes.py script from IWYU

2018-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10105 ) Change subject: Import original fix_includes.py script from IWYU .. Import original fix_includes.py script from IWYU Imported

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. [spark] KUDU-2371: Add KuduWriteOptions

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 11: (4 comments)

[kudu-CR] iwyu: run IWYU on multiple cores

2018-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10104 ) Change subject: iwyu: run IWYU on multiple cores .. Patch Set 1: That looks great! Now it should be much faster. -- To view, visit

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-18 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#11). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] tidy: run in parallel

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10107 ) Change subject: tidy: run in parallel .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10107 To

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 ) Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] iwyu: run IWYU on multiple cores

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10104 ) Change subject: iwyu: run IWYU on multiple cores .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10104

[kudu-CR] iwyu: run IWYU on multiple cores

2018-04-18 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10104 to review the following change. Change subject: iwyu: run IWYU on multiple cores .. iwyu: run IWYU on multiple cores

[kudu-CR] tidy: run in parallel

2018-04-18 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10107 to review the following change. Change subject: tidy: run in parallel .. tidy: run in parallel This makes the

[kudu-CR] Modify fix includes.py for Kudu usage, add a wrapper

2018-04-18 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10106 to review the following change. Change subject: Modify fix_includes.py for Kudu usage, add a wrapper .. Modify

[kudu-CR] Add krb5-server to SLES prerequisite libraries

2018-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9727 ) Change subject: Add krb5-server to SLES prerequisite libraries .. Add krb5-server to SLES prerequisite libraries I was running a

[kudu-CR] Import original fix includes.py script from IWYU

2018-04-18 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10105 to review the following change. Change subject: Import original fix_includes.py script from IWYU .. Import original

[kudu-CR] Add krb5-server to SLES prerequisite libraries

2018-04-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9727 ) Change subject: Add krb5-server to SLES prerequisite libraries .. Patch Set 1: Code-Review+2 Carry +2. I think we forgot to merge

[kudu-CR] Re-enable IWYU checks on HMS module

2018-04-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10102 to look at the new patch set (#2). Change subject: Re-enable IWYU checks on HMS module

[kudu-CR] Re-enable IWYU checks on HMS module

2018-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10102 ) Change subject: Re-enable IWYU checks on HMS module .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Re-enable IWYU checks on HMS module

2018-04-18 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10102 to review the following change. Change subject: Re-enable IWYU checks on HMS module .. Re-enable IWYU

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] Various fixes for clang-tidy errors

2018-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 ) Change subject: Various fixes for clang-tidy errors .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts

2018-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 ) Change subject: KUDU-2365: [Java] Fix Gradle Artifacts .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [Java] Fix Guava transitive dependecies

2018-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 ) Change subject: [Java] Fix Guava transitive dependecies .. Patch Set 2: Code-Review+1 Will defer to Dan. -- To view, visit

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10095 ) Change subject: [Java] Mark the Yetus annotations dependency optional .. Patch Set 2: (1 comment)

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 ) Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting .. Patch Set 6: (1 comment)

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 10: (1 comment)

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-18 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9834 to look at the new patch set (#10). Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts

2018-04-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10097 Change subject: KUDU-2365: [Java] Fix Gradle Artifacts .. KUDU-2365: [Java] Fix Gradle Artifacts This resolves KUDU-2365 and adresses

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-18 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10095 to look at the new patch set (#2). Change subject: [Java] Mark the Yetus annotations dependency optional .. [Java]

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-18 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as a metric .. Patch Set 5: > Patch Set 5: > > Build Started

[kudu-CR] [Java] Mark the Yetus annotations dependency optional

2018-04-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10095 Change subject: [Java] Mark the Yetus annotations dependency optional .. [Java] Mark the Yetus annotations dependency optional Given the

[kudu-CR] [Java] Fix Guava transitive dependecies

2018-04-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10096 Change subject: [Java] Fix Guava transitive dependecies .. [Java] Fix Guava transitive dependecies In Guava 22.0+ the annotations

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-18 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#5). Change subject: KUDU-2287 Expose election failures as a metric

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-18 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#4). Change subject: KUDU-2287 Expose election failures as a metric

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-18 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as a metric .. Patch Set 3: (2 comments) > Patch Set 2: > > (1 comment)

[kudu-CR] KUDU-2287 Expose election failures as a metric

2018-04-18 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#3). Change subject: KUDU-2287 Expose election failures as a metric