[kudu-CR] Consider the available space when selecting data dirs for blocks.
ZhangYao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13975 )
Change subject: Consider the available space when selecting data dirs for
blocks.
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13975/6/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/13975/6/src/kudu/fs/data_dirs.cc@991
PS6, Line 991:
: if (FLAGS_refresh_is_full_with_expired_only_for_testing) {
: // This currently should only be reached by
disk_failure-itest.
: refresh_mode = DataDir::RefreshMode::EXPIRED_ONLY;
: }
> I'm confused about why this is necessary. Why do we need this here?
1. FLAGS_refresh_is_full_with_expired_only_for_testing
That is necessary because DiskErrorITest.TestFailDuringScanWorkload(with
DISK_FAILURE) wanted all tablets fail because DISK_FAILURE and then recovery.
It only inject that diskerror in one dir. When the FlushMrs running backend try
to write data it will get injected disk failure while preallocate space, so all
tablets in that dir will fail. However, after my change I will really check
dirs space so that "disk error dir" will not be selected, so all tablets will
not fail. That why I have to change the behaviors when doing test.
2. Dirs in same disk have the same available space. In my docker machine it
work like that. So if all dir located in the same disk, it do need try to
select one which have fewer tablets :)
--
To view, visit http://gerrit.cloudera.org:8080/13975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529
Gerrit-Change-Number: 13975
Gerrit-PatchSet: 6
Gerrit-Owner: ZhangYao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: ZhangYao
Gerrit-Comment-Date: Tue, 06 Aug 2019 05:43:26 +
Gerrit-HasComments: Yes
[kudu-CR] [code style] Keep same code style in test files
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14016 Change subject: [code style] Keep same code style in test files .. [code style] Keep same code style in test files Change all ASSERT_NO_FATAL_FAILURE to NO_FATALS to keep the same code style in test files. Change-Id: I67689fe8113d88f60ac33fa38504813128209da3 --- M src/kudu/cfile/bloomfile-test.cc M src/kudu/cfile/mt-bloomfile-test.cc M src/kudu/client/client-test.cc M src/kudu/common/wire_protocol-test.cc M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/leader_election-test.cc M src/kudu/consensus/mt-log-test.cc M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/update_scan_delta_compact-test.cc M src/kudu/master/master-test.cc M src/kudu/rpc/rpc-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/composite-pushdown-test.cc M src/kudu/tablet/major_delta_compaction-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/util/env-test.cc M src/kudu/util/trace-test.cc 26 files changed, 227 insertions(+), 227 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14016/1 -- To view, visit http://gerrit.cloudera.org:8080/14016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3 Gerrit-Change-Number: 14016 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin
[kudu-CR] Consider the available space when selecting data dirs for blocks.
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/13975 )
Change subject: Consider the available space when selecting data dirs for
blocks.
..
Patch Set 6:
(1 comment)
The itself code looks fine, but I don't love the idea of having that test-only
flag change the behavior like that. Could you explain a bit more why it's
necessary?
http://gerrit.cloudera.org:8080/#/c/13975/6/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/13975/6/src/kudu/fs/data_dirs.cc@991
PS6, Line 991:
: if (FLAGS_refresh_is_full_with_expired_only_for_testing) {
: // This currently should only be reached by
disk_failure-itest.
: refresh_mode = DataDir::RefreshMode::EXPIRED_ONLY;
: }
I'm confused about why this is necessary. Why do we need this here?
Also, I'm curious, in most tests that use a minicluster, the data directories
all share a single disk, even though they are different directories. If that's
the case, do they all have the same available space? If so, I wonder if we
should add a way to break ties. For example, select two, and if they have the
same space, select the one that has fewer tablets. What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/13975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529
Gerrit-Change-Number: 13975
Gerrit-PatchSet: 6
Gerrit-Owner: ZhangYao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: ZhangYao
Gerrit-Comment-Date: Tue, 06 Aug 2019 04:52:44 +
Gerrit-HasComments: Yes
[kudu-CR] POC: Remove the Sentry Integration
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14006 to look at the new patch set (#4). Change subject: POC: Remove the Sentry Integration .. POC: Remove the Sentry Integration This is done as an experiment to enable upgrading to Hive 3. Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 --- M CMakeLists.txt M build-support/dist_test.py M build-support/run_dist_test.py M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_failover-itest.cc D src/kudu/integration-tests/master_sentry-itest.cc D src/kudu/integration-tests/ts_sentry-itest.cc M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc D src/kudu/master/sentry_authz_provider-test-base.h D src/kudu/master/sentry_authz_provider-test.cc D src/kudu/master/sentry_authz_provider.cc D src/kudu/master/sentry_authz_provider.h D src/kudu/master/sentry_client_metrics.cc D src/kudu/master/sentry_client_metrics.h D src/kudu/master/sentry_privileges_cache_metrics.cc D src/kudu/master/sentry_privileges_cache_metrics.h D src/kudu/master/sentry_privileges_fetcher.cc D src/kudu/master/sentry_privileges_fetcher.h M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h D src/kudu/sentry/CMakeLists.txt D src/kudu/sentry/mini_sentry.cc D src/kudu/sentry/mini_sentry.h D src/kudu/sentry/sentry-test-base.h D src/kudu/sentry/sentry_action-test.cc D src/kudu/sentry/sentry_action.cc D src/kudu/sentry/sentry_action.h D src/kudu/sentry/sentry_authorizable_scope-test.cc D src/kudu/sentry/sentry_authorizable_scope.cc D src/kudu/sentry/sentry_authorizable_scope.h D src/kudu/sentry/sentry_client-test.cc D src/kudu/sentry/sentry_client.cc D src/kudu/sentry/sentry_client.h D src/kudu/sentry/sentry_common_service.thrift D src/kudu/sentry/sentry_policy_service.thrift D src/kudu/sentry/thrift_operators-test.cc D src/kudu/sentry/thrift_operators.cc M src/kudu/thrift/client.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_master.cc M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh M thirdparty/vars.sh 51 files changed, 38 insertions(+), 8,244 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14006/4 -- To view, visit http://gerrit.cloudera.org:8080/14006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 Gerrit-Change-Number: 14006 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] POC: Upgrade Hive dependency to 3.1.1
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13256 to look at the new patch set (#11). Change subject: POC: Upgrade Hive dependency to 3.1.1 .. POC: Upgrade Hive dependency to 3.1.1 This patch - Upgrades Hive to 3.1.1 - Upgrades Hadoop to 3.2.0 - Uses the Hive `schematool` to initialized the derby database in the MiniHms. This fixes issues with autoCreate and is more representative of a production environment. - Workaround HIVE-21614 by using `LIKE` instead of `=` when filtering tables. Change-Id: Iec3ab2cc4e41a26cee8dd7f7098a2f288c56a42c --- M java/gradle/dependencies.gradle M java/kudu-hive/build.gradle M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java M src/kudu/hms/CMakeLists.txt M src/kudu/hms/hive_metastore.thrift M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_client-test.cc M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/util/subprocess.cc M src/kudu/util/subprocess.h M thirdparty/package-hadoop.sh M thirdparty/vars.sh 13 files changed, 862 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/13256/11 -- To view, visit http://gerrit.cloudera.org:8080/13256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec3ab2cc4e41a26cee8dd7f7098a2f288c56a42c Gerrit-Change-Number: 13256 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [ksck] Filter tables and tablets in KsckCluster
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 ) Change subject: [ksck] Filter tables and tablets in KsckCluster .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc@502 PS5, Line 502: msg += " Filter:"; > If there are tablets in a cluster and all tablets filtered out, the result is > 'No tablet replicas found' error. Why should this be an error? If there were tablets but the user filtered them all out, shouldn't this be Status::OK? > If there are table(s) but no tablet in a cluster(i.e. all range partitions > have been dropped), the result is 'OK'. Agreed. > The comment 'Warn if the table has tablets, but no replicas.' is confusing, > is it possible 'the table has tablets but no replicas'? No, that doesn't seem possible. > However in this patch, the 'cluster_' here is not complete, it only includes > unfiltered tables/tablets, so in both cases the checksum result is 'No > tablet replicas found' error. I think it's not necessary to distinguish > between the two cases. Would it be difficult to add tracking of the list of filtered tables/tablets in KsckCluster, and then use it to differentiate between the two cases here? -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 8 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Mon, 05 Aug 2019 22:29:55 + Gerrit-HasComments: Yes
[kudu-CR] POC: Remove the Sentry Integration
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14006 to look at the new patch set (#3). Change subject: POC: Remove the Sentry Integration .. POC: Remove the Sentry Integration This is done as an experiment to enable upgrading to Hive 3. Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 --- M CMakeLists.txt M build-support/dist_test.py M build-support/run_dist_test.py M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_failover-itest.cc D src/kudu/integration-tests/master_sentry-itest.cc D src/kudu/integration-tests/ts_sentry-itest.cc M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc D src/kudu/master/sentry_authz_provider-test-base.h D src/kudu/master/sentry_authz_provider-test.cc D src/kudu/master/sentry_authz_provider.cc D src/kudu/master/sentry_authz_provider.h D src/kudu/master/sentry_client_metrics.cc D src/kudu/master/sentry_client_metrics.h D src/kudu/master/sentry_privileges_cache_metrics.cc D src/kudu/master/sentry_privileges_cache_metrics.h D src/kudu/master/sentry_privileges_fetcher.cc D src/kudu/master/sentry_privileges_fetcher.h M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h D src/kudu/sentry/CMakeLists.txt D src/kudu/sentry/mini_sentry.cc D src/kudu/sentry/mini_sentry.h D src/kudu/sentry/sentry-test-base.h D src/kudu/sentry/sentry_action-test.cc D src/kudu/sentry/sentry_action.cc D src/kudu/sentry/sentry_action.h D src/kudu/sentry/sentry_authorizable_scope-test.cc D src/kudu/sentry/sentry_authorizable_scope.cc D src/kudu/sentry/sentry_authorizable_scope.h D src/kudu/sentry/sentry_client-test.cc D src/kudu/sentry/sentry_client.cc D src/kudu/sentry/sentry_client.h D src/kudu/sentry/sentry_common_service.thrift D src/kudu/sentry/sentry_policy_service.thrift D src/kudu/sentry/thrift_operators-test.cc D src/kudu/sentry/thrift_operators.cc M src/kudu/thrift/client.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_master.cc M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh M thirdparty/vars.sh 51 files changed, 38 insertions(+), 8,238 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14006/3 -- To view, visit http://gerrit.cloudera.org:8080/14006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 Gerrit-Change-Number: 14006 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] POC: Remove the Sentry Integration
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14006 to look at the new patch set (#2). Change subject: POC: Remove the Sentry Integration .. POC: Remove the Sentry Integration This is done as an experiment to enable upgrading to Hive 3. Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 --- M CMakeLists.txt M build-support/dist_test.py M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_failover-itest.cc D src/kudu/integration-tests/master_sentry-itest.cc D src/kudu/integration-tests/ts_sentry-itest.cc M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc D src/kudu/master/sentry_authz_provider-test-base.h D src/kudu/master/sentry_authz_provider-test.cc D src/kudu/master/sentry_authz_provider.cc D src/kudu/master/sentry_authz_provider.h D src/kudu/master/sentry_client_metrics.cc D src/kudu/master/sentry_client_metrics.h D src/kudu/master/sentry_privileges_cache_metrics.cc D src/kudu/master/sentry_privileges_cache_metrics.h D src/kudu/master/sentry_privileges_fetcher.cc D src/kudu/master/sentry_privileges_fetcher.h M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h D src/kudu/sentry/CMakeLists.txt D src/kudu/sentry/mini_sentry.cc D src/kudu/sentry/mini_sentry.h D src/kudu/sentry/sentry-test-base.h D src/kudu/sentry/sentry_action-test.cc D src/kudu/sentry/sentry_action.cc D src/kudu/sentry/sentry_action.h D src/kudu/sentry/sentry_authorizable_scope-test.cc D src/kudu/sentry/sentry_authorizable_scope.cc D src/kudu/sentry/sentry_authorizable_scope.h D src/kudu/sentry/sentry_client-test.cc D src/kudu/sentry/sentry_client.cc D src/kudu/sentry/sentry_client.h D src/kudu/sentry/sentry_common_service.thrift D src/kudu/sentry/sentry_policy_service.thrift D src/kudu/sentry/thrift_operators-test.cc D src/kudu/sentry/thrift_operators.cc M src/kudu/thrift/client.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_master.cc M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh M thirdparty/vars.sh 50 files changed, 36 insertions(+), 8,235 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14006/2 -- To view, visit http://gerrit.cloudera.org:8080/14006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 Gerrit-Change-Number: 14006 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] POC: Upgrade Hive dependency to 3.1.1
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13256 to look at the new patch set (#10). Change subject: POC: Upgrade Hive dependency to 3.1.1 .. POC: Upgrade Hive dependency to 3.1.1 This patch - Upgrades Hive to 3.1.1 - Upgrades Hadoop to 3.2.0 - Uses the Hive `schematool` to initialized the derby database in the MiniHms. This fixes issues with autoCreate and is more representative of a production environment. - Workaround HIVE-21614 by using `LIKE` instead of `=` when filtering tables. Change-Id: Iec3ab2cc4e41a26cee8dd7f7098a2f288c56a42c --- M java/gradle/dependencies.gradle M java/kudu-hive/build.gradle M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java M src/kudu/hms/CMakeLists.txt M src/kudu/hms/hive_metastore.thrift M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_client-test.cc M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/util/subprocess.cc M src/kudu/util/subprocess.h M thirdparty/package-hadoop.sh M thirdparty/vars.sh 13 files changed, 862 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/13256/10 -- To view, visit http://gerrit.cloudera.org:8080/13256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec3ab2cc4e41a26cee8dd7f7098a2f288c56a42c Gerrit-Change-Number: 13256 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] POC: Remove the Sentry Integration
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14006 Change subject: POC: Remove the Sentry Integration .. POC: Remove the Sentry Integration This is done as an experiment to enable upgrading to Hive 3. Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 --- M CMakeLists.txt M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_failover-itest.cc D src/kudu/integration-tests/master_sentry-itest.cc D src/kudu/integration-tests/ts_sentry-itest.cc M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc D src/kudu/master/sentry_authz_provider-test-base.h D src/kudu/master/sentry_authz_provider-test.cc D src/kudu/master/sentry_authz_provider.cc D src/kudu/master/sentry_authz_provider.h D src/kudu/master/sentry_client_metrics.cc D src/kudu/master/sentry_client_metrics.h D src/kudu/master/sentry_privileges_cache_metrics.cc D src/kudu/master/sentry_privileges_cache_metrics.h D src/kudu/master/sentry_privileges_fetcher.cc D src/kudu/master/sentry_privileges_fetcher.h M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h D src/kudu/sentry/CMakeLists.txt D src/kudu/sentry/mini_sentry.cc D src/kudu/sentry/mini_sentry.h D src/kudu/sentry/sentry-test-base.h D src/kudu/sentry/sentry_action-test.cc D src/kudu/sentry/sentry_action.cc D src/kudu/sentry/sentry_action.h D src/kudu/sentry/sentry_authorizable_scope-test.cc D src/kudu/sentry/sentry_authorizable_scope.cc D src/kudu/sentry/sentry_authorizable_scope.h D src/kudu/sentry/sentry_client-test.cc D src/kudu/sentry/sentry_client.cc D src/kudu/sentry/sentry_client.h D src/kudu/sentry/sentry_common_service.thrift D src/kudu/sentry/sentry_policy_service.thrift D src/kudu/sentry/thrift_operators-test.cc D src/kudu/sentry/thrift_operators.cc M src/kudu/thrift/client.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_master.cc M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh M thirdparty/vars.sh 49 files changed, 34 insertions(+), 8,231 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14006/1 -- To view, visit http://gerrit.cloudera.org:8080/14006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4aba59e72191436b3c1a00486104b16e37d7b12 Gerrit-Change-Number: 14006 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] KUDU-2849 Docker image for python kudu client
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14000 ) Change subject: KUDU-2849 Docker image for python kudu client .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@226 PS5, Line 226: RUN pip install --upgrade pip Is this required? http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@228 PS5, Line 228: COPY ./python/requirements.txt /kudu/python/requirements.txt Move this with the other COPY statements. You can use the same workdir as below since requirements.txt will get removed after it's used. http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@231 PS5, Line 231: RUN pip install -r requirements.txt I think this can all be done in one step/layer in the run below. We should also remove the requirements.txt in that step. It's important because each action taken in the dockerfile creates a new layer that make the image larger. https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers -- To view, visit http://gerrit.cloudera.org:8080/14000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cab8ffe114c73752c261f27ebc7a58e4b57a6e Gerrit-Change-Number: 14000 Gerrit-PatchSet: 5 Gerrit-Owner: Sandish Kumar HN Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN Gerrit-Comment-Date: Mon, 05 Aug 2019 12:36:02 + Gerrit-HasComments: Yes
