Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc@502 PS5, Line 502: msg += " Filter:"; > If there are tablets in a cluster and all tablets filtered out, the result is > 'No tablet replicas found' error. Why should this be an error? If there were tablets but the user filtered them all out, shouldn't this be Status::OK? > If there are table(s) but no tablet in a cluster(i.e. all range partitions > have been dropped), the result is 'OK'. Agreed. > The comment 'Warn if the table has tablets, but no replicas.' is confusing, > is it possible 'the table has tablets but no replicas'? No, that doesn't seem possible. > However in this patch, the 'cluster_' here is not complete, it only includes > unfiltered tables/tablets, so in both cases the checksum result is 'No > tablet replicas found' error. I think it's not necessary to distinguish > between the two cases. Would it be difficult to add tracking of the list of filtered tables/tablets in KsckCluster, and then use it to differentiate between the two cases here? -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 8 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2019 22:29:55 +0000 Gerrit-HasComments: Yes
