[kudu-CR] [rest] add oat++ framework to kudu

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 ) Change subject: [rest] add oat++ framework to kudu .. Patch Set 16: (8 comments)

[kudu-CR] [thirdparty] fix building crcutil with GCC 10

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 ) Change subject: [thirdparty] fix building crcutil with GCC 10 .. Patch Set 1: > The change looks good to me. I don't have a strong

[kudu-CR] [master] allow setting BlockCacheMetrics twice

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17636 ) Change subject: [master] allow setting BlockCacheMetrics twice .. Patch Set 2: (6 comments)

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 2: > Patch Set 2: > > > > > Sorry

[kudu-CR] [master] allow setting BlockCacheMetrics twice

2021-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17636 ) Change subject: [master] allow setting BlockCacheMetrics twice .. Patch Set 2: (1 comment)

[kudu-CR] [master] allow setting BlockCacheMetrics twice

2021-06-25 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17636 to look at the new patch set (#2). Change subject: [master] allow setting BlockCacheMetrics twice

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 2: > > > Sorry I didn't

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 2: > > Sorry I didn't

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 2: > Sorry I didn't understand.

[kudu-CR] [thirdparty] fix building crcutil with GCC 10

2021-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 ) Change subject: [thirdparty] fix building crcutil with GCC 10 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] fix building crcutil with GCC 10

2021-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17626 ) Change subject: [thirdparty] fix building crcutil with GCC 10 .. Patch Set 1: The change looks good to me. I don't have a strong

[kudu-CR] [master] allow setting BlockCacheMetrics twice

2021-06-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17636 ) Change subject: [master] allow setting BlockCacheMetrics twice .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 2: Sorry I didn't understand.

[kudu-CR] [thirdparty] fix building LLVM 9 with GCC 10

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17627 ) Change subject: [thirdparty] fix building LLVM 9 with GCC 10 .. [thirdparty] fix building LLVM 9 with GCC 10 This patch fixes

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. [txn_system_client] MonoDelta by

[kudu-CR] [thirdparty] fix building LLVM 9 with GCC 10

2021-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17627 ) Change subject: [thirdparty] fix building LLVM 9 with GCC 10 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] [txn system client] MonoDelta by value in CoordinateTransactionAsync()

2021-06-25 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17611 ) Change subject: [txn_system_client] MonoDelta by value in CoordinateTransactionAsync() .. Patch Set 1: Code-Review+1 -- To

[kudu-CR] [metrics] KUDU-3269: Add UUID and hostname of the server into the metrics output

2021-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17607 ) Change subject: [metrics] KUDU-3269: Add UUID and hostname of the server into the metrics output .. [metrics] KUDU-3269: Add