Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: don't log deleted tables/tablets at startup
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7826/2//COMMIT_MSG
Commit Message:
Alexey Serbin has posted comments on this change.
Change subject: [build-support] fixed IWYU no-op configuration
..
Patch Set 2: Verified+1
unrelated flake in RELEASE configuration
--
To view, visit http://gerrit.cloudera.org
Alexey Serbin has posted comments on this change.
Change subject: java-client: improve error messages when failing to connect to
secure cluster
..
Patch Set 1:
> (5 comments)
>
> looks good, just a few nits
Ah, and another
Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: don't log deleted tables/tablets at startup
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7826/2/src/kudu/maste
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7837
Change subject: [docs] update on automatic authn token reacquisition
..
[docs] update on automatic authn token reacquisition
Updated cor
Alexey Serbin has posted comments on this change.
Change subject: [docs] update on automatic authn token reacquisition
..
Patch Set 1:
> Thanks, could you also add a release note that this has been fixed?
Sure! Should I just
Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: don't log deleted tables/tablets at startup
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7826
To unsubscribe
Alexey Serbin has posted comments on this change.
Change subject: java-client: improve error messages when failing to connect to
secure cluster
..
Patch Set 2:
(3 comments)
Looks good but the new test failed when running by J
Alexey Serbin has posted comments on this change.
Change subject: [docs] update on automatic authn token reacquisition
..
Patch Set 1: Verified+1
Unrelated flake in TestAuthnTokenReacquireOpen:
java.io.IOException: process 'ki
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7840
Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
..
[release-notes] KUDU-2013 is fixed in Kudu 1.5
Change-Id: Ie3098b05747
Alexey Serbin has posted comments on this change.
Change subject: Fix flakiness in ts_recovery-itest
TestCrashBeforeWriteLogSegmentHeader
..
Patch Set 2: Code-Review+2
BTW, do you have any reasonable explanation why this test
Alexey Serbin has posted comments on this change.
Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7840/1/docs/release_notes.adoc
File docs/release_
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
..
[release-notes] KUDU-2013 is fixed in Kudu 1.5
Change-Id: Ie3098b05747bc19b5d1a8f931d171cd4048c8bbf
---
M docs/re
Alexey Serbin has submitted this change and it was merged.
Change subject: [docs] update on automatic authn token reacquisition
..
[docs] update on automatic authn token reacquisition
Updated corresponding section in the docs a
Alexey Serbin has submitted this change and it was merged.
Change subject: [build-support] fixed IWYU no-op configuration
..
[build-support] fixed IWYU no-op configuration
Jenkins is upset if no output is produced by a build: n
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7840
to look at the new patch set (#3).
Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
..
[release-notes
Alexey Serbin has posted comments on this change.
Change subject: [release-notes] KUDU-2013 is fixed in Kudu 1.5
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7840/2/docs/release_notes.adoc
File docs/release_
Alexey Serbin has posted comments on this change.
Change subject: Fix flakiness in ts_recovery-itest
TestCrashBeforeWriteLogSegmentHeader
..
Patch Set 2:
> That's a safe bet :)
>
> I'm don't have a great explanation. I didn
Alexey Serbin has abandoned this change.
Change subject: [rpc] faster generation of KRPC call ID
..
Abandoned
This is not needed: the current implementation seems to be good enough.
--
To view, visit http://gerrit.cloudera.or
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apach
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apach
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apach
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apach
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apach
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1894 fixed deadlock in client.Connection
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7765/2/java/kudu-client/src/main/java/org/apache/k
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apac
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apach
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1894 fixed deadlock in client.Connection
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7765/2/java/kudu-client/src/main/java/org/apache/k
Alexey Serbin has posted comments on this change.
Change subject: [java] Reuse JVM across tests
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7825/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/K
Alexey Serbin has posted comments on this change.
Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests
..
Patch Set 2:
(1 comment)
I think it's a great idea. What about more machine-oriented interface fo
Alexey Serbin has posted comments on this change.
Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG
Commit Message:
P
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7867
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU suggested to include the internal GCC header
: added additio
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU suggested to include the internal GCC header
: added additional mapping file which declares the
header
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7867
to look at the new patch set (#3).
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU sug
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk
File build-support/iwyu/iwyu-filter.aw
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7867/3/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7867
to look at the new patch set (#4).
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU sug
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7867
to look at the new patch set (#5).
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU sug
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp
File build-support/iwyu/mappings
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU suggested to include the internal GCC header
: added additional mapping file which declares
Alexey Serbin has posted comments on this change.
Change subject: consensus_peers: don't log tablet copy attempts that were
throttled
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7868
To uns
Hello Adar Dembo, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7873
to review the following change.
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where I
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on
..
Patch Set 1:
> What's your motivation for this backport?
I expect some amount of updates to be pushed in 1.5.x in the nearest future.
If rea
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on
..
Patch Set 1:
> I'm fine with backporting this, will make it easier to backport
> other changes in the future to this branch.
Thanks!
Yes, th
Alexey Serbin has posted comments on this change.
Change subject: consensus_peers: don't log tablet copy attempts that were
throttled
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7877
To uns
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] fix on
..
[iwyu] fix on
Fixed the issue where IWYU suggested to include the internal GCC header
: added additional mapping file which declares
Alexey Serbin has posted comments on this change.
Change subject: Squelch GCC warning in VerificationResultToString()
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7882
To unsubscribe, visit h
Alexey Serbin has submitted this change and it was merged.
Change subject: Squelch GCC warning in VerificationResultToString()
..
Squelch GCC warning in VerificationResultToString()
This change silences the following GCC warnin
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7887
Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader
..
WIP [raft_consensus-itest] fix flake in TestSlowLeader
Under r
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7887
to look at the new patch set (#2).
Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader
..
WIP [r
Alexey Serbin has posted comments on this change.
Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7887/1/src/kudu/integration-tests/raft_c
Alexey Serbin has posted comments on this change.
Change subject: consensus: Save previous last-logged OpId across tablet copies
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7888/1/src/kudu/integration-test
Alexey Serbin has posted comments on this change.
Change subject: consensus: Save previous last-logged OpId across tablet copies
..
Patch Set 2: Code-Review+2
LGTM
You might want to get more feedback from David, though.
--
T
Alexey Serbin has posted comments on this change.
Change subject: consensus: Save previous last-logged OpId across tablet copies
..
Patch Set 2:
(5 comments)
Added some after-thought nits: they are about making sure my underst
Alexey Serbin has posted comments on this change.
Change subject: docs: add 1.5.0 release note for thread count reduction
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7905/3/docs/release_notes.adoc
File docs
Alexey Serbin has posted comments on this change.
Change subject: docs: add 1.5.0 release note for thread count reduction
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7905/3/docs/release_notes.adoc
File docs
Alexey Serbin has posted comments on this change.
Change subject: tablet copy: Allow voting from failed initial tablet copies
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7904/2//COMMIT_MSG
Commit Message:
Alexey Serbin has posted comments on this change.
Change subject: tablet copy: Allow voting from failed initial tablet copies
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7904/2/src/kudu/integration-tests/ta
Alexey Serbin has posted comments on this change.
Change subject: java-client: improve error messages when failing to connect to
secure cluster
..
Patch Set 4:
(1 comment)
LGTM, just a tiny nit on the line length.
http://ger
Alexey Serbin has posted comments on this change.
Change subject: java-client: improve error messages when failing to connect to
secure cluster
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7
Alexey Serbin has posted comments on this change.
Change subject: java-client: improve error messages when failing to connect to
secure cluster
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7
Alexey Serbin has posted comments on this change.
Change subject: tablet copy: Allow voting from failed initial tablet copies
..
Patch Set 3: Code-Review+2
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7904/2//COMMIT_MSG
Co
Alexey Serbin has posted comments on this change.
Change subject: consensus: Save previous last-logged OpId across tablet copies
..
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7888/2/src/kudu/in
Alexey Serbin has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 2:
(4 comments)
just some nits.
http://gerrit.cloudera.org:8080/#/c/790
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
Fi
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
Fil
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 2:
(2 comments)
Just a couple of other nits; sorry that I missed those in the previou
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7914/3/docs/release
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 5:
(4 comments)
A few other things which might worth mentioning.
http://gerrit.cloud
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 6: Code-Review+2
(1 comment)
LGTM. You might want to get more feedback from Adar and
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7917
To unsubscribe, visit http://gerrit.cloudera.org:808
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt
File CMakeLists.txt:
Line 1118: add_dependencie
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7917/2/README.adoc
File README.adoc:
Line 263: === Running
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7917
To unsubscribe, visit http://gerrit.cloudera.org:808
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7928
Change subject: [doc] add info about the iwyu target
..
[doc] add info about the iwyu target
Added information about the cmake-generated
Alexey Serbin has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7909
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7928/1/README.adoc
File README.adoc:
PS1, Line 267: consi
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7928
to look at the new patch set (#2).
Change subject: [doc] add info about the iwyu target
..
[doc] add info about the
Alexey Serbin has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7927/2/java/gradlew
File j
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7928
to look at the new patch set (#4).
Change subject: [doc] add info about the iwyu target
..
[doc] add in
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 4:
> (2 comments)
>
> Sorry, you will need to manually rebase after I merged my "make
> tidy" patch
That's
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7928/2/README.adoc
File README.adoc:
PS2, Line 264:
> m
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7928
to look at the new patch set (#5).
Change subject: [doc] add info about the iwyu target
..
[doc] add in
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 6:
> Patch Set 5: Verified+1
Thanks.
Yep, it's already known issue with kinit:
java.io.IOException: process
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7932
Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..
[periodic-test] fix flaky PeriodicTimerTest.TestReset
Fixed fla
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7932
to look at the new patch set (#2).
Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..
[period
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7850
to look at the new patch set (#3).
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
KUDU-1976. j
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
Patch Set 3: Verified+1
Unrelated flake in RaftConsensusITest.TestReplicaBehaviorViaRPC and another
flake in
Alexey Serbin has submitted this change and it was merged.
Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..
KUDU-1976. java: use ephemeral ports for MiniKDC
This fixes an issue where Java tests would occasion
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7932
to look at the new patch set (#3).
Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..
[period
Alexey Serbin has posted comments on this change.
Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7932/2/src/kudu/rpc/periodic-test.cc
File
Alexey Serbin has posted comments on this change.
Change subject: Add iwyu note to LICENSE.txt
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.o
Alexey Serbin has posted comments on this change.
Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..
Patch Set 3:
Thank you for the review.
Please see below for the answers.
> Two questions:
> 1. The n
Alexey Serbin has submitted this change and it was merged.
Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..
[periodic-test] fix flaky PeriodicTimerTest.TestReset
Fixed flake in PeriodicTimerTest.TestRese
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7947
Change subject: [tidy] updated the 'tidy' target
..
[tidy] updated the 'tidy' target
Now the 'tidy' target runs against the set of chang
Alexey Serbin has submitted this change and it was merged.
Change subject: [tidy] updated the 'tidy' target
..
[tidy] updated the 'tidy' target
Now the 'tidy' target runs against the set of changelists since the
last committed
Alexey Serbin has posted comments on this change.
Change subject: [tidy] updated the 'tidy' target
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7947/2/build-support/clang_tidy_gerrit.py
File build-support/cl
Alexey Serbin has posted comments on this change.
Change subject: [tidy] updated the 'tidy' target
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7947/2/build-support/clang_tidy_gerrit.py
File build-support/cl
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2130: java client: handle termination during negotiation
edge case
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7960/1/java/kudu-clien
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2130: java client: handle termination during negotiation
edge case
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7960/1/java/kudu-clien
501 - 600 of 15456 matches
Mail list logo
