[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4450 Change subject: Separated Dead and Live tablet server count in master web ui. .. Separated Dead and Live tablet server count in master web ui. Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/1 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Ninad Shringarpure has abandoned this change. Change subject: Separated Dead and Live tablet server count in master web ui. .. Abandoned Missed a test case. -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Ninad Shringarpure has restored this change. Change subject: Separated Dead and Live tablet server count in master web ui. .. Restored Made the required change and comiting the patch. -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: restore Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4455 Change subject: Separated Dead and Live tablet server count in master web ui. .. Separated Dead and Live tablet server count in master web ui. Change-Id: I47a2f402e83a7a16a6c9fa9d90974abe3d865ca3 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/4455/1 -- To view, visit http://gerrit.cloudera.org:8080/4455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I47a2f402e83a7a16a6c9fa9d90974abe3d865ca3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#3). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 27 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/3 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#4). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 27 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/4 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#5). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 27 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/5 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4480 Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc .. [doc] KUDU-1627 Potentially Missing words in the quick start doc Asciidoc was considering as special markup for formatted text and highlighting text in between. Removed the markup to read the text as: If the default projection generated by * does not meet this requirement, the user should avoid using * and explicitly Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c --- M docs/quickstart.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/1 -- To view, visit http://gerrit.cloudera.org:8080/4480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure
[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4480
to look at the new patch set (#2).
Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..
[doc] KUDU-1627 Potentially Missing words in the quick start doc
Asciidoc was considering as special markup for formatted
text and highlighting text in between.
Removed the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly
Change
--
Added formatting as `{asterisk}` as suggested.
Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/2
--
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4483 Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link Missing space before the hyperlink was causing this issue. Please check the resultant html here: https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/1 -- To view, visit http://gerrit.cloudera.org:8080/4483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#2). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link Missing space before the hyperlink was causing this issue. Hyperlinked "Impala documentation" text to appropriate impala link. Complete text being: See the Impala documentation for more information about internal and external tables. Please check the resultant html here: https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 --- M docs/kudu_impala_integration.adoc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/2 -- To view, visit http://gerrit.cloudera.org:8080/4483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4480
to look at the new patch set (#3).
Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..
[doc] KUDU-1627 Potentially Missing words in the quick start doc
Asciidoc was considering * as special markup for formatted
text and highlighting text in between.
Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly
Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/3
--
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#6). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 25 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/6 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#7). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc M src/kudu/tserver/tserver-path-handlers.cc 2 files changed, 66 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/7 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#8). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 24 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/8 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#9). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 23 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/9 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#10). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Attached sampe screenshot: https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 24 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/10 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#3). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link Missing space before the hyperlink was causing this issue. Hyperlinked "Impala documentation" text to appropriate impala link. Complete text being: See the Impala documentation for more information about internal and external tables. Please check the resultant html here: https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 --- M docs/kudu_impala_integration.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/3 -- To view, visit http://gerrit.cloudera.org:8080/4483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#4). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link Missing space before the hyperlink was causing this issue. Hyperlinked "Impala documentation" text to appropriate impala link. Complete text being: See the Impala documentation for more information about internal and external tables. Please check the resultant html here: https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 --- M docs/kudu_impala_integration.adoc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/4 -- To view, visit http://gerrit.cloudera.org:8080/4483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#11). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Attached sampe screenshot: https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 24 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/11 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4450 to look at the new patch set (#12). Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers Creating two lists of tservers live and dead. Created a function to generate html tables taking server list and table header as params. Attached sampe screenshot: https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 --- M src/kudu/master/master-path-handlers.cc 1 file changed, 25 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/12 -- To view, visit http://gerrit.cloudera.org:8080/4450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4526 Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section Created separate vectors for live and tombstone tablets based on their TabletDataState_Name. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 63 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/1 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Ninad Shringarpure has uploaded a new patch set (#2). Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section Created separate vectors for live and tombstone tablets based on their TabletDataState_Name. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 63 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/2 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4526 to look at the new patch set (#3). Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section Created separate vectors for live and tombstone tablets based on their TabletDataState_Name. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 63 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/3 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4526 to look at the new patch set (#4). Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section Created separate vectors for live and tombstone tablets based on their TabletDataState_Name. Table would be displayed only if there are tablets belonging in its respective category. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 59 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/4 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4483 to look at the new patch set (#5). Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link .. [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link Missing space before the hyperlink was causing this issue. Hyperlinked "Impala documentation" text to appropriate impala link. Complete text being: See the Impala documentation for more information about internal and external tables. Please check the resultant html here: https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 --- M docs/kudu_impala_integration.adoc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/5 -- To view, visit http://gerrit.cloudera.org:8080/4483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4526 to look at the new patch set (#5). Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section - Separated tombstoned and live tablet tables in /tablets ui page. - Added one sentence explaining tombstoned tablets as: "Tombstoned tablets are tablets that previously stored a replica on this server." - Tombstoned tablets table is displayed only when they are found. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 62 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/5 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Ninad Shringarpure has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. Patch Set 5: (2 comments) I have also added one line description mentioned in jira for tombstoned tablets. Please check rendered page here: https://github.com/ninadshr/sample_repo/blob/master/tablets_ui.png http://gerrit.cloudera.org:8080/#/c/4526/4//COMMIT_MSG Commit Message: Line 9: - Separated tombstoned and live tablet tables in /tablets ui page. > style nit: consider applying tip about generic git commit guidelines and pr Fixed. Changed commit message to format mentioned in standards. http://gerrit.cloudera.org:8080/#/c/4526/4/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS4, Line 192: const vector Consider passing this by const reference: the code does not modify the cont Fixed. Changed to : const vector>& peers -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4526 to look at the new patch set (#6). Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section - Separated tombstoned and live tablet tables in /tablets ui page. - Added one sentence explaining tombstoned tablets as: "Tombstoned tablets are tablets that previously stored a replica on this server." - Tombstoned tablets table is displayed only when they are found. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 63 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/6 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Ninad Shringarpure has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4526/6/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS6, Line 191: this > Why is 'this' capture necessary for this functor? This lambda function is accessing ConsensusStatePBToHtml method. Not the right way to do it? -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4526 to look at the new patch set (#7). Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section - Separated tombstoned and live tablet tables in /tablets ui page. - Added one sentence explaining tombstoned tablets as: "Tombstoned tablets are tablets that previously stored a replica on this server." - Tombstoned tablets table is displayed only when they are found. Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 --- M src/kudu/tserver/tserver-path-handlers.cc 1 file changed, 64 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/7 -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section
Ninad Shringarpure has posted comments on this change.
Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned
tablets to a separate section
..
Patch Set 6:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4526/6/src/kudu/tserver/tserver-path-handlers.cc
File src/kudu/tserver/tserver-path-handlers.cc:
Line 219: // TODO: would be nice to include some other stuff like memory
usage
> Nit: please fix Tidy Bot's warning as well. You can take a look at the nex
Fixed
PS6, Line 238:
> Nit: an extra space; clang compiler is smart enough not to take it as '>>'
Fixed
PS6, Line 239:
> ditto
Fixed
Line 249: generate_table("Live Tablets",live_peers, output);
> Nit: a space is missing.
Fixed
Line 252: *output << "Tombstoned tablets are tablets that
previously "
> Why not to put that after the table? If this precedes the table, then this
Fixed
Line 254: generate_table("Tombstoned Tablets",tombstoned_peers, output);
> Nit: a space is missing.
Fixed
--
To view, visit http://gerrit.cloudera.org:8080/4526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ninad Shringarpure
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] [doc] KUDU-1810 Missing part of text in kudu impala create table doc section
Ninad Shringarpure has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5639
Change subject: [doc] KUDU-1810 Missing part of text in
kudu_impala_create_table doc section
..
[doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section
Asciidoc was considering * as special markup for formatted
text and highlighting text in between.
Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly
Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/5639/1
--
To view, visit http://gerrit.cloudera.org:8080/5639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure
[kudu-CR] [doc] KUDU-1810 Missing part of text in kudu impala create table doc section
Ninad Shringarpure has uploaded a new patch set (#2).
Change subject: [doc] KUDU-1810 Missing part of text in
kudu_impala_create_table doc section
..
[doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section
Asciidoc was considering * as special markup for formatted
text and highlighting text in between.
Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly
Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
---
M docs/kudu_impala_integration.adoc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/5639/2
--
To view, visit http://gerrit.cloudera.org:8080/5639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure
Gerrit-Reviewer: Kudu Jenkins
