Ninad Shringarpure has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section ......................................................................
Patch Set 5: (2 comments) I have also added one line description mentioned in jira for tombstoned tablets. Please check rendered page here: https://github.com/ninadshr/sample_repo/blob/master/tablets_ui.png http://gerrit.cloudera.org:8080/#/c/4526/4//COMMIT_MSG Commit Message: Line 9: - Separated tombstoned and live tablet tables in /tablets ui page. > style nit: consider applying tip about generic git commit guidelines and pr Fixed. Changed commit message to format mentioned in standards. http://gerrit.cloudera.org:8080/#/c/4526/4/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS4, Line 192: const vector<scoped_refptr<TabletPe > Consider passing this by const reference: the code does not modify the cont Fixed. Changed to : const vector<scoped_refptr<TabletPeer>>& peers -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
