Ninad Shringarpure has posted comments on this change.

Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned 
tablets to a separate section
......................................................................


Patch Set 6:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4526/6/src/kudu/tserver/tserver-path-handlers.cc
File src/kudu/tserver/tserver-path-handlers.cc:

Line 219:       // TODO: would be nice to include some other stuff like memory 
usage
> Nit: please fix Tidy Bot's warning as well.  You can take a look at the nex
Fixed


PS6, Line 238:  
> Nit: an extra space; clang compiler is smart enough not to take it as '>>' 
Fixed


PS6, Line 239:  
> ditto
Fixed


Line 249:     generate_table("Live Tablets",live_peers, output);
> Nit: a space is missing.
Fixed


Line 252:     *output << "<p><small>Tombstoned tablets are tablets that 
previously "
> Why not to put that after the table?  If this precedes the table, then this
Fixed


Line 254:     generate_table("Tombstoned Tablets",tombstoned_peers, output);
> Nit: a space is missing.
Fixed


-- 
To view, visit http://gerrit.cloudera.org:8080/4526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to