[kudu-CR] [client] add DISALLOW COPY AND ASSIGN() for a few classes

2022-05-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18511 ) Change subject: [client] add DISALLOW_COPY_AND_ASSIGN() for a few classes .. Patch Set 1: Code-Review+1 Looks good. I check all

[kudu-CR] [client] prohibit copying/assigning of ResourceMetrics

2022-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18510 ) Change subject: [client] prohibit copying/assigning of ResourceMetrics .. Patch Set 1: Code-Review+1 Thank you for fixing this issue!

[kudu-CR] [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API

2022-05-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18489 ) Change subject: [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API .. Patch Set 2: (7 comments)

[kudu-CR] [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API

2022-05-05 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18489 to look at the new patch set (#2). Change subject: [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API

[kudu-CR] [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API

2022-05-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18489 ) Change subject: [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API .. Patch Set 1: Hi Alex, this is the follow up patch

[kudu-CR] [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API

2022-05-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18489 Change subject: [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API .. [client] KUDU-3365: Expose INSERT/UPDATE metrics in

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 11: Thank you for the review, Alexey! >

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-29 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#10). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 9: (2 comments)

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-29 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#9). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 8: (1 comment) Patch set 8 fix the IWYU

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-29 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#8). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-28 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#7). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 6: (2 comments)

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-28 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#6). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 5: (15 comments)

[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

2022-04-28 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#5). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB .. Patch Set 4: (1 comment)

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB .. Patch Set 4: (5 comments) Patch set 4 change the

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#4). Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB .. Patch Set 3: (1 comment)

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB .. Patch Set 3: (9 comments)

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#3). Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-27 Thread Riza Suminto (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#2). Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

[kudu-CR] [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

2022-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18451 Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB .. [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB

[kudu-CR] [rpc] Expose KRPC call id to client application

2021-09-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17866 ) Change subject: [rpc] Expose KRPC call_id to client application .. Patch Set 3: (12 comments) Thank you for the feedback!

[kudu-CR] [rpc] Expose KRPC call id to client application

2021-09-23 Thread Riza Suminto (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17866 to look at the new patch set (#3). Change subject: [rpc] Expose KRPC call_id to client application

[kudu-CR] [rpc] Expose KRPC call id to client application

2021-09-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17866 ) Change subject: [rpc] Expose KRPC call_id to client application .. Patch Set 2: > Patch Set 2: Verified-1 > > Build Failed > >

[kudu-CR] [rpc] Expose KRPC call id to client application

2021-09-23 Thread Riza Suminto (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17866 to look at the new patch set (#2). Change subject: [rpc] Expose KRPC call_id to client application

[kudu-CR] [rpc] Expose KRPC call id to client application

2021-09-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17866 ) Change subject: [rpc] Expose KRPC call_id to client application .. Patch Set 1: (1 comment)

[kudu-CR] [rpc] Expose KRPC call id to client application

2021-09-23 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17866 Change subject: [rpc] Expose KRPC call_id to client application .. [rpc] Expose KRPC call_id to client application KRPC assign call_id