[kudu-CR] [webui] Make tombstone tablet info less confusing
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. [webui] Make tombstone tablet info less confusing Previously, when a tombstone tablet was reloaded at server startup, the last status message was "Tablet initializing...". This was confusing as it set the expectation that something more was going to happen to the tombstoned tablet. The message is now simply "Tombstoned". Also, now that tombstoned tablets can vote, they retain cmeta despite not participating in non-election Raft operations. Their list of peers is not updated and not usually relevant. It might be confusing to see it on the web ui. This patch suppresses it. Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Reviewed-on: http://gerrit.cloudera.org:8080/8981 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon--- M src/kudu/tablet/tablet_replica.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver_path_handlers.cc 4 files changed, 56 insertions(+), 6 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] Make tombstone tablet info less confusing
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 3 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 11 Jan 2018 01:40:26 + Gerrit-HasComments: No
[kudu-CR] [webui] Make tombstone tablet info less confusing
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8981 to look at the new patch set (#3). Change subject: [webui] Make tombstone tablet info less confusing .. [webui] Make tombstone tablet info less confusing Previously, when a tombstone tablet was reloaded at server startup, the last status message was "Tablet initializing...". This was confusing as it set the expectation that something more was going to happen to the tombstoned tablet. The message is now simply "Tombstoned". Also, now that tombstoned tablets can vote, they retain cmeta despite not participating in non-election Raft operations. Their list of peers is not updated and not usually relevant. It might be confusing to see it on the web ui. This patch suppresses it. Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb --- M src/kudu/tablet/tablet_replica.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver_path_handlers.cc 4 files changed, 56 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/8981/3 -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 3 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] Make tombstone tablet info less confusing
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@211 PS2, Line 211: return replica->HumanReadableState().find("TABLET_DATA_TOMBSTONED") != string::npos; > hrm, we can't get at this in a less stringy way? Done http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@327 PS2, Line 327: Do not delete them > think it would be nice to say something like "The tombstone markers are nec Done -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 2 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 10 Jan 2018 20:33:18 + Gerrit-HasComments: Yes
[kudu-CR] [webui] Make tombstone tablet info less confusing
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@211 PS2, Line 211: return replica->HumanReadableState().find("TABLET_DATA_TOMBSTONED") != string::npos; hrm, we can't get at this in a less stringy way? http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@327 PS2, Line 327: Do not delete them think it would be nice to say something like "The tombstone markers are necessary for correct operation of Kudu. These tablets have had all of their data removed from disk and do not consume significant resources, and must not be deleted." -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 2 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 10 Jan 2018 01:55:42 + Gerrit-HasComments: Yes
[kudu-CR] [webui] Make tombstone tablet info less confusing
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 1: > > Build Failed > > Alexey is fixing the last few tests now that 3-4-3 is on. I'll wait > until that's done then kick off a new set of tests. Fixed as of 8bcc80eec075321faef26b2a0ccac12ac9d7 -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 1 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 10 Jan 2018 00:32:11 + Gerrit-HasComments: No
[kudu-CR] [webui] Make tombstone tablet info less confusing
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 1: > Build Failed Alexey is fixing the last few tests now that 3-4-3 is on. I'll wait until that's done then kick off a new set of tests. -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 1 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 09 Jan 2018 22:29:11 + Gerrit-HasComments: No
[kudu-CR] [webui] Make tombstone tablet info less confusing
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8981 Change subject: [webui] Make tombstone tablet info less confusing .. [webui] Make tombstone tablet info less confusing Previously, when a tombstone tablet was reloaded at server startup, the last status message was "Tablet initializing...". This was confusing as it set the expectation that something more was going to happen to the tombstoned tablet. The message is now simply "Tombstoned". Also, now that tombstoned tablets can vote, they retain cmeta despite not participating in non-election Raft operations. Their list of peers is not updated and not usually relevant. It might be confusing to see it on the web ui. This patch suppresses it. Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver_path_handlers.cc 3 files changed, 48 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/8981/1 -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley