[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Avoid a few allocations while reading PBC files .. Avoid a few allocations while reading PBC files This reduces extra short-lived allocations while

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: Verified+1 Some python flake -- To view, visit http://gerrit.cloudera.org:8080/8009 To

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8009 to look at the new patch set (#2). Change subject: Avoid a few allocations while reading PBC files .. Avoid a few

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: yea, WebRTC (chromium ish) has ArrayView which is pretty nice for this kinda thing as well. Maybe

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: gsl::span : std::vector as Slice (or gsl::string_span) : std::string -- To view, visit

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: I don't want to block merging this, but we might want to think about this is a bigger context.

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8009 to review the following change. Change subject: Avoid a few allocations while reading PBC files .. Avoid