Todd Lipcon has submitted this change and it was merged.
Change subject: Avoid a few allocations while reading PBC files
..
Avoid a few allocations while reading PBC files
This reduces extra short-lived allocations while
Todd Lipcon has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc
File
Adar Dembo has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc
File
Todd Lipcon has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc
File
Todd Lipcon has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc
File
Adar Dembo has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc
File
Todd Lipcon has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 5: Verified+1
Some python flake
--
To view, visit http://gerrit.cloudera.org:8080/8009
To
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8009
to look at the new patch set (#2).
Change subject: Avoid a few allocations while reading PBC files
..
Avoid a few
Todd Lipcon has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
yea, WebRTC (chromium ish) has ArrayView which is pretty nice for this kinda
thing as well. Maybe
Dan Burkert has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
gsl::span : std::vector
as
Slice (or gsl::string_span) : std::string
--
To view, visit
Dan Burkert has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
I don't want to block merging this, but we might want to think about this is a
bigger context.
Adar Dembo has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc
File
Adar Dembo has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc
File
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8009
to review the following change.
Change subject: Avoid a few allocations while reading PBC files
..
Avoid
14 matches
Mail list logo