[kudu-CR] Combine redaction flag for log and flags into one.

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit htt

[kudu-CR] Combine redaction flag for log and flags into one.

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Combine redaction flag for log and flags into one. .. Combine redaction flag for log and flags into one. This adds a new flag --redact to replace --redact

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit http

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-28 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#15). Change subject: Combine redaction flag for log and flags into one. .

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit http

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#12). Change subject: Combine redaction flag for log and flags into one. .

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/11/src/kudu/util/flags.cc File src/kudu/util/

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/11/src/kudu/util/flags.cc File src/kudu/ut

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: Code-Review+2 Looks good to me, maybe see if Todd wants to rereview? -- To view, visit http://

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File src/kudu/util/

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#11). Change subject: Combine redaction flag for log and flags into one. .. Combine r

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File src/kudu/ut

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File src/kudu/util/

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File src/kudu/ut

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#10). Change subject: Combine redaction flag for log and flags into one. .. Combine r

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6112/9/src/kudu/util/flags.cc File src/kudu/util/f

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6112/9/src/kudu/util/flags.cc File src/kudu/uti

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#9). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/common/column_predicate-test.cc Fi

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/common/column_predicate-test.cc

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/6112/7/src/kudu/util/flags.cc File src/kudu/util/

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-26 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#8). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/6112/7/src/kudu/util/flags.cc File src/kudu/uti

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-23 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#7). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-23 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#6). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-23 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#5). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-23 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#4). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/6112/3/src/kudu/util/flags.cc File src/kudu/util/f

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6112/3/src/kudu/util/flags.cc File src/kudu/ut

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 3: Would be nice to use a case-insensitive comparison (boost::iequals). Would be nice to provide

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6112/3/src/kudu/util/flags.cc File src/kudu/uti

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-22 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#3). Change subject: Combine redaction flag for log and flags into one. .. Combine re

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-22 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new patch set (#2). Change subject: Combine redaction flag for log and flags into one. .. Combine redaction flag for log and flags into one. This adds a new flag --redact to replace --redact_sensitive_flag

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-22 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6112 Change subject: Combine redaction flag for log and flags into one. .. Combine redaction flag for log and flags into one. This adds a new flag