[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6433 To u

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-21 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6433 to look at the new patch set (#3). Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6433/2/src/kudu/cfile/binary_dic

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6433/2/src/kudu/cfile/binary_dict

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6433/2/src/kudu/cfile/bi

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: Code-Review+1 Thirdparty change looks good. I also reviewed the dictionary encoding

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6433 to look at the new patch set (#2). Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6433 to review the following change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .