[kudu-CR] Predicate evaluation pushdown

2016-09-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: Predicate evaluation pushdown .. Abandoned This is an old version of a patch that got committed later from a different gerrit. -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown The premise of this patch is to avoid the excessive use of CPU when evaluating column predi

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Andrew Wong (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#16). Change subject: Predicate evaluation pushdown .. Predicate evaluat

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/3280/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/3276/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/3275/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/3273/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#13). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 12: (18 comments) http://gerrit.cloudera.org:8080/#/c/3990/12/src/kudu/cfile/binary_dict_block.cc File src/kudu/cfile/b

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 12: (18 comments) mostly just some remaining nits, though I think I spotted one real bug too. http://gerrit.cloudera.o

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/3250/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#12). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/3247/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#11). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/3990/10/src/kudu/cfile/cfile-test-base.h File src/kudu/cfile/cfile

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/3990/10/src/kudu/cfile/cfile-test-base.h File src/kudu/cfile/cfile

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/3235/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#10). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#9). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3225/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3222/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-09-02 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#8). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_plain_block.h File src/kudu/cfile/binar

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/3990/7/src/kudu/cfile/binary_prefix_block.h File src/kudu/cfile/bi

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (97 comments) http://gerrit.cloudera.org:8080/#/c/3990/3//COMMIT_MSG Commit Message: Line 16: https://github.com/a

[kudu-CR] Predicate evaluation pushdown

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (31 comments) http://gerrit.cloudera.org:8080/#/c/3990/7/src/kudu/cfile/binary_plain_block.cc File src/kudu/cfile/bi

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3095/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#7). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 6: (13 comments) http://gerrit.cloudera.org:8080/#/c/3990/6/src/kudu/common/column_eval_context.h File src/kudu/common/

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3076/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#6). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3074/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#5). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/3990/4/src/kudu/tablet/deltamemstore.cc File src/kudu/tablet/delt

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 4: (39 comments) did a first pass of comments. i think splitting out the optimization on predicate evaluation to avoid

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 3: (22 comments) First pass -- I just saw a new version has appeared. Will continue with the new version. http://g

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#4). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3017/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#3). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3013/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 2: (15 comments) Overall I had a few style nits that were repeated throughout the patch: * Put the pointer * and refer

[kudu-CR] Predicate evaluation pushdown

2016-08-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#2). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-16 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2954/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-15 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3990 Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown The premise of this patch is to avoid the excessive use of

[kudu-CR] Predicate evaluation pushdown

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2915/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3841/1/src/kudu/cfile/binary_dict_block.cc File src/kudu/cfile/binar

[kudu-CR] Predicate evaluation pushdown

2016-08-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3841 Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown This patch is a work in progress. The premise of this patc

[kudu-CR] Predicate evaluation pushdown

2016-08-04 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2712/ -- To view, visit http://gerrit.cloudera.org:8080/3841 T