[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Timestamp::FromUint64 should return void .. Timestamp::FromUint64 should return void It does no validation, can't fail, and has the same signature as one o

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3943 To unsubscribe, visit http://gerrit.

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File src/kudu/common/ti

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File src/kudu/common/t

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2813/ -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3943 to review the following change. Change subject: Timestamp::FromUint64 should return void .. Timestamp::FromUint64 shou