[kudu-CR] Tweak ListMasters RPC error handling

2017-04-21 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Tweak ListMasters RPC error handling .. Tweak ListMasters RPC error handling Unlike other master-specific RPCs, the ListMasters response contains an

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6704 To unsubscribe, visit

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 2: We discussed testing offline and decided to punt. A follow-up patch will be testing the success case. --

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 2: Maybe add a small unit test in master-test? -- To view, visit http://gerrit.cloudera.org:8080/6704 To

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6704/1/src/kudu/master/master_service.cc File

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6704 to review the following change. Change subject: Tweak ListMasters RPC error handling .. Tweak ListMasters RPC error