[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. tool: port kudu-admin to 'kudu table' and 'kudu tablet' The config change operations go to the revived 'tablet' mode, which is now "operations against remote Kudu tablets". The table operations go to 'kudu table'. In doing so, the ported functionality can now also work in multi-master mode; previously, the ClusterAdminClient refused to accept multiple masters. I opted to group the config change operations as a common mode rather than an additional parameter. I think this makes them more discoverable. Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Reviewed-on: http://gerrit.cloudera.org:8080/4180 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M build-support/dist_test.py M docs/release_notes.adoc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-admin-test.cc D src/kudu/tools/kudu-admin.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/kudu-ts-cli-test.cc M src/kudu/tools/tool_action.h M src/kudu/tools/tool_action_cluster.cc M src/kudu/tools/tool_action_local_replica.cc A src/kudu/tools/tool_action_table.cc A src/kudu/tools/tool_action_tablet.cc M src/kudu/tools/tool_main.cc 13 files changed, 458 insertions(+), 484 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3331/ -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Adar Dembo has posted comments on this change.
Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet'
..
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4180/6/build-support/dist_test.py
File build-support/dist_test.py:
PS6, Line 80: these.
> this
Done
http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
Line 240: "peers", "List of peers where each peer is of form
'uuid:hostname:port'" })
> at this point, user may want to know where can he grab this uuid from ? th
For the master migration workflow, the user can get it from 'kudu fs dump uuid'.
http://gerrit.cloudera.org:8080/#/c/4180/6/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
Line 101: return ModeBuilder("table")
> Come to think of it, I guess these are nothing but operations on the cluste
Todd (and Dan, I think) requested less nesting of modes where possible. That's
ultimately why I made 'table' a top-level mode instead of nesting it under
'cluster'.
http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
Line 185: .Description("Add a new replica to a tablet's Raft
configuration")
> I am not sure if we want to stay away from using 'Raft config' here, we cou
I don't think it matters in this context, as this is an advanced command that
very few admins are expected to use.
--
To view, visit http://gerrit.cloudera.org:8080/4180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dinesh Bhat
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Hello Dinesh Bhat, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4180 to look at the new patch set (#7). Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. tool: port kudu-admin to 'kudu table' and 'kudu tablet' The config change operations go to the revived 'tablet' mode, which is now "operations against remote Kudu tablets". The table operations go to 'kudu table'. In doing so, the ported functionality can now also work in multi-master mode; previously, the ClusterAdminClient refused to accept multiple masters. I opted to group the config change operations as a common mode rather than an additional parameter. I think this makes them more discoverable. Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 --- M build-support/dist_test.py M docs/release_notes.adoc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-admin-test.cc D src/kudu/tools/kudu-admin.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/kudu-ts-cli-test.cc M src/kudu/tools/tool_action.h M src/kudu/tools/tool_action_cluster.cc M src/kudu/tools/tool_action_local_replica.cc A src/kudu/tools/tool_action_table.cc A src/kudu/tools/tool_action_tablet.cc M src/kudu/tools/tool_main.cc 13 files changed, 458 insertions(+), 484 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4180/7 -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Dinesh Bhat has posted comments on this change.
Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet'
..
Patch Set 6: Code-Review+1
(3 comments)
LGTM, few nits and Qs as usual from my side.
http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
Line 240: "peers", "List of peers where each peer is of form
'uuid:hostname:port'" })
at this point, user may want to know where can he grab this uuid from ? this
was the reason i retained 'list_tablets' kinda functionality from fs_list
because it means user doesn't have to rely on any other output outside
/bin/kudu. well in this case, i think he can grab this uuid from kudu ksck ?
http://gerrit.cloudera.org:8080/#/c/4180/6/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
Line 101: return ModeBuilder("table")
Come to think of it, I guess these are nothing but operations on the
cluster(although table may not span an entire cluster), but I was thinking if
it makes sense to keep less number of Modes under bin/kudu and more subModes
under cluster. Just some thoughts, we can do this for post 1.0 if we have
second thoughts later.
http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
Line 185: .Description("Add a new replica to a tablet's Raft
configuration")
I am not sure if we want to stay away from using 'Raft config' here, we could
just stick to 'add a new replica to tablet'. Nothing wrong in it, but just
feels like internal detail.
--
To view, visit http://gerrit.cloudera.org:8080/4180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dinesh Bhat
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 6: (1 comment) looks good, 1 nit http://gerrit.cloudera.org:8080/#/c/4180/6/build-support/dist_test.py File build-support/dist_test.py: PS6, Line 80: these. this -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3327/ -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 5: Verified+1 Overriding Jenkins, spurious TSAN failure in debug-util-test (which Todd has fixed). -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3317/ -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'
Hello Dinesh Bhat, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4180 to look at the new patch set (#5). Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. tool: port kudu-admin to 'kudu table' and 'kudu tablet' The config change operations go to the revived 'tablet' mode, which is now "operations against remote Kudu tablets". The table operations go to 'kudu table'. In doing so, the ported functionality can now also work in multi-master mode; previously, the ClusterAdminClient refused to accept multiple masters. I opted to group the config change operations as a common mode rather than an additional parameter. I think this makes them more discoverable. Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 --- M build-support/dist_test.py M docs/release_notes.adoc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-admin-test.cc D src/kudu/tools/kudu-admin.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/kudu-ts-cli-test.cc M src/kudu/tools/tool_action.h M src/kudu/tools/tool_action_cluster.cc M src/kudu/tools/tool_action_local_replica.cc A src/kudu/tools/tool_action_table.cc A src/kudu/tools/tool_action_tablet.cc M src/kudu/tools/tool_main.cc 13 files changed, 457 insertions(+), 483 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4180/5 -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
