[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: rewrite parser logic .. tool: rewrite parser logic While leaf and non-leaf actions share some common properties, there is much they don't share. Rat

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3996 To unsubscribe, visit http://gerrit.cloudera.org:8

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: > looks good but the patch it's based on seems to have exploded. Yeah, I rebased to switch the order around. And I thoug

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2942/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To u

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3996 To unsubscribe, visit http://gerrit.cloudera.org:8

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: looks good but the patch it's based on seems to have exploded. -- To view, visit http://gerrit.cloudera.org:8080/3996

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3996 to look at the new patch set (#2). Change subject: tool: rewrite parser logic .. tool: rewrite parser

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2936/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To u

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3996/1/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h:

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3996/1/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h:

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2933/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To u

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/3996 Change subject: tool: rewrite parser logic .. tool: rewrite parser logic While leaf and non-leaf actions share some common properties, ther