[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: Code-Review+2 Ran the tests in my mac. When running on ctest all tests that injected

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: > Thanks for making those changes. Looks good to me, though > ultimately I'll defer to someone

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: Code-Review+1 Thanks for making those changes. Looks good to me, though ultimately I'll defer to

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3360 to look at the new patch set (#2). Change subject: Do not run (g)addr2line translator on MacOS X .. Do

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: (2 comments) > (2 comments) > > My understanding is that sanitizer-enabled Kudu builds on Mac

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: (2 comments) My understanding is that sanitizer-enabled Kudu builds on Mac OS will report correct

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: Code-Review+1 lgtm but Dan should take a look too, since he develops on a Mac -- To view, visit

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1806/ -- To view, visit

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3360 Change subject: Do not run (g)addr2line translator on MacOS X .. Do not run (g)addr2line translator on MacOS X When running tests on