[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3569 to look at the new patch set (#6). Change subject: Add a way to dump ResultTracker state .. Add a way to dump

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2290/ -- To view, visit

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 9: Verified+1 unrelated flake -- To view, visit

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3569 to look at the new patch set (#5). Change subject: Add a way to dump ResultTracker state .. Add a way to dump

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2288/ -- To view, visit

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2287/ -- To view, visit

[kudu-CR] Integrate the result tracker with writes

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 19: Build Started http://104.196.14.100/job/kudu-gerrit/2286/ -- To view, visit

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 5: Verified+1 unrelated java failure -- To view, visit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 22: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3190 To

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 22: unrelated failure of LinkedListTest.TestLoadAndVerify -- To view, visit

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2280/ --

[kudu-CR] Add a fault injection point after the leader sends a request

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a fault injection point _after_ the leader sends a request .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2283/ -- To view, visit

[kudu-CR] Add integration tests for replay cache with writes

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 24: Build Started http://104.196.14.100/job/kudu-gerrit/2284/ -- To view, visit

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Add a way to dump ResultTracker state .. Add a way to dump ResultTracker state This adds a way to dump result tracker state and makes sure we use it when

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#22). Change subject: Add a ResultTracker class that will track server side results

[kudu-CR] Add a ToString() method to Proxy

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2279/ -- To view, visit

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 22: Build Started http://104.196.14.100/job/kudu-gerrit/2275/ -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2273/ -- To view, visit

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2274/ -- To view, visit

[kudu-CR] c++ client: various fixes to DDL operations

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3608 to review the following change. Change subject: c++ client: various fixes to DDL operations

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2272/ -- To view, visit

[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3607 to review the following change. Change subject: master: fix corruption when AlterTable() races with CreateTable()

[kudu-CR] c++ client: various fixes to DDL operations

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: c++ client: various fixes to DDL operations .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2269/ -- To view, visit

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2271/ -- To view, visit

[kudu-CR] rw mutex: add configurable priority

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: rw_mutex: add configurable priority .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2264/ -- To view, visit

[kudu-CR] master-test: rewrite to use std::thread instead of kudu::Thread

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master-test: rewrite to use std::thread instead of kudu::Thread .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2263/ -- To view, visit

[kudu-CR] master: fix initialization race with consensus RPCs

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3605 to review the following change. Change subject: master: fix initialization race with consensus RPCs

[kudu-CR] master: add read-write lock to serialize operations around elections

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2262/ -- To view,

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3609 to review the following change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower

[kudu-CR] master: add read-write lock to serialize operations around elections

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3550 to look at the new patch set (#4). Change subject: master: add read-write lock to serialize operations around elections

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3611 to review the following change. Change subject: KUDU-1358 (part 3): new multi-master stress test

[kudu-CR] master: reduce timeout for master to tserver rpcs

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: reduce timeout for master to tserver rpcs .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2267/ -- To view, visit

[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2268/ -- To view, visit

[kudu-CR] rw mutex: add try lock methods

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: rw_mutex: add try lock methods .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2265/ -- To view, visit http://gerrit.cloudera.org:8080/3604

[kudu-CR] rw mutex: add configurable priority

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3603 to review the following change. Change subject: rw_mutex: add configurable priority

[kudu-CR] master: reduce timeout for master to tserver rpcs

2016-07-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3606 to review the following change. Change subject: master: reduce timeout for master to tserver rpcs

[kudu-CR] master: add read-write lock to serialize operations around elections

2016-07-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 3: (8 comments)

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2261/ -- To view, visit

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3501 to look at the new patch set (#6). Change subject: KUDU-763 consensus queue metrics on followers are messed up ..

[kudu-CR] WIP [java client] Redo how we manage exceptions

2016-07-08 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#4). Change subject: WIP [java client] Redo how we manage exceptions .. WIP [java

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/3569/2/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#21). Change subject: Add a ResultTracker class that will track server side results

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 19: Build Started http://104.196.14.100/job/kudu-gerrit/2256/ -- To view, visit

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2258/ -- To view, visit

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3503 to look at the new patch set (#4). Change subject: Add information about Exactly Once RPC semantics to rpc.md ..

[kudu-CR] Add a ToString() method to Proxy

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2259/ -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 20: Build Started http://104.196.14.100/job/kudu-gerrit/2253/ -- To view, visit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2257/ -- To view, visit

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2255/ -- To view, visit

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2254/ -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#19). Change subject: Integrate the request tracker with the client .. Integrate the

[kudu-CR] Integrate the request tracker with the client

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 19: Build Started http://104.196.14.100/job/kudu-gerrit/2252/ -- To view, visit

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3593/7/src/kudu/gutil/map-util.h File

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 9: (4 comments)

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Abandoned -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#18). Change subject: Integrate the request tracker with the client .. Integrate the

[kudu-CR] Integrate the request tracker with the client

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/2250/ -- To view, visit

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

2016-07-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3595/3/src/kudu/gutil/map-util.h File

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 3: Code-Review+1 just a rebase, keeping alexey's +1 -- To view, visit

[kudu-CR] Add a ToString() method to Proxy

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3502/1/src/kudu/rpc/proxy.cc File src/kudu/rpc/proxy.cc:

[kudu-CR] Add a ToString() method to Proxy

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2249/ -- To view, visit

[kudu-CR] Add a FindPointeeOrNull method to map-util

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a FindPointeeOrNull method to map-util .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2245/ -- To view, visit

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2244/ -- To view, visit

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2243/ -- To view, visit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 20: Build Started http://104.196.14.100/job/kudu-gerrit/2248/ -- To view, visit

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2246/ -- To view, visit

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/2247/ -- To view, visit

[kudu-CR] Add a FindPointeeOrNull method to map-util

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3594 to look at the new patch set (#3). Change subject: Add a FindPointeeOrNull method to map-util .. Add a

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#20). Change subject: Add a ResultTracker class that will track server side results

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3504 to look at the new patch set (#5). Change subject: Make RequestTracker not return Status on FirstIncomplete() ..

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3593 to look at the new patch set (#7). Change subject: Add ComputeIfAbsent methods to map-util .. Add

[kudu-CR] Add a FindPointeeOrNull method to map-util

2016-07-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add a FindPointeeOrNull method to map-util .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3594/2/src/kudu/gutil/map-util.h File

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/3593/5/src/kudu/gutil/map-util.h File

[kudu-CR] Add a ToString() method to Proxy

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2242/ -- To view, visit

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2239/ -- To view, visit

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3595 to look at the new patch set (#2). Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Add a

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

2016-07-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 3: (3 comments) I'm rejiggering the patches but I don't think we need to merge

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

2016-07-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3595/1/src/kudu/gutil/map-util.h File

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#16). Change subject: Add a RpcContext::RespondFailure() method .. Add a

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2238/ -- To view, visit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-07-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/2236/ -- To view, visit

[kudu-CR] Add a ToString() method to Proxy

2016-07-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3502 to look at the new patch set (#4). Change subject: Add a ToString() method to Proxy .. Add a ToString() method to

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3593/5/src/kudu/gutil/map-util.h File