[kudu-CR](gh-pages) Replace bootstrap with CDN version
Hello Misty Stanley-Jones, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3649 to review the following change. Change subject: Replace bootstrap with CDN version .. Replace bootstrap with CDN version This has significant performance benefits. Also, remove our hosted bootstrap files. We don't need them. Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 --- M _includes/bottom_common.html M _includes/top_common.html D css/bootstrap-responsive.css D css/bootstrap-responsive.min.css D css/bootstrap-theme.css D css/bootstrap-theme.css.map D css/bootstrap-theme.min.css D css/bootstrap.css D css/bootstrap.css.map D css/bootstrap.min.css D js/bootstrap.js D js/bootstrap.min.js 12 files changed, 6 insertions(+), 10,182 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3649/1 -- To view, visit http://gerrit.cloudera.org:8080/3649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](gh-pages) Replace bootstrap with CDN version
Mike Percy has posted comments on this change. Change subject: Replace bootstrap with CDN version .. Patch Set 1: Rendered HTML: http://mpercy.github.io/kudu/ -- To view, visit http://gerrit.cloudera.org:8080/3649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] docs: Fix broken link to Introduction in navbar
Kudu Jenkins has posted comments on this change. Change subject: docs: Fix broken link to Introduction in navbar .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2430/ -- To view, visit http://gerrit.cloudera.org:8080/3650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] docs: Fix broken link to Introduction in navbar
Hello Misty Stanley-Jones, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3650 to review the following change. Change subject: docs: Fix broken link to Introduction in navbar .. docs: Fix broken link to Introduction in navbar We moved introduction.adoc to index.adoc, but the navigation bar still points to introduction.html Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da --- M docs/support/jekyll-templates/document.html.erb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/3650/1 -- To view, visit http://gerrit.cloudera.org:8080/3650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR] docs: Fix broken link to Introduction in navbar
Mike Percy has posted comments on this change. Change subject: docs: Fix broken link to Introduction in navbar .. Patch Set 1: Verified+1 Not sure why TSAN barfed but this is a docs-only fix -- To view, visit http://gerrit.cloudera.org:8080/3650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] Make dist test.py work on a symlinked work directory
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3551 to look at the new patch set (#2). Change subject: Make dist_test.py work on a symlinked work directory .. Make dist_test.py work on a symlinked work directory Previously, if run inside a directory that was partially composed of symlinks, dist_test.py would not correctly collect and modify the RPATHs of thirdparty libraries. It would put everything in LD_LIBRARY_PATH. This could result in errors that looked like the following when trying to symbolize stack traces under TSAN: /tmp/run_tha_testQiFa2H/thirdparty/installed/bin/llvm-symbolizer: symbol lookup error: /tmp/run_tha_testQiFa2H/build/dist-test-system-libs/libstdc++.so.6: undefined symbol: __tsan_init With these changes, symbolization works. run_dist_test.py just has a cosmetic change to rename a variable for clarity. No functional changes. Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9 --- M build-support/dist_test.py M build-support/run_dist_test.py 2 files changed, 38 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/3551/2 -- To view, visit http://gerrit.cloudera.org:8080/3551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Make dist test.py work on a symlinked work directory
Kudu Jenkins has posted comments on this change. Change subject: Make dist_test.py work on a symlinked work directory .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2431/ -- To view, visit http://gerrit.cloudera.org:8080/3551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: Fix broken link to Introduction in navbar
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: Fix broken link to Introduction in navbar .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR](gh-pages) Replace bootstrap with CDN version
Jean-Daniel Cryans has posted comments on this change. Change subject: Replace bootstrap with CDN version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] KUDU-1487 Add instructions for cutting a release
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1487 Add instructions for cutting a release .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2432/ -- To view, visit http://gerrit.cloudera.org:8080/3614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b52edb68d35d07ee50bb3c373bf866560f5bc93 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] KUDU-1487 Add instructions for cutting a release
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3614 to look at the new patch set (#6). Change subject: KUDU-1487 Add instructions for cutting a release .. KUDU-1487 Add instructions for cutting a release Change-Id: I5b52edb68d35d07ee50bb3c373bf866560f5bc93 --- A RELEASING.adoc 1 file changed, 195 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/3614/6 -- To view, visit http://gerrit.cloudera.org:8080/3614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b52edb68d35d07ee50bb3c373bf866560f5bc93 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR] Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3651 Change subject: Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT .. Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT Change-Id: If8aa4a73ef33c413a52c5cb69d81f0edb192135e --- M java/interface-annotations/pom.xml M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-csd/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M version.txt 9 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/3651/1 -- To view, visit http://gerrit.cloudera.org:8080/3651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8aa4a73ef33c413a52c5cb69d81f0edb192135e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT
Kudu Jenkins has posted comments on this change. Change subject: Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2433/ -- To view, visit http://gerrit.cloudera.org:8080/3651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8aa4a73ef33c413a52c5cb69d81f0edb192135e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT
Mike Percy has posted comments on this change. Change subject: Change version from 1.0.0-SNAPSHOT to 0.10.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8aa4a73ef33c413a52c5cb69d81f0edb192135e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR](gh-pages) Replace bootstrap with CDN version
Mike Percy has posted comments on this change. Change subject: Replace bootstrap with CDN version .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] docs: Fix broken link to Introduction in navbar
Mike Percy has submitted this change and it was merged. Change subject: docs: Fix broken link to Introduction in navbar .. docs: Fix broken link to Introduction in navbar We moved introduction.adoc to index.adoc, but the navigation bar still points to introduction.html Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da Reviewed-on: http://gerrit.cloudera.org:8080/3650 Tested-by: Mike Percy Reviewed-by: Jean-Daniel Cryans --- M docs/support/jekyll-templates/document.html.erb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Mike Percy: Verified -- To view, visit http://gerrit.cloudera.org:8080/3650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4bee45e2470d9d9c09da82d4fad7fa80893c7da Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](gh-pages) Replace bootstrap with CDN version
Mike Percy has submitted this change and it was merged. Change subject: Replace bootstrap with CDN version .. Replace bootstrap with CDN version This has significant performance benefits. Also, remove our hosted bootstrap files. We don't need them. Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 Reviewed-on: http://gerrit.cloudera.org:8080/3649 Reviewed-by: Jean-Daniel Cryans Tested-by: Mike Percy --- M _includes/bottom_common.html M _includes/top_common.html D css/bootstrap-responsive.css D css/bootstrap-responsive.min.css D css/bootstrap-theme.css D css/bootstrap-theme.css.map D css/bootstrap-theme.min.css D css/bootstrap.css D css/bootstrap.css.map D css/bootstrap.min.css D js/bootstrap.js D js/bootstrap.min.js 12 files changed, 6 insertions(+), 10,182 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Mike Percy: Verified -- To view, visit http://gerrit.cloudera.org:8080/3649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefcc5fada12e0c87fa98a3eb7faec9db205c2cf2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Kudu Jenkins has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 4: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2434/ -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1487 Add instructions for cutting a release
Mike Percy has posted comments on this change. Change subject: KUDU-1487 Add instructions for cutting a release .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b52edb68d35d07ee50bb3c373bf866560f5bc93 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Jean-Daniel Cryans has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3581/4/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS4, Line 793: that the if the nit PS4, Line 801: InsertOrDie(&tablets_by_key, "", std::move(entry)); So this means we make the whole key space non-covered? What if the user deleted all the tablets and started adding them back... wouldn't we basically block unlucky clients for "expiration_time" who queried the master when the table reached 0 tablets? I dont' remember if we decided to start supporting re-adding tablets in a previously-occupied key space. -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3648/1/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 900: // If there are add partition steps, clear the local meta cache so that the Not sure I like this, it's pretty heavy handed to clear the whole cache. Also, if you don't wait above, won't the tablets still not be created and we might end up re-caching non-covered ranges? OTOH I don't think it'd be pretty common to alter from an application that manipulates data, unless it's like a shell. http://gerrit.cloudera.org:8080/#/c/3648/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 550: // Multiple range partitions may be dropped, but they must all exatly match : // one of the tables range partitions. So this means that you can drop multiple tablets? So it's not just dropping one partition? -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#2). Change subject: KUDU-1311 [master] support adding and dropping range partitions .. KUDU-1311 [master] support adding and dropping range partitions Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/table_alterer-internal.cc M src/kudu/client/table_alterer-internal.h M src/kudu/common/partition.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/ksck.cc 17 files changed, 712 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3648/2 -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Kudu Jenkins has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2436/ -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Dan Burkert has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3581/4/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS4, Line 793: that if the par > nit Done PS4, Line 801: InsertOrDie(&tablets_by_key, "", std::move(entry)); > So this means we make the whole key space non-covered? Yes, that's correct. We do support removing and adding tablets 'back', but in that case it would not become visible to existing clients until the TTL expired (in the worst case). -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3581 to look at the new patch set (#5). Change subject: [c++-client]: cache non-covering ranges in meta cache .. [c++-client]: cache non-covering ranges in meta cache This commit introduces a few features to the meta cache, all with the aim of making it compatible with the upcoming add/drop range partitions feature. 1) Non-covered range partitions are now cached in the meta cache. This is achieved by storing MetaCacheEntry objects in the meta cache's partition-key index instead of RemoteTablets. The MetaCacheEntry holds either a RemoteTablet, in which case it represents a covered partition range, or it represents a non-covered partition range. 2) Entries are now removed from the meta cache's partition-key index when it can be determined that the entries are no longer valid from the results of a GetTableLocations RPC. 3) A basic TTL has been added to the GetTableLocationsResponsePB so that the client can properly refresh the meta cache when necessary. The TTL is configurable by the master, and defaults to one hour. Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 --- M src/kudu/client/client-test.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/schema.h M src/kudu/client/table-internal.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/ksck_remote.cc 9 files changed, 379 insertions(+), 124 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/3581/5 -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2435/ -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3648/1/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 900: // If there are add partition steps, clear the local meta cache so that the > Not sure I like this, it's pretty heavy handed to clear the whole cache. Al Added a comment about why clearing the cache is still effective even if the alter is not waited on. As far as the perf. impact of this change, I don't expect it to happen very often. I also agree that most instances will be as part of something like a CLI tool that has a fresh client anyway. For applications like kudu-ts which have long running clients which may occasionally add partitions, I don't think the perf. impact will be that meaningful. We can always revisit if it ends up being a problem. http://gerrit.cloudera.org:8080/#/c/3648/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 550: // Multiple range partitions may be dropped, but they must all exatly match : // one of the tables range partitions. > So this means that you can drop multiple tablets? So it's not just dropping No, this would happen if the method is called multiple times as part of a single alter operation. -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#3). Change subject: KUDU-1311 [master] support adding and dropping range partitions .. KUDU-1311 [master] support adding and dropping range partitions Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/table_alterer-internal.cc M src/kudu/client/table_alterer-internal.h M src/kudu/common/partition.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/ksck.cc 17 files changed, 716 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3648/3 -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2437/ -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] rw mutex: add configurable priority
Dan Burkert has posted comments on this change. Change subject: rw_mutex: add configurable priority .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3603/4/src/kudu/util/rw_mutex.h File src/kudu/util/rw_mutex.h: Line 28: // Implemented as a thin wrapper around pthread_rwlock_t. A note about reentrance is warranted I think. -- To view, visit http://gerrit.cloudera.org:8080/3603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix encoding-test on OS X
Dan Burkert has submitted this change and it was merged. Change subject: Fix encoding-test on OS X .. Fix encoding-test on OS X A recent change caused encoding-test to fail on OS X. This reverts the part of the change that causes the test to fail (and nothing else). I'm not sure why it fails on OS X and not in, e.g., Jenkins builds. Change-Id: Ie221906ee3960fa158843c2ae2dd7a531e74c5c4 Reviewed-on: http://gerrit.cloudera.org:8080/3640 Reviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M src/kudu/cfile/encoding-test.cc 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie221906ee3960fa158843c2ae2dd7a531e74c5c4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3648/3/src/kudu/client/client.h File src/kudu/client/client.h: PS3, Line 546: dropped nit -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3648/3/src/kudu/client/client.h File src/kudu/client/client.h: PS3, Line 546: dropped > nit Done -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#4). Change subject: KUDU-1311 [master] support adding and dropping range partitions .. KUDU-1311 [master] support adding and dropping range partitions Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/table_alterer-internal.cc M src/kudu/client/table_alterer-internal.h M src/kudu/common/partition.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/ksck.cc 17 files changed, 713 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3648/4 -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2438/ -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] rw mutex: add configurable priority
Adar Dembo has posted comments on this change. Change subject: rw_mutex: add configurable priority .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3603/4/src/kudu/util/rw_mutex.h File src/kudu/util/rw_mutex.h: Line 28: // Implemented as a thin wrapper around pthread_rwlock_t. > A note about reentrance is warranted I think. I added one in the follow-on patch (the one that bans recursive acquisition). -- To view, visit http://gerrit.cloudera.org:8080/3603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add integration tests for replay cache with writes
David Ribeiro Alves has posted comments on this change.
Change subject: Add integration tests for replay cache with writes
..
Patch Set 29:
(8 comments)
i moved these to a new itest, also moved a couple of methods out of raft
consensus itest to the parent class so that I can use them in the new test.
http://gerrit.cloudera.org:8080/#/c/3519/24/src/kudu/integration-tests/raft_consensus-itest.cc
File src/kudu/integration-tests/raft_consensus-itest.cc:
PS24, Line 1043: RestartAnyCrashedTabletServers()
> This method needs a flag indicating whether servers are allowed to crash in
good catch. added the flag and also added an AssertNoTabletServersCrashed
Line 1047: bool mismatched = false;
> Please add a comment here to summarize the purpose of this logic. It took m
Done
PS24, Line 1079: (1234
> s/1234/SeedRandom()/
this is on purpose so that all threads are seeded with the same random as they
are supposed to generate the same rows. Will add a comment though
Line 1125: status = controller.status();
> Returning controller.status() is already what Write() does. See proxy.cc L9
Was mimicking the client code, but writes are async there. you're right. Done
Line 1141: FAIL() << "Couldn't write request to tablet server @ " <<
address.ToString();
> how about append the last status as well?
Done
Line 1181: TEST_F(RaftConsensusITest,
TestWritesWithExactlyOnceSemanticsWithChurnyElections) {
> Needs comment
Done
PS24, Line 1184: defined(__SANITIZE_ADDRESS__) || defined(ADDRESS_SANITIZER)
> we should only need one of these two, right?
gcc calls it one thing and clang calls it another. We've used the two elsewhere.
http://gerrit.cloudera.org:8080/#/c/3519/29/src/kudu/rpc/rpc_header.proto
File src/kudu/rpc/rpc_header.proto:
Line 130: required int64 attempt_no = 4;
> Please squash this change into a previous commit, or squash this whole patc
this change is first needed in this patch. Usually attempt numbers never get
this high, its just that the tests used very high numbers to make sure they are
unique. Will mention this in the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/3519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f
Gerrit-PatchSet: 29
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] rw mutex: prevent recursive use
Adar Dembo has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3641/1/src/kudu/util/rw_mutex-test.cc File src/kudu/util/rw_mutex-test.cc: Line 52: // Multi-threaded test that tries to find deadlocks in the RWMutex wrapper. > is this actually a realistic scenario to be concerned about? don't we expec I wrote it to check that the wrapper changes I made (which include an additional lock) didn't cause any deadlocks or TSAN warnings. Not the pthread implementation itself. Line 71: // Do something that the compiler won't optimize away. > I dont think the compiler can optimize this stuff away because it includes Ah okay. I'll remove that then. -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] env: add GetFileSizeOnDiskRecursively
Adar Dembo has submitted this change and it was merged. Change subject: env: add GetFileSizeOnDiskRecursively .. env: add GetFileSizeOnDiskRecursively This was originally needed by a new integration test. Since then, it's no longer needed, but the new method might prove useful in the future. Change-Id: Ic49629595e776ce5c755e15b04c6509053ff361f Reviewed-on: http://gerrit.cloudera.org:8080/3644 Tested-by: Adar Dembo Reviewed-by: Dan Burkert --- M src/kudu/tablet/compaction-test.cc M src/kudu/util/env.h M src/kudu/util/env_posix.cc 3 files changed, 44 insertions(+), 31 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/3644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic49629595e776ce5c755e15b04c6509053ff361f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy
[kudu-CR] rw mutex: add configurable priority
Adar Dembo has submitted this change and it was merged. Change subject: rw_mutex: add configurable priority .. rw_mutex: add configurable priority The glibc implementation of pthread rwlocks exposes priorities that can help if avoiding reader or writer starvation is desirable. I have a use case for the latter, so let's expose the priorities in our wrapper. Note: pthread rwlock priorities don't exist on macOS, which is why they're a "best effort". Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Reviewed-on: http://gerrit.cloudera.org:8080/3603 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon Reviewed-by: Dan Burkert --- M src/kudu/util/rw_mutex.cc M src/kudu/util/rw_mutex.h 2 files changed, 54 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rw mutex: add configurable priority
Dan Burkert has posted comments on this change. Change subject: rw_mutex: add configurable priority .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix flaky disk reservation-itest
Kudu Jenkins has posted comments on this change. Change subject: Fix flaky disk_reservation-itest .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2439/ -- To view, visit http://gerrit.cloudera.org:8080/3652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica86390b49d459e079807d777e97c47fa35134d1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix flaky disk reservation-itest
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3652 to review the following change. Change subject: Fix flaky disk_reservation-itest .. Fix flaky disk_reservation-itest There are two fixes in this patch for two separate types of failures seen on Jenkins for this test: 1. Fix a data race in DiskReservationITest.TestFillMultipleDisks We can't override gflag strings at runtime in a thread-safe manner, although this test was attempting to. Take what used to be a single parsed string gflag and replace it with 2 path strings and 2 integer overrides, one for each path. That makes 4 new test-only gflags total. Only the integer flags are modified at runtime. 2. Fix a startup race between the TestWorkload client thread and SetFlags() in DiskReservationITest.TestWalWriteToFullDiskAborts We need to wait for some rows to be written after starting up the TestWorkload threads in TestWalWriteToFullDiskAborts before we allow the TS to crash by setting gflags. If we don't, the test gets confused because the TestWorkload client thread may not be able to resolve where the tablet is located. The previous failures were because we sometimes managed to crash the TS before it sent its tablet report to the master. After applying these changes, I looped disk_reservation-itest 1000x in TSAN mode and got no failures. Change-Id: Ica86390b49d459e079807d777e97c47fa35134d1 --- M src/kudu/integration-tests/disk_reservation-itest.cc M src/kudu/util/env_util.cc 2 files changed, 61 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3652/1 -- To view, visit http://gerrit.cloudera.org:8080/3652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ica86390b49d459e079807d777e97c47fa35134d1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 30: Build Started http://104.196.14.100/job/kudu-gerrit/2440/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 30 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
David Ribeiro Alves has uploaded a new patch set (#30). Change subject: Add integration tests for replay cache with writes .. Add integration tests for replay cache with writes This adds a couple of new integration tests for replay cache with writes. Both tests start multiple threads writing, independently, to tablet servers simulaneously. The tests leverage the fact that followers are also able to answer requests, once they are cached, and stores all responses, which are compared at the end of the test. Some of the requests (1/3) are "empty" writes, so that we stress the serialization point in transaction_driver.cc without relying on row lock serialization. This adds two different tests, one that stresses a lot of elections and one that crashes nodes. This is inline with other tests we already had in raft_consensus-itest. This also adds a new fault injection point right after the leader sends a request. We currently have one right _before_ the leader sends a request, but having one for after the request is sent encourages stressing the path where a newly elected leader as both incoming client request and ongoing replica transactions, which can possibly race with each other if they correspond to the same write. Finally this changes attempt_no in RequestIdPB to be an int64 instead of just an int. While an int is more than enough in normal operation, the new test generates many more attempts and we need a bigger number to make sure all attempt numbers are unique. I looped this about 1000 times, without related failures. Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f --- M src/kudu/consensus/consensus_peers.cc M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/ts_itest-base.h M src/kudu/rpc/rpc_header.proto 6 files changed, 322 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3519/30 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 30 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix flaky disk reservation-itest
Mike Percy has posted comments on this change. Change subject: Fix flaky disk_reservation-itest .. Patch Set 1: Verified+1 Overriding Jenkins failure due to flaky Java test filed as KUDU-1531 -- To view, visit http://gerrit.cloudera.org:8080/3652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica86390b49d459e079807d777e97c47fa35134d1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 2): heartbeat to every master
Dan Burkert has posted comments on this change.
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3610/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
Line 176: if (reports[0].updated_tablets_size()) break;
!reports[0].updated_tablets().empty()
http://gerrit.cloudera.org:8080/#/c/3610/6/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:
Line 206: for (int i = first_failure_idx - 1; i >= 0; i--) {
I think this would be more straightforward as a forward loop:
for (int i = 0; i < first_failure_idx; i++)
you might also simplify some of the locals by putting it inside the failure
claus in the first loop.
Line 384: "Failed to send heartbeat to master");
should this have the master addr as well?
http://gerrit.cloudera.org:8080/#/c/3610/6/src/kudu/tserver/ts_tablet_manager.h
File src/kudu/tserver/ts_tablet_manager.h:
Line 153: void PopulateTabletReport(master::TabletReportPB* report,
this API is pretty funky, any reason not to have separate
PopulateFullTabletReport and PopulatePartialTabletReport(TabletReportPB*, const
vector&) methods? Doesn't look like the implementation reuses much.
--
To view, visit http://gerrit.cloudera.org:8080/3610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] rw mutex: prevent recursive use
Dan Burkert has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3641/1/src/kudu/util/rw_mutex.h File src/kudu/util/rw_mutex.h: Line 85: I_AM_NEITHER, You can just call these 'NEITHER', 'READER', and 'WRITER', there is no clash since they are enum classes. -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] master: add read-write lock to serialize operations around elections
Dan Burkert has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add assert checks for leader lock
Dan Burkert has posted comments on this change. Change subject: master: add assert checks for leader_lock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefb5762c70192b27490cc71e20568815d18d6ad5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: fix initialization race with consensus RPCs
Dan Burkert has posted comments on this change. Change subject: master: fix initialization race with consensus RPCs .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d1276dd4d3c2f555d63d97d7a16d54181a352b7 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()
Dan Burkert has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: various fixes to DDL operations
Dan Burkert has posted comments on this change. Change subject: c++ client: various fixes to DDL operations .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09768240bd04cca95d95aefe17c34d276075125b Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Memory tracking for result tracker
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#6). Change subject: Memory tracking for result tracker .. Memory tracking for result tracker This adds memory tracking to ResultTracker, making sure we account for the memory as we cache responses for client's requests. Testing wise this adds memory consumption checks to rpc-stress-test.cc. Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/server/server_base.cc 5 files changed, 106 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/3627/6 -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Memory tracking for result tracker
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2442/ -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2441/ -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88d7c65887a98544ee83b5b4bc0817bea7222131 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()
Kudu Jenkins has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2454/ -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add read-write lock to serialize operations around elections
Kudu Jenkins has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2452/ -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 2): heartbeat to every master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2450/ -- To view, visit http://gerrit.cloudera.org:8080/3610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] rw mutex: prevent recursive use
Kudu Jenkins has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2449/ -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: do not delete unknown tablets
Kudu Jenkins has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2443/ -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Kudu Jenkins has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2453/ -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2444/ -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3581 to look at the new patch set (#6). Change subject: [c++-client]: cache non-covering ranges in meta cache .. [c++-client]: cache non-covering ranges in meta cache This commit introduces a few features to the meta cache, all with the aim of making it compatible with the upcoming add/drop range partitions feature. 1) Non-covered range partitions are now cached in the meta cache. This is achieved by storing MetaCacheEntry objects in the meta cache's partition-key index instead of RemoteTablets. The MetaCacheEntry holds either a RemoteTablet, in which case it represents a covered partition range, or it represents a non-covered partition range. 2) Entries are now removed from the meta cache's partition-key index when it can be determined that the entries are no longer valid from the results of a GetTableLocations RPC. 3) A basic TTL has been added to the GetTableLocationsResponsePB so that the client can properly refresh the meta cache when necessary. The TTL is configurable by the master, and defaults to one hour. Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 --- M src/kudu/client/client-test.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/schema.h M src/kudu/client/table-internal.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/ksck_remote.cc 9 files changed, 381 insertions(+), 124 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/3581/6 -- To view, visit http://gerrit.cloudera.org:8080/3581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2448/ -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add assert checks for leader lock
Kudu Jenkins has posted comments on this change. Change subject: master: add assert checks for leader_lock .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2447/ -- To view, visit http://gerrit.cloudera.org:8080/3642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefb5762c70192b27490cc71e20568815d18d6ad5 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2445/ -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] rw mutex: prevent recursive use
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3641 to look at the new patch set (#3). Change subject: rw_mutex: prevent recursive use .. rw_mutex: prevent recursive use Todd provided an example[1] of deadlocked rwlocks due to a fairness policy. In the example, T1 (holding the lock for reading) join()ed on T2 (trying to acquire the lock for reading) all while T3 was trying to acquire the lock for writing. The lock's fairness policy prevented T2 from acquiring the read lock thus deadlocking all three threads. The takeaway is to be careful when calling join() while holding locks. Beyond that, deadlocks can arise if rwlocks are taken recursively. That's not a feature we need in our rwlocks, so I tried to disable it at the pthread level. Unfortunately, the best I can do is disable recursive write lock acquisition; read locks are apparently always recursive (see "man pthread_rwlockattr_setkind_np"). So instead, I built recursive checking into the RWMutex itself. It's quite slow so it's only present in debug builds. Note that pthread rwlocks do have some built-in deadlock detection (i.e. lock calls may return EDEADLK), but it doesn't appear to be comprehensive. 1. https://issues.apache.org/jira/browse/HDFS-2223?focusedCommentId=13097647&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13097647 Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db --- M src/kudu/util/CMakeLists.txt A src/kudu/util/rw_mutex-test.cc M src/kudu/util/rw_mutex.cc M src/kudu/util/rw_mutex.h 4 files changed, 297 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/3641/3 -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] master: do not delete unknown tablets
Kudu Jenkins has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2455/ -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] master: add read-write lock to serialize operations around elections
Kudu Jenkins has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2464/ -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add assert checks for leader lock
Kudu Jenkins has posted comments on this change. Change subject: master: add assert checks for leader_lock .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2459/ -- To view, visit http://gerrit.cloudera.org:8080/3642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefb5762c70192b27490cc71e20568815d18d6ad5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2460/ -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] rw mutex: prevent recursive use
Kudu Jenkins has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2461/ -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: fix initialization race with consensus RPCs
Kudu Jenkins has posted comments on this change. Change subject: master: fix initialization race with consensus RPCs .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2463/ -- To view, visit http://gerrit.cloudera.org:8080/3605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d1276dd4d3c2f555d63d97d7a16d54181a352b7 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2456/ -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()
Kudu Jenkins has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2465/ -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2457/ -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 2): heartbeat to every master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2462/ -- To view, visit http://gerrit.cloudera.org:8080/3610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: various fixes to DDL operations
Kudu Jenkins has posted comments on this change. Change subject: c++ client: various fixes to DDL operations .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2458/ -- To view, visit http://gerrit.cloudera.org:8080/3608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09768240bd04cca95d95aefe17c34d276075125b Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()
Dan Burkert has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: various fixes to DDL operations
Dan Burkert has posted comments on this change. Change subject: c++ client: various fixes to DDL operations .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09768240bd04cca95d95aefe17c34d276075125b Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: fix initialization race with consensus RPCs
Dan Burkert has posted comments on this change. Change subject: master: fix initialization race with consensus RPCs .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d1276dd4d3c2f555d63d97d7a16d54181a352b7 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add assert checks for leader lock
Dan Burkert has posted comments on this change. Change subject: master: add assert checks for leader_lock .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefb5762c70192b27490cc71e20568815d18d6ad5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add read-write lock to serialize operations around elections
Dan Burkert has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: fix initialization race with consensus RPCs
Kudu Jenkins has posted comments on this change. Change subject: master: fix initialization race with consensus RPCs .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2451/ -- To view, visit http://gerrit.cloudera.org:8080/3605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d1276dd4d3c2f555d63d97d7a16d54181a352b7 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: various fixes to DDL operations
Kudu Jenkins has posted comments on this change. Change subject: c++ client: various fixes to DDL operations .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2446/ -- To view, visit http://gerrit.cloudera.org:8080/3608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09768240bd04cca95d95aefe17c34d276075125b Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package
Dinesh Bhat has uploaded a new change for review. http://gerrit.cloudera.org:8080/3653 Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. KUDU-1530: Update docs about OS X build dependency on Xcode package Change-Id: I8962d5539f437dba8b120c70c90c1e384ed550c9 --- M docs/installation.adoc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/3653/1 -- To view, visit http://gerrit.cloudera.org:8080/3653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8962d5539f437dba8b120c70c90c1e384ed550c9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat
[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2466/ -- To view, visit http://gerrit.cloudera.org:8080/3653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8962d5539f437dba8b120c70c90c1e384ed550c9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP: Add garbage collection to ResultTracker
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#4). Change subject: WIP: Add garbage collection to ResultTracker .. WIP: Add garbage collection to ResultTracker This still needs testing and hooking up to the mm. Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/service_if.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/transactions/transaction_driver.cc 7 files changed, 162 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3628/4 -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: Add garbage collection to ResultTracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2467/ -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP [java-client] Re-enable multi-master tests
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3654 Change subject: WIP [java-client] Re-enable multi-master tests .. WIP [java-client] Re-enable multi-master tests This patch makes TestMasterFailover useful again. It also adds the killing of masters to ITClient. Finally, it sets the raft heartbeat lower so that we don't wait 1.5s for leader elections. WIP because I was getting failures before and now it just works, which makes me worried. Hoping ASAN or TSAN will trigger something. Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 --- M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestMasterFailover.java 4 files changed, 9 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/3654/1 -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] WIP [java-client] Re-enable multi-master tests
Kudu Jenkins has posted comments on this change. Change subject: WIP [java-client] Re-enable multi-master tests .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2468/ -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package
Adar Dembo has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3653/1/docs/installation.adoc File docs/installation.adoc: What is the "XCode package"? Is that something that's totally obvious to a macOS user, and distinct from "XCode Command Line Tools"? Line 476: observed that Xcode pacakge is required to resolve some dependencies. These Nit: "...that the Xcode package is..." -- To view, visit http://gerrit.cloudera.org:8080/3653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8962d5539f437dba8b120c70c90c1e384ed550c9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] WIP: Add garbage collection to ResultTracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2469/ -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP: Add garbage collection to ResultTracker
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#5). Change subject: WIP: Add garbage collection to ResultTracker .. WIP: Add garbage collection to ResultTracker This still needs testing and hooking up to the mm. Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/service_if.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/transactions/transaction_driver.cc 7 files changed, 162 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3628/5 -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP [java-client] Re-enable multi-master tests
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java-client] Re-enable multi-master tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3654/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 198: "--raft_heartbeat_interval_ms=200"); > Why this change? See my commit message. http://gerrit.cloudera.org:8080/#/c/3654/1/java/kudu-client/src/test/java/org/kududb/client/TestMasterFailover.java File java/kudu-client/src/test/java/org/kududb/client/TestMasterFailover.java: PS1, Line 42: /** :* This test is disabled as we're not supporting multi-master just yet. :*/ > Remove this. Done -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] WIP [java-client] Re-enable multi-master tests
Adar Dembo has posted comments on this change. Change subject: WIP [java-client] Re-enable multi-master tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3654/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 198: "--raft_heartbeat_interval_ms=200"); > See my commit message. Ah, missed that. Can you add a comment here with the justification? -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] WIP [java-client] Re-enable multi-master tests
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java-client] Re-enable multi-master tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3654/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 198: "--raft_heartbeat_interval_ms=200"); > Ah, missed that. Can you add a comment here with the justification? Done -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [c++-client]: cache non-covering ranges in meta cache
Adar Dembo has posted comments on this change.
Change subject: [c++-client]: cache non-covering ranges in meta cache
..
Patch Set 5:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS5, Line 1223: int original_table_locations_ttl_ms =
FLAGS_table_locations_ttl_ms;
: FLAGS_table_locations_ttl_ms = new_ttl;
: auto cleanup = MakeScopedCleanup([&] () {
: FLAGS_table_locations_ttl_ms =
original_table_locations_ttl_ms;
: });
You can instantiate a FlagSaver instead.
Line 1238: ASSERT_FALSE(entry.stale());
The TTL is 25ms, so it's conceivable that on a bogged down test environment the
entry may become stale between the time that it is inserted and the time that
stale() is called.
Could you loop this test 1000 times with TSAN and see if it's indeed flaky?
Alternatively we could raise the TTL but that just means a longer sleep below.
Or perhaps this (and L1246-1247) should be done in a loop and accepted provided
one iteration passes.
http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/client.h
File src/kudu/client/client.h:
Line 300: FRIEND_TEST(ClientTest, TestMetaCacheExpiry);
Nit: sort alphabetically.
http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:
PS5, Line 753: if (new_status.IsServiceUnavailable()) {
: // One or more of the tablets is not running; retry after a
backoff period.
: mutable_retrier()->DelayedRetry(this, new_status);
: ignore_result(delete_me.release());
: return;
: }
To be clear, this has nothing to do with non-covering range partition support,
right? This should have been added as part of 30d76a3? As an analogue of
1a97c42?
Line 790: if (rpc.resp().tablet_locations().empty()) {
rpc.resp().tablet_locations() is called four times, maybe pull it out into a
cref local variable?
Line 803: string last_upper_bound =
If possible, could you add an ASCII art diagram to this section that will
visually map tablets (or non-covered ranges) to sections of code that handle
them?
For example:
// ab cbc b
// +--+ +-+ +-+
// | | | | | |
// +--+ +-+ +-+
And then in the code comments, add references to a), b), c) etc. as needed.
PS5, Line 817: tablet.partition().partition_key_start()
Can you pull this (and end) into local variables?
PS5, Line 848: FindOrDie(tablets_by_key,
tablet.partition().partition_key_start());
This assumes that a tablet can't change in partition size (i.e. that should
mean a new tablet), right? Since the partition information comes off the wire,
it might be better to handle that weird state gracefully.
Alternatively, if tablets_by_id_ values were MetaCacheEntries instead of
RemoteTablets, you'd have the TTL right there. But then you'd need to share
MetaCacheEntries amongst the two maps (using shared ownership); not sure if
that's net less complexity or not.
PS5, Line 850: entry.upper_bound_partition_key() ==
tablet.partition().partition_key_end());
This part also depends on well-formed information off the wire.
PS5, Line 865: MetaCacheEntry entry(expiration_time, remote);
: VLOG(3) << "Caching '" << rpc.table_name() << "' entry "
<< entry.DebugString(rpc.table());
:
: InsertOrDie(&tablets_by_id_, tablet_id, remote);
: InsertOrDie(&tablets_by_key,
partition.partition_key_start(), std::move(entry));
Maybe encapsulate this (and the non-covered range variant) in a helper method?
PS5, Line 874: // There is a non-covered range between the last tablet
upper bound and
: // the end of the partition key space.
What if the total number of tablets is a multiple of
MAX_RETURNED_TABLE_LOCATIONS and we just did a lookup for the last batch of
tablets? There may be a non-covered range at the end, but we won't insert an
entry for it here. Is that a problem?
Line 885: *cache_entry = *DCHECK_NOTNULL(FindFloorOrNull(tablets_by_key,
rpc.partition_key()));
Why FindFloorOrNull if you DCHECK_NOTNULL() right after? Seems unsafe.
http://gerrit.cloudera.org:8080/#/c/3581/1/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:
Line 283: const scoped_refptr& tablet() const {
> That wouldn't type check. I'm not seeing a warning with clang or gcc 4.9,
Sure, or DCHECK(tablet_.get())
http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/table-internal.cc
File src/kudu/client/table-internal.cc:
PS5, Line 133: if (s.ok()) {
: break;
: } else {
: LOG(WARNING) << "Error getting table locations: " <<
s.ToString() << ", retrying.";
