[kudu-CR] KUDU-1444. Get resource metrics of a scan.

Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 6: OK. The code now looks good, but missing a test. Sorry, I should have mentioned that previously. Maybe

[kudu-CR](branch-0.9.x) ksck: usability improvements in error messages

Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3226 Change subject: ksck: usability improvements in error messages .. ksck: usability improvements in error messages - print the address of ta

[kudu-CR] ksck: usability improvements in error messages

Todd Lipcon has submitted this change and it was merged. Change subject: ksck: usability improvements in error messages .. ksck: usability improvements in error messages - print the address of tablet servers that fail to connec

[kudu-CR] ksck: usability improvements in error messages

Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: usability improvements in error messages .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3225 To unsubscribe, visit h

[kudu-CR] ksck: usability improvements in error messages

Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3225 to review the following change. Change subject: ksck: usability improvements in error messages .. ksck: usabili

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. KUDU-1267: Calling getString() on RowResult for wrong type gave weird ex

[kudu-CR](branch-0.9.x) KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Todd Lipcon has posted comments on this change. Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas .. Patch Set 1: I think this is worth cherry-picking - it seems to have dropped some compactions f

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas .. KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas When handling a zipfian

[kudu-CR](branch-0.9.x) KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3224 Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas .. KUDU-749 (part 2): avoid O(n^2) behavior when compacting

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 7: Code-Review+2 Looks good. Let's see if it passes the precheckin tes

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3102 to look at the new patch set (#7). Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 4: > Quick update ..I have finished making changes based on the review > so far

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Adar Dembo has posted comments on this change. Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3221/2//COMMIT_MSG Co

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3221/2//COMMIT_MSG Commit M

Re: [kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Thanks for being modest. I wondered why it's an Append (unlike what other databases are doing). Just curious, what the perf gain after the change for this specific test? On Wed, May 25, 2016 at 4:01 PM, Todd Lipcon (Code Review) < ger...@cloudera.org> wrote: > Hello David Ribeiro Alves, Mike Per

[kudu-CR] Add unique id generation to the client

Adar Dembo has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 14: Code-Review+1 Deferring to Todd on this series. -- To view, visit http://gerrit.cloudera.org:8080/3077 To

[kudu-CR] Remove default table partitioning

Adar Dembo has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 11: Python tests are still broken, and it looks like there's an RpcBenchmark failure too? Oh, and I think you misse

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 6: Ted, your patch still isn't compiling. Take a look at the latest "K

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3221 to look at the new patch set (#2). Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

Hello David Ribeiro Alves, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3221 to review the following change. Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas ...

[kudu-CR] Reduce verbosity of Java logs

Jean-Daniel Cryans has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/2/java/kudu-client/src/test/java/org/kududb/client/MiniK

[kudu-CR](branch-0.9.x) python: add support for specifying partitioning

Jean-Daniel Cryans has posted comments on this change. Change subject: python: add support for specifying partitioning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3218 To unsubscribe, visit

[kudu-CR](branch-0.9.x) python: add support for specifying partitioning

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: python: add support for specifying partitioning .. python: add support for specifying partitioning This adds support for range and hash partitionin

[kudu-CR] Remove default table partitioning

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#11). Change subject: Remove default table partitioning .. Remove default table parti

[kudu-CR] Remove default table partitioning

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#10). Change subject: Remove default table partitioning .. Remove default table parti

[kudu-CR] Reduce verbosity of Java logs

Dan Burkert has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties File jav

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3102 to look at the new patch set (#6). Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

[kudu-CR] Reduce verbosity of Java logs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3203 to look at the new patch set (#2). Change subject: Reduce verbosity of Java logs .. Reduce verbosity of Java logs

[kudu-CR](branch-0.9.x) python: add support for specifying partitioning

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3218 Change subject: python: add support for specifying partitioning .. python: add support for specifying partitioning This adds support for r

[kudu-CR] python: add support for specifying partitioning

Dan Burkert has posted comments on this change. Change subject: python: add support for specifying partitioning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3196 To unsubscribe, visit http://

[kudu-CR] python: add support for specifying partitioning

Dan Burkert has submitted this change and it was merged. Change subject: python: add support for specifying partitioning .. python: add support for specifying partitioning This adds support for range and hash partitioning when

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Dependency on Hadoop test classes causes Javadoc warnings and build

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

David Ribeiro Alves has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 3: Verified+1 unrelated java failure -- To view, visit http://gerrit.cloudera.org:8080/3179

[kudu-CR] Add unique id generation to the client

David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/13/src/kudu/client/client.h File src/kudu/cli

[kudu-CR] Add unique id generation to the client

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3077 to look at the new patch set (#14). Change subject: Add unique id generation to the client .. Add unique id generat

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3102/5/java/kudu-c

[kudu-CR] [c++-client]: minimal changes to support tables with non-covering range partitions

Adar Dembo has posted comments on this change. Change subject: [c++-client]: minimal changes to support tables with non-covering range partitions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3177/1/src/kudu

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 5: (2 comments) Almost there, just two more little nits to fix. http

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

Adar Dembo has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3179 To unsubscribe, visit http://g

[kudu-CR](branch-0.9.x) KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT .. KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT This fixes an issue with UPSERT

[kudu-CR] Add unique id generation to the client

Adar Dembo has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/13/src/kudu/client/client.h File src/kudu/client/clien

[kudu-CR] Change flush defaults to encourage parallel IO and larger flushes

Todd Lipcon has submitted this change and it was merged. Change subject: Change flush defaults to encourage parallel IO and larger flushes .. Change flush defaults to encourage parallel IO and larger flushes Based on some rece

[kudu-CR] Change flush defaults to encourage parallel IO and larger flushes

Jean-Daniel Cryans has posted comments on this change. Change subject: Change flush defaults to encourage parallel IO and larger flushes .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3186 To

[kudu-CR](branch-0.9.x) KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3216 To unsubsc

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Jean-Daniel Cryans has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 3: > Oh yeah lemme run this on the server that I know exhibits the

[kudu-CR] KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT .. KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT This fixes an issue with UPSERT

[kudu-CR](branch-0.9.x) KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3216 Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT .. KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Jean-Daniel Cryans has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 3: > Roger that. We'll verify it fixes the original problem, then

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Will Berkeley has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 3: Roger that. We'll verify it fixes the original problem, then I'd be

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Jean-Daniel Cryans has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 3: Code-Review+2 Works for me. The code could be improved (nits mo

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3199 to look at the new patch set (#3). Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Jean-Daniel Cryans has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 2: > Ah sorry newbie mistake: I was interpreting "pull" like "pull

[kudu-CR] [c++-client]: minimal changes to support tables with non-covering range partitions

Dan Burkert has posted comments on this change. Change subject: [c++-client]: minimal changes to support tables with non-covering range partitions .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3177/1/src/ku

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

David Ribeiro Alves has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3179/2/src/kudu/rpc/rpc_controller.h File

[kudu-CR] Add unique id generation to the client

David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/10//COMMIT_MSG Commit Message: Line 10: an u

[kudu-CR] Add unique id generation to the client

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3077 to look at the new patch set (#13). Change subject: Add unique id generation to the client .. Add unique id generat

[kudu-CR] Add unique id generation to the client

David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/integration-tests/client-stress-t

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#3). Change subject: Allow to set RequestId in the RPC RequestHeader .. Allow to set

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Will Berkeley has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 2: Ah sorry newbie mistake: I was interpreting "pull" like "pull it out

[kudu-CR] KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3208 To unsubs

[kudu-CR](branch-0.9.x) Remove a stray WARNING left in deltafile.cc

Jean-Daniel Cryans has posted comments on this change. Change subject: Remove a stray WARNING left in deltafile.cc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3212 To unsubscribe, visit http

[kudu-CR] KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3208 To unsubsc

[kudu-CR](branch-0.9.x) Remove a stray WARNING left in deltafile.cc

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Remove a stray WARNING left in deltafile.cc .. Remove a stray WARNING left in deltafile.cc This was a debugging warning that I accidentally left in

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

Jean-Daniel Cryans has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 2: > What unit test do you mean? Neither JarFinder or the function

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3102 to look at the new patch set (#4). Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3102 to look at the new patch set (#5). Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3013 to look at the new patch set (#6). Change subject: KUDU-1444. Get resource metrics of a scan. .. KUDU-1444. Get res

[kudu-CR](branch-0.9.x) Remove a stray WARNING left in deltafile.cc

Todd Lipcon has posted comments on this change. Change subject: Remove a stray WARNING left in deltafile.cc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3212 To unsubscribe, visit http://gerr

[kudu-CR](branch-0.9.x) Remove a stray WARNING left in deltafile.cc

Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3212 Change subject: Remove a stray WARNING left in deltafile.cc .. Remove a stray WARNING left in deltafile.cc This was a debugging warning th

[kudu-CR] Remove a stray WARNING left in deltafile.cc

Todd Lipcon has submitted this change and it was merged. Change subject: Remove a stray WARNING left in deltafile.cc .. Remove a stray WARNING left in deltafile.cc This was a debugging warning that I accidentally left in when f