[kudu-CR] [java client] Integrate with the replay cache
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Integrate with the replay cache .. [java client] Integrate with the replay cache This patch adds the required functionality to have the Java client use the server-side replay cache. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Reviewed-on: http://gerrit.cloudera.org:8080/3631 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestLeaderFailover.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java 11 files changed, 214 insertions(+), 3 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Integrate with the replay cache
Dan Burkert has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Integrate with the replay cache
Dan Burkert has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: Line 64: return incompleteRpcs.peek(); > Yeah it's just a question of timing, doing a peek then checking for null ha I meant the result of `incompleteRpcs.peek()` could be null, which would then throw a NPE during the cast. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3631 to look at the new patch set (#6). Change subject: [java client] Integrate with the replay cache .. [java client] Integrate with the replay cache This patch adds the required functionality to have the Java client use the server-side replay cache. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestLeaderFailover.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java 11 files changed, 214 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3631/6 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Integrate with the replay cache
Kudu Jenkins has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2559/ -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 257: private final String clientId; > looks like this isn't used? Done http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: Line 64: return incompleteRpcs.peek(); > peek will return null if the queue is empty, so you can get rid of the isEm Yeah it's just a question of timing, doing a peek then checking for null has the same issue, it might have already changed by the time you're checking... But your suggestion makes sense and saves a call! -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Dan Burkert has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 257: private final String clientId; looks like this isn't used? http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: Line 64: return incompleteRpcs.peek(); peek will return null if the queue is empty, so you can get rid of the isEmpty call. It also closes a potential TOCTOU (although I haven't though through if it actually matters). -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Kudu Jenkins has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2547/ -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Integrate with the replay cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3631 to look at the new patch set (#5). Change subject: [java client] Integrate with the replay cache .. [java client] Integrate with the replay cache This patch adds the required functionality to have the Java client use the server-side replay cache. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestLeaderFailover.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java 11 files changed, 218 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3631/5 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Integrate with the replay cache
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java
File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java:
PS4, Line 107: long
> docs
Done
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/Operation.java
File java/kudu-client/src/main/java/org/kududb/client/Operation.java:
Line 163: boolean isRetryableRpc() {
> docs
You meant to put that in KuduRpc? Or are you saying that this override here
should be documented?
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java
File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java:
Line 41: public RequestTracker(String clientId) {
> does the request tracker need to have the client id?
No, but you seemed keen on having the Java client be like the C++ side, so I
put it here. Originally I just had it in AsyncKuduClient.
--
To view, visit http://gerrit.cloudera.org:8080/3631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Integrate with the replay cache
..
Patch Set 4:
(4 comments)
looks mostly good, does this still have the side effect of making us not ignore
duplicated rows where we did before?
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java
File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java:
PS4, Line 107: long
docs
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/Operation.java
File java/kudu-client/src/main/java/org/kududb/client/Operation.java:
Line 163: boolean isRetryableRpc() {
docs
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java
File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java:
Line 41: public RequestTracker(String clientId) {
does the request tracker need to have the client id?
http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:
PS4, Line 254:
requestIdBuilder.setFirstIncompleteSeqNo(requestTracker.firstIncomplete());
> In the previous patch I wasn't sending this if the value would have been NO
thanks
--
To view, visit http://gerrit.cloudera.org:8080/3631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java: PS4, Line 254: requestIdBuilder.setFirstIncompleteSeqNo(requestTracker.firstIncomplete()); In the previous patch I wasn't sending this if the value would have been NO_SEQ_NO, but the C++ client does it and David thinks that field should be required. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Kudu Jenkins has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2481/ -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Integrate with the replay cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3631 to look at the new patch set (#4). Change subject: [java client] Integrate with the replay cache .. [java client] Integrate with the replay cache This patch adds the required functionality to have the Java client use the server-side replay cache. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestLeaderFailover.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java 11 files changed, 209 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3631/4 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/2//COMMIT_MSG Commit Message: PS2, Line 12: One major change in this patch is that the Flume, Spark, and MR bindings stop : using setIgnoreAllDuplicateRows() > yeah, I think we shouldn't change the default behavior without notice (i.e. Alright I'll remove that change. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Kudu Jenkins has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2398/ -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Integrate with the replay cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3631 to look at the new patch set (#3). Change subject: [java client] Integrate with the replay cache .. [java client] Integrate with the replay cache This patch adds the required functionality to have the Java client use the server-side replay cache. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestLeaderFailover.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java 11 files changed, 213 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3631/3 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Integrate with the replay cache
David Ribeiro Alves has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/2//COMMIT_MSG Commit Message: PS2, Line 12: One major change in this patch is that the Flume, Spark, and MR bindings stop : using setIgnoreAllDuplicateRows() > I don't know if this is a good idea. I like to think that it is, but maybe yeah, I think we shouldn't change the default behavior without notice (i.e. 1 release in between) even if replay cache is super solid and reliable. Moreover I'd definitely like to have this patch in before that so that we can start acummulating coverage -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Dan Burkert has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/2//COMMIT_MSG Commit Message: PS2, Line 12: One major change in this patch is that the Flume, Spark, and MR bindings stop : using setIgnoreAllDuplicateRows() > I don't know if this is a good idea. I like to think that it is, but maybe In at least few of these cases setIgnoreAllDuplicateRows was a crutch for lack of upsert support, and it should be transitioned to upsert instead of exactly once. Exactly once doesn't help when whole tasks can get retried. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/2//COMMIT_MSG Commit Message: PS2, Line 12: One major change in this patch is that the Flume, Spark, and MR bindings stop : using setIgnoreAllDuplicateRows() I don't know if this is a good idea. I like to think that it is, but maybe not for 0.10.0. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3631 to look at the new patch set (#2). Change subject: [java client] Integrate with the replay cache .. [java client] Integrate with the replay cache This patch adds the required functionality to have the Java client use the server-side replay cache. One major change in this patch is that the Flume, Spark, and MR bindings stop using setIgnoreAllDuplicateRows() meaning that from the moment this patch is committed users will need to specify "--enable_exactly_once" for their TS. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 --- M java/kudu-client-tools/src/main/java/org/kududb/mapreduce/tools/IntegrationTestBigLinkedList.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestLeaderFailover.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java M java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java M java/kudu-mapreduce/src/main/java/org/kududb/mapreduce/KuduTableOutputFormat.java M java/kudu-spark/src/main/scala/org/kududb/spark/kudu/KuduContext.scala 15 files changed, 213 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3631/2 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Integrate with the replay cache
Kudu Jenkins has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2390/ -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
