Re: Review Request 36501: MESOS-3023

2015-07-18 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 18, 2015, 9:47 a.m.) Review request for mesos. Bugs:

Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities

2015-07-18 Thread Aditi Dixit
On July 16, 2015, 8:13 p.m., Vinod Kone wrote: src/tests/fault_tolerance_tests.cpp, line 1831 https://reviews.apache.org/r/35797/diff/3/?file=1013501#file1013501line1831 Nice test! Thanks :) On July 16, 2015, 8:13 p.m., Vinod Kone wrote: src/master/master.hpp, line 534

Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities

2015-07-18 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated July 18, 2015, 2:23 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 36501: MESOS-3023

2015-07-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92170 --- Patch looks great! Reviews applied: [36501] All tests passed. -

Re: Review Request 36574: Added helper testing functions for Labels.

2015-07-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/#review92189 --- src/tests/mesos.hpp (line 1382)

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/#review92188 --- Ship it! I'll take care of these minor issues and commit, thanks.

Review Request 36596: Added jsonify() to stout.

2015-07-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36596/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json.

2015-07-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36575/ --- (Updated July 18, 2015, 8:38 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36585: Exposed `docker inspect` output via state.json

2015-07-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/ --- (Updated July 18, 2015, 8:38 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36580: Added TaskStatus label decorator hook for Slave.

2015-07-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/ --- (Updated July 18, 2015, 8:38 p.m.) Review request for mesos. Changes ---

Re: Review Request 36574: Added helper testing functions for Labels.

2015-07-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/ --- (Updated July 18, 2015, 8:38 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36596: Added jsonify() to stout.

2015-07-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36596/ --- (Updated July 18, 2015, 8:43 p.m.) Review request for mesos and Benjamin

Re: Review Request 36585: Exposed `docker inspect` output via state.json

2015-07-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92195 --- Bad patch! Reviews applied: [36596] Failed command:

Re: Review Request 36585: Exposed `docker inspect` output via state.json

2015-07-18 Thread Kapil Arya
On July 18, 2015, 9:28 p.m., Timothy Chen wrote: src/docker/executor.cpp, line 164 https://reviews.apache.org/r/36585/diff/2/?file=1015868#file1015868line164 So what's special about the label that we also need to include the docker inspect data in there? Why can't the framework