Re: Review Request 39037: Allow description empty in help information.

> On Oct. 8, 2015, 5:12 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/help.cpp, line 61 > > > > > > I think that the tldr logic does not needs to be changed, we can keep > > it in line 47 Mmm, let me revert

Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- (Updated Oct. 8, 2015, 6:59 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101881 --- Patch looks great! Reviews applied: [37024] All tests passed. -

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101873 --- docs/attributes-resources.md (line 104)

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 8, 2015, 7:01 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101874 --- src/sched/sched.cpp (line 157)

Re: Review Request 39008: Used thread-safe replacement for strerror.

> On Oct. 7, 2015, 2:18 p.m., Ben Mahler wrote: > > src/tests/script.cpp, line 101 > > > > > > malloc is not async-signal-safe, and may be used by the string > > implementation, and so we must not use os::strerror

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101883 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

Good call. Let’s change it! > On Oct 7, 2015, at 11:14 PM, Benjamin Mahler > wrote: > > Seems like os::strerror() would be more consistent with our other posix api > wrappers. > > On Wed, Oct 7, 2015 at 9:27 AM, Bernd Mathiske

Re: Review Request 39008: Used thread-safe replacement for strerror.

> On Oct. 7, 2015, 9:18 p.m., Ben Mahler wrote: > > src/tests/script.cpp, line 101 > > > > > > malloc is not async-signal-safe, and may be used by the string > > implementation, and so we must not use os::strerror

Re: Review Request 39088: Made shell test locale-independent.

> On Oct. 8, 2015, 9:52 a.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 961 > > > > > > s/LANG/LC_ALL > > > > At https://help.ubuntu.com/community/Locale it is

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 8, 2015, 2:31 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39087: Added support for non-ascii chars to apply-review.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39087/#review101901 --- Ship it! Ship It! - Jan Schlicht On Oct. 7, 2015, 4:54 p.m.,

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Oct. 8, 2015, 2:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 7, 2015, 4:27 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 28 > > > > > > Suggestion: "In contast to strerror(), this function is thread-safe."

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 6, 2015, 5:09 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 37 > > > > > > When strerror_r() returns EINVAL, you return an empty string? > > Cong Wang wrote: >

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review101816 --- Partial, entirely incomplete but maybe helpful review :)

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/ --- (Updated Oct. 8, 2015, 1:27 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 8, 2015, 2:39 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/ --- (Updated Oct. 8, 2015, 2:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 8, 2015, 6 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 104 > > > > > > Can we use a real json string which can map to above resources? Yea we can; I was worried about the readability

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review101924 --- Patch looks great! Reviews applied: [39005, 39006] All tests

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 8, 2015, 3:32 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 8, 2015, 5:05 p.m.) Review request for mesos and Joris Van

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101934 --- Patch looks great! Reviews applied: [39102] All tests passed. -

Re: Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39147/#review101975 --- Ship it! Ship It! - Timothy Chen On Oct. 8, 2015, 10:31 p.m.,

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/ --- (Updated Oct. 8, 2015, 11:05 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 9, 2015, 12:58 a.m.) Review request for mesos, Ben Mahler and

Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/ --- Review request for mesos. Bugs: MESOS-1661

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/#review102004 --- Patch looks great! Reviews applied: [39138, 29550, 29551] All

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:28 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39100: Changed Credential validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/#review101997 --- Patch looks great! Reviews applied: [39135, 39100] All tests

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review101996 --- Thanks for doing this, Jie! I have one nit and one question about

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- (Updated Oct. 9, 2015, 12:57 a.m.) Review request for mesos and Kapil Arya.

Re: Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102002 --- 3rdparty/libprocess/src/poll_socket.cpp (line 31)

Re: Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102003 --- BTW, please add your shepherd into pepole field. - Klaus Ma On

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/#review101988 --- Patch looks great! Reviews applied: [39005, 39007] All tests

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102006 --- include/mesos/mesos.proto (line 1119)

Re: Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39147/#review102009 --- Patch looks great! Reviews applied: [39147] All tests passed. -

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 8, 2015, 6:15 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/ --- (Updated Oct. 8, 2015, 6:15 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

> On Oct. 6, 2015, 12:39 p.m., Bernd Mathiske wrote: > > Ship It! > > Ben Mahler wrote: > I don't think we should introduce this into stout in its current form. I > realize you're planning to use this for authentication stuff, but looking at > this on its own, it seems like a confusing