> On Oct. 7, 2015, 4:27 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 28
> > <https://reviews.apache.org/r/39005/diff/1/?file=1091859#file1091859line28>
> >
> >     Suggestion: "In contast to strerror(), this function is thread-safe."

Documentation updated.


> On Oct. 7, 2015, 4:27 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 38
> > <https://reviews.apache.org/r/39005/diff/1/?file=1091859#file1091859line38>
> >
> >     If you wanted to be really devensive, not trusting strerror_r() on all 
> > unforeseeable platforms for all eternity, we could cut the loop at a max 
> > size.
> >     
> >     But then maybe we could just use a larger buffer to begin with and be 
> > done?
> >     
> >     Or, try 34 first and then something large like 1024, and that's it.

I changed the implementation to a fixed-size buffer.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review101779
-----------------------------------------------------------


On Oct. 8, 2015, 2:29 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 2:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to