Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103079 --- Ship it! Ship It! - Guangya Liu On 十月 17, 2015, 11:18 p.m.,

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > >

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38578/#review103087 --- Vinod, can you please help review this again? Thanks. - Guangya

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote: > > Why not make this as a default option? I think that we need to apply the > > whole chain of patch for development, thoughts? Thanks. It will break the verification script that ASF Jenkins currently uses. - Artem

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/#review103064 --- Ship it!

Re: Review Request 31625: Fixed broken link in framework development guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31625/#review103073 --- This seems like the wrong way to fix the problem: the core issue

Re: Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39423/#review103072 --- Patch looks great! Reviews applied: [39423] All tests passed. -

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review103071 --- include/mesos/resources.hpp (line 37)

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103080 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > >

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103090 --- Patch looks great! Reviews applied: [39386] All tests passed. -

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

> On Oct. 16, 2015, 11:34 p.m., Niklas Nielsen wrote: > > src/docker/executor.cpp, line 581 > > > > > > What happens when you remove this fallback, taken a user don't provide > > the launcher dir? Hi, @nnielsen.

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 18, 2015, 3:33 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote: > > support/apply-reviews.py, lines 272-274 > > > > > > Tab or blank space? If Tab, we should switch to blank space Thanks for spotting this! My editor was sneaking

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103082 --- Ship it! Ship It! - Guangya Liu On 十月 18, 2015, 10:33 p.m.,

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/ --- (Updated Oct. 19, 2015, 2:59 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

> On Oct. 16, 2015, 5:30 p.m., Marco Massenzio wrote: > > Thanks for doing this. > > > > I think you will need to document the flags' usage in `configuration.md` > > (or wherever appropriate) and state clearly that it's **required** and what > > it should point to (in other words, what

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 18, 2015, 3:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 18, 2015, 3:32 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 18, 2015, 3:30 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

> On Oct. 17, 2015, 8:43 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/owned.hpp, line 82 > > > > > > Wish we could use `nullptr`, but we currently only allow `NULL` for now. > > Here

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- (Updated Oct. 19, 2015, 4:48 a.m.) Review request for mesos and Joris Van

Re: Review Request 39428: Fixed typo in comment, minor style fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39428/#review103093 --- Ship it! Ship It! - Guangya Liu On 十月 19, 2015, 4:20 a.m.,

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review103099 --- Patch looks great! Reviews applied: [39230] All tests passed. -

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103095 --- Bad patch! Reviews applied: [39428, 39429] Failed command:

Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3326

Re: Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39330/#review103092 --- Seems like splitting the commit into two dependent commits (and

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/ --- (Updated Oct. 19, 2015, 4:27 a.m.) Review request for mesos and Michael Park.

Review Request 39428: Fixed typo in comment, minor style fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39428/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3326

Re: Review Request 39428: Fixed typo in comment, minor style fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39428/#review103094 --- Ship it! Ship It! - Michael Park On Oct. 19, 2015, 4:20 a.m.,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Oct. 18, 2015, 11:02 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 764-768 > > > > > > As mentioned before, let's remove the `default` case entirely. Refer

Re: Review Request 39265: Windows: Move `os::environment` to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/#review103067 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 39264: Windows:[3/3] Transitioned Mesos tests to use `os::raw` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39264/#review103066 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:36 p.m.,

Re: Review Request 39263: Windows:[2/3] transitioned libprocess to use `os::raw::` family.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39263/#review103065 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:36 p.m.,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review103078 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- (Updated Oct. 18, 2015, 6:40 p.m.) Review request for mesos, Artem

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/ --- (Updated Oct. 18, 2015, 6:40 p.m.) Review request for mesos, Artem

Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39423/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3604

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103052 --- Ship it! Ship It! - Guangya Liu On 十月 17, 2015, 11:05 p.m.,

Review Request 39421: Add agent version to /master/slaves endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39421/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3735

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103056 --- Why not make this as a default option? I think that we need to

Re: Review Request 39421: Add agent version to /master/slaves endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39421/#review103057 --- Patch looks great! Reviews applied: [39421] All tests passed. -

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Oct. 18, 2015, 3:22 p.m.) Review request for mesos, Joris Van

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review103060 --- Patch looks great! Reviews applied: [37336] All tests passed. -

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/#review103058 --- Ship it! We can use snake case in stout.

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/#review103062 --- src/slave/state.hpp (line 131)

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review103063 --- src/common/resources.cpp (lines 482 - 530)

Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review103059 --- Ship it! I think there are places like `os/posix/fork.hpp` that