----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review103060 -----------------------------------------------------------
Patch looks great! Reviews applied: [37336] All tests passed. - Mesos ReviewBot On Oct. 18, 2015, 3:22 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37336/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 3:22 p.m.) > > > Review request for mesos, Joris Van Remoortere and Michael Park. > > > Bugs: MESOS-3035 > https://issues.apache.org/jira/browse/MESOS-3035 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-3035 > > The original API for `process::Subprocess` still left a lot of legwork > to do for the caller; we have now added an `execute()` method > that returns a `Future<CommandResult>` (also introduced with this patch) > which > contains useful information about the command invocation; the exit code; > stdout and, optionally, stderr too. > > Once the Future completes, if successful, the caller will be able to > retrieve > stdout/stderr; whether the command was successful; and whether it > received a signal > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > d2341a53aac7c779668ee80983f73158fd44bff5 > 3rdparty/libprocess/src/subprocess.cpp > a457cbe35ad33531c49f74550cd570cf28758f5d > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > ac600a551fb1a7782ff33cce204b7819497ef54a > > Diff: https://reviews.apache.org/r/37336/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
