Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review103901 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39620/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39623: CMake: Added protobuf compilation to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Oct. 24, 2015, 7 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review103906 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 39297,

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/ --- (Updated Oct. 24, 2015, 6:37 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/ --- (Updated Oct. 24, 2015, 6:43 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review103904 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 24, 2015, 7:42 p.m.) Review request for mesos, Alexander

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review103910 --- include/mesos/master/allocator.hpp (line 358)

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review103911 --- Ship it! Ship It! - Qian Zhang On Oct. 20, 2015, 5:29 a.m.,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Oct. 24, 2015, 6:42 p.m.) Review request for mesos, Artem

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Oct. 6, 2015, 5:12 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > lines 41-43 > > > > > > Is this necessary? (Do the calls to `FindNextFile`,

Re: Review Request 39590: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/#review103903 --- What about `.proto` files? - Alexander Rukletsov On Oct. 24,

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Oct. 24, 2015, 7:40 p.m.) Review request for mesos, Alexander

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review103905 --- include/mesos/master/allocator.hpp (line 360)

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103909 --- Ship it! Ship It! - Klaus Ma On Oct. 21, 2015, 8:52 p.m.,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Oct. 24, 2015, 6:39 p.m.) Review request for mesos, Artem

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review103907 --- Patch looks great! Reviews applied: [39317, 38218, 36913, 38059,

Review Request 39628: Clear the suppressed flag when deactive a framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3802

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Oct. 25, 2015, 3:28 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, line 237 > > > > > > Can you please add a new test case for this? You can refer to > >

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review103933 --- src/tests/master_quota_tests.cpp (line 705)

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103918 --- src/master/master.hpp (line 864)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review103928 --- Where did you set this endpoint of quota?

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review103930 --- Please link this RR to ticket. - Klaus Ma On Oct. 24, 2015,

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review103934 --- src/master/quota_handler.cpp (line 246)

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 21, 2015, 9:02 a.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it