Re: Review Request 42996: [5 of 7] Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42996/#review117102 --- src/tests/resources_tests.cpp (lines 2036 - 2043)

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117118 --- Fix it, then Ship it! Thanks for taking this on Neil! As we

Re: Review Request 42987: Renamed a parameter for the sake of clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42987/#review117122 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 29, 2016,

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review117116 --- Thanks for fixing this! Is there a ticket with the issue? I will

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/#review117120 --- Patch looks great! Reviews applied: [43014] Passed command:

Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/ --- Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone. Bugs:

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/#review117112 --- src/common/command_utils.cpp (line 172)

Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)

Re: Review Request 42794: URL query string order is defined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review117103 --- Ship it! Ship It! - Abhishek Dasgupta On Jan. 30, 2016,

Re: Review Request 42794: URL query string order is defined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/ --- (Updated Jan. 30, 2016, 11:28 a.m.) Review request for mesos, Kapil Arya and

Re: Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42994/#review117101 --- src/examples/persistent_shared_volume_framework.cpp (line 56)

Re: Review Request 42794: URL query string order is defined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review117104 --- Patch looks great! Reviews applied: [42794] Passed command:

Re: Review Request 42986: Updated webui to show count for tasks in `TASK_RUNNING` state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42986/#review117110 --- Fix it, then Ship it! Ship It!

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

> On Jan. 30, 2016, 2:19 a.m., Mesos ReviewBot wrote: > > Bad review! > > > > Reviews applied: [] > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or the > > mailing list. I have a patch a bit related to this.

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review117125 --- src/slave/containerizer/docker.cpp (line 992)

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42910/#review117129 --- Ship it! docs/quota.md (line 281)

Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43023/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Bugs:

Review Request 43024: Avoid unnecessary string copies in `json` for protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43024/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-4566

Re: Review Request 42986: Updated webui to show count for tasks in `TASK_RUNNING` state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42986/ --- (Updated Jan. 30, 2016, 7:28 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 30, 2016, 10:20 p.m.) Review request for mesos and Joris Van

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43023/#review117131 --- 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

> On Jan. 30, 2016, 7:31 p.m., Joerg Schad wrote: > > src/docker/executor.cpp, line 135 > > > > > > I am not sure why we are printing this, but shouldn't we at least check > > for errors on os::shell? Thought I

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/ --- (Updated Jan. 30, 2016, 10:43 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

> On Jan. 30, 2016, 9:53 p.m., Joris Van Remoortere wrote: > > src/tests/group_tests.cpp, lines 451-452 > > > > > > Maybe a comment explaining that we're triggering the timeout? Or is > > this too self-explanatory?

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117130 --- Patch looks great! Reviews applied: [42987, 42988] Passed

Re: Review Request 43024: Avoid unnecessary string copies in `json` for protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43024/#review117135 --- Patch looks great! Reviews applied: [43023, 43024] Passed

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

> On Jan. 31, 2016, 1:43 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 162 > > > > > > I assume we have some evidence that this optimization is warranted? With this

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

> On Jan. 31, 2016, 1:43 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 173 > > > > > > This seems a little more subtle than is warranted. The `i` part perhaps? Is

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- (Updated Jan. 31, 2016, 6:23 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

> On Jan. 31, 2016, 1:43 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 162 > > > > > > I assume we have some evidence that this optimization is warranted? > >

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43023/ --- (Updated Jan. 31, 2016, 4:51 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

> On Jan. 31, 2016, 1:43 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 173 > > > > > > This seems a little more subtle than is warranted. > > Michael Park wrote: >