Re: Review Request 42186: Added tests for recovery for HTTP based executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117580 --- Patch looks great! Reviews applied: [42181, 43131, 42844, 42185,

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 3, 2016, 7:11 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 3, 2016, 7:17 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

> On Feb. 3, 2016, 1:32 a.m., Jie Yu wrote: > > src/linux/cgroups.cpp, line 2489 > > > > > > Where is the stringify function? > > > > Have you verified that if we can just write a decimal number to > >

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 1, 2016, 6:45 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 1, 2016, 6:45 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/#review117583 --- Primarily trivial comments around style/error messages.

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/#review117524 --- Patch looks great! Reviews applied: [43118] Passed command:

Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43124/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4377

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/ --- (Updated Feb. 3, 2016, 12:54 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43122: Updated Rakefile to automatically generate doxygen pages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/#review117559 --- Patch looks great! Reviews applied: [43120, 43121, 43122]

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

> On Feb. 2, 2016, 11:02 p.m., Vinod Kone wrote: > > src/tests/slave_recovery_tests.cpp, line 1046 > > > > > > I think you should start the slave with fixed id like in the above > > test, to ensure the executor

Re: Review Request 42181: Added a process ID argument to Slave constructor.

> On Feb. 2, 2016, 10:05 p.m., Vinod Kone wrote: > > src/tests/cluster.cpp, lines 409-430 > > > > > > instead of doing if else blocks can you use a ternary operator for the > > 1st argument in the constructor? > >

Re: Review Request 43131: Modified existing usage of Slave constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 2:34 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Feb. 3, 2016, 2:34 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117401 --- Patch looks great! Reviews applied: [43032] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 2, 2016, 1:53 p.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 2, 2016, 1:57 p.m.) Review request for mesos and TimothyIL

<    1   2