Re: Review Request 43798: Added overview section to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review120029 --- Patch looks great! Reviews applied: [43792, 43798] Passed

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120027 --- docs/authorization.md (lines 37 - 48)

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review120025 --- docs/mesos-containerizer.md (lines 63 - 64)

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- (Updated Feb. 20, 2016, 6:09 a.m.) Review request for mesos, Gilbert Song and

Review Request 43801: Refactored and simplified the docker puller interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- Review request for mesos, Gilbert Song and Timothy Chen. Bugs: MESOS-4499

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 811-815 > > > > > > This is done after the container has been launched. We should > > definitely call out the fact that

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120023 --- Patch looks great! Reviews applied: [43799] Passed command:

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120021 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/ --- (Updated Feb. 20, 2016, 3:31 a.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 19, 2016, 12:23 p.m., Shuai Lin wrote: > > src/launcher/http_executor.cpp, line 776 > > > > > > Unlike unacked status updates, there could be at most one unacked task > > info, so here we don't need a map

Re: Review Request 43793: Increased the timeout in disk-heavy FilesystemIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43793/#review120018 --- Patch looks great! Reviews applied: [43793] Passed command:

Re: Review Request 43639: Allowed dynamic reservation without a principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- (Updated Feb. 20, 2016, 1:53 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/#review120015 --- Patch looks great! Reviews applied: [43260, 43261, 43271, 43272]

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

> On Feb. 18, 2016, 12:56 p.m., Joseph Wu wrote: > > Can you split up this patch into the following groups? (Its ok to run the > > tests at the end of a review chain, just add a note in the "Testing Done" > > section.) > > > > * Interfaces for the new module. > > * Modularization boilerplate

Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/ --- Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. Bugs:

Re: Review Request 43798: Added overview section to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated Feb. 20, 2016, 1:17 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43798: Added overview section to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated Feb. 20, 2016, 1:13 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/ --- (Updated Feb. 20, 2016, 1:11 a.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 43779: Added '/reserve' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. Bugs:

Review Request 43778: Added '/create-volumes' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/ --- Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. Bugs:

Review Request 43799: Removed race condition from libevent based poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Bugs:

Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/ --- Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. Bugs:

Review Request 43776: Changed object of `ReserveResource` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/ --- Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. Bugs:

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 19, 2016, 4:50 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 19, 2016, 4:50 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 43798: Added overview section to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-4381

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/#review120004 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 12:59

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review120003 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 2:24

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 19, 2016, 3:46 p.m., Alexander Rojas wrote: > > src/tests/cluster.hpp, line 163 > > > > > > Not yours (is the only unchanged line here) but if all other pointer > > objects are of type `process::Owned`

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review11 --- docs/mesos-containerizer.md (line 91)

Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/ --- Review request for mesos, Jie Yu and Neil Conway. Bugs: MESOS-4660

Re: Review Request 43792: Made bullet point structure consistent in ugrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/ --- (Updated Feb. 20, 2016, 12:21 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/ --- (Updated Feb. 20, 2016, 12:22 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43793: Increased the timeout in disk-heavy FilesystemIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43793/#review119996 --- Ship it! Ship It! - Jie Yu On Feb. 20, 2016, 12:10 a.m.,

Review Request 43793: Increased the timeout in disk-heavy FilesystemIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43793/ --- Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Bugs:

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/#review119995 --- Ship it! Ship It! - Neil Conway On Feb. 20, 2016, 12:03

Review Request 43792: Made bullet point structure consistent in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/ --- Review request for mesos, Michael Park and Neil Conway. Repository: mesos

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review119994 --- Patch looks great! Reviews applied: [42877] Passed command:

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119989 --- src/tests/cluster.hpp (line 82)

Re: Review Request 43790: Fixed container ids used in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43790/ --- (Updated Feb. 19, 2016, 11:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43790: Fixed container ids used in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43790/#review119992 --- Ship it! Ship It! - Jie Yu On Feb. 19, 2016, 11:34 p.m.,

Review Request 43790: Fixed container ids used in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43790/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 19, 2016, 3:15 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 59 > > > > > > Replace 1000 with const integer I refactored the code to use functions rather than repeating `1000` in a bunch of

Re: Review Request 43775: Fixed bug in appc cache's find logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/#review119988 --- Patch looks great! Reviews applied: [41958, 41959, 43775]

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/ --- (Updated Feb. 19, 2016, 10:27 p.m.) Review request for mesos, Joris Van

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

> On Feb. 18, 2016, 10:32 p.m., Adam B wrote: > > include/mesos/mesos.proto, line 1600 > > > > > > Is it ok for labels to contain duplicate keys even if the values are > > different? > > That sounds like

Re: Review Request 43715: To include title generation in endpoint generator file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 19, 2016, 8:06 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43715: Title for endpoint documentation.

> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, line 147 > > > > > > Actually, I was wrong, when I pull down locally, all of these newlines > > are removed (and they

Re: Review Request 43715: Title for endpoint documentation.

> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, line 147 > > > > > > Actually, I was wrong, when I pull down locally, all of these newlines > > are removed (and they

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 785 > > > > > > Do you need to call update for this case (command task but agent is not > > running in a docker container)?

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119963 --- Ship it! Ship It! - Kevin Klues On Feb. 19, 2016, 7:55

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 19, 2016, 7:55 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119960 --- Ship it! Ship It! - Kevin Klues On Feb. 19, 2016, 7:46

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/ --- (Updated Feb. 19, 2016, 11:48 a.m.) Review request for mesos, Benjamin

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 19, 2016, 7:46 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

> On Feb. 19, 2016, 6:32 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 1600 > > > > > > Is it ok for labels to contain duplicate keys even if the values are > > different? > > That sounds like

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119953 --- Ship it! Ship It! - Vinod Kone On Feb. 19, 2016, 6:54 p.m.,

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 19, 2016, 11:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 19, 2016, 3:16 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 205 > > > > > > Slightly unclear which is which. Attempt to clarify: > > > > ... Once this method has been called, its

Re: Review Request 43775: Fixed bug in appc cache's find logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/#review119951 --- Ship it! Ship It! - Kevin Klues On Feb. 19, 2016, 7:12

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review119950 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 4:35

Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/ --- (Updated Feb. 19, 2016, 7:21 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review119949 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 4:34

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119948 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 5:49

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review119946 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:29

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review119947 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:31

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review119945 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:28

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119944 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:28

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119943 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 206)

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review119942 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:27

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review119941 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:26

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review119940 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:24

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/#review119938 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 1:01

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/#review119936 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119935 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119933 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:08

Re: Review Request 43775: Fixed bug in appc cache's find logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/#review119934 --- Ship it! Ship It! - Jie Yu On Feb. 19, 2016, 7:12 p.m.,

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review119931 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/#review119932 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Review Request 43775: Fixed bug in appc cache's find logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119930 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:08

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

> On Feb. 19, 2016, 2:32 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 329 > > > > > > There are so many things I'd like to comment on here, please allow me > > to just go for it and

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review119929 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/#review119926 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/#review119925 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119924 --- Ship it! Ship It! - Alexander Rojas On Feb. 19, 2016, 7:54

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/ --- (Updated Feb. 19, 2016, 6:54 p.m.) Review request for mesos, Joris Van

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/ --- (Updated Feb. 19, 2016, 10:54 a.m.) Review request for mesos, Benjamin

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/ --- (Updated Feb. 19, 2016, 10:54 a.m.) Review request for mesos, Benjamin

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 19, 2016, 6:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

> On Feb. 18, 2016, 8:56 p.m., Joseph Wu wrote: > > Can you split up this patch into the following groups? (Its ok to run the > > tests at the end of a review chain, just add a note in the "Testing Done" > > section.) > > > > * Interfaces for the new module. > > * Modularization boilerplate

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119920 --- src/master/master.cpp (lines 3856 - 3858)

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119915 --- Patch looks great! Reviews applied: [43769] Passed command:

Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository:

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119896 --- The white space in these generated files (especially index.md) is

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119893 --- Fix it, then Ship it! The summary and description will need to

Re: Review Request 42370: Accept the 3-field version of HDFS du output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42370/ --- (Updated Feb. 19, 2016, 3:29 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43764: Extended the actual shutdown timeout for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43764/#review119887 --- Patch looks great! Reviews applied: [43757, 43758, 43759, 43760,

Re: Review Request 43764: Extended the actual shutdown timeout for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43764/#review119886 --- src/slave/slave.cpp (line 3682)

  1   2   >