Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/#review137151 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 12, 2016, 5:55 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137149 --- Fix it, then Ship it! LGTM.. Just a few more nits to clean

Review Request 48594: Added bundled zookeeper to the module-dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48594/ --- Review request for mesos, Jie Yu and Kapil Arya. Bugs: MESOS-5577

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 11, 2016, 8:33 p.m., Anand Mazumdar wrote: > > src/internal/evolve.hpp, lines 120-121 > > > > > > It's fine to evolve `JSON::Object` directly into `v1` to avoid making > > an extra copy. We adopted a

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/ --- (Updated June 12, 2016, 4:31 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 12, 2016, 4:15 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137148 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137147 --- src/common/values.cpp (line 282)

Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/ --- Review request for mesos. Bugs: MESOS-5425

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/#review137146 --- I think in `NetClsSubsystem`, you still need a stub for the

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/#review137139 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Re: Review Request 48584: Added unversioned protos for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/#review137138 --- Ship it! Ship It! - Anand Mazumdar On June 11, 2016, 5:19

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137137 --- LGTM overall. Minor comments around evolving `Response` to

Re: Review Request 46594: Added test for isolator cleanup before prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/#review137136 --- Patch looks great! Reviews applied: [46576, 46577, 46593, 46594]

Re: Review Request 48583: Added `VersionInfo`, `Flag`, `Metrics` to unversioned mesos protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48583/#review137135 --- Ship it! Ship It! - Anand Mazumdar On June 11, 2016, 5:19

Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Review Request 48587: Added unversioned protos for agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48587/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 11, 2016, 6:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 46594: Added test for isolator cleanup before prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/ --- (Updated June 11, 2016, 11:06 a.m.) Review request for mesos, Artem

Re: Review Request 48373: Integrated the `NvidiaGpuAllocator` into the `NvidiaGpuIsolator`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48373/ --- (Updated June 11, 2016, 5:37 p.m.) Review request for mesos and Benjamin

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137128 --- src/internal/evolve.cpp (line 445)

Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Review Request 48583: Added `VersionInfo`, `Flag`, `Metrics` to unversioned mesos protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48583/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Review Request 48584: Added unversioned protos for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/#review137126 --- Patch looks great! Reviews applied: [48563, 48566] Passed

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/tests/values_tests.cpp, lines 39-72 > > > > > > It would be great to split apart this test into the respective value > > types, e.g. > > > > ```

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review137121 --- Patch looks great! Reviews applied: [43561] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/tests/values_tests.cpp, line 210 > > > > > > If I understand correctly, the following are currently accepted way to > > specify 1-4: > > > >

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/ --- (Updated June 11, 2016, 3:01 p.m.) Review request for mesos, Adam B and

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/ --- (Updated June 11, 2016, 3:01 p.m.) Review request for mesos, Adam B and

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/ --- (Updated June 11, 2016, 3 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136998 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated June 11, 2016, 10:29 p.m.) Review request for mesos, Alexander

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review137118 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/#review137119 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review137117 --- Ping. I don't think it is necessary to devolve protobuf in this

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/#review137115 --- Patch looks great! Reviews applied: [46425, 48581] Passed

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/ --- (Updated June 11, 2016, 7 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- (Updated June 11, 2016, 9:25 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/ --- (Updated June 11, 2016, 9:25 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/ --- (Updated June 11, 2016, 9:25 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- (Updated June 11, 2016, 9:25 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48115: Added maintenance V1 header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/ --- (Updated June 11, 2016, 9:24 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 11, 2016, 9:24 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 11, 2016, 9:24 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 11, 2016, 9:24 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 46425: Add helper function to simplify tokenize handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/ --- (Updated June 11, 2016, 5:21 p.m.) Review request for mesos and Benjamin

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/#review137112 --- Fix it, then Ship it! LGTM, barring my nits about lambda

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/#review137111 --- Fix it, then Ship it! Logically looks fine to me, although now

Re: Review Request 48579: Reset "dirty" to false in sort().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/ --- (Updated 六月 11, 2016, 8:30 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 48455: Some cleanup for sorter.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48455/ --- (Updated 六月 11, 2016, 8:27 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- (Updated June 11, 2016, 8:12 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- (Updated June 11, 2016, 8:12 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 47374: Separated mesos test helpers into a separate library.

> On May 23, 2016, 5:09 p.m., Adam B wrote: > > src/Makefile.am, lines 1937-1938 > > > > > > Why does libmesos_tests_la_SOURCES need to include qos_controllers code? > > Joseph Wu wrote: > I don't remember the