Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-12 Thread Joerg Schad
> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? > > Greg Mann wrote: > Yes! Thanks for thinking of this, Joerg! > > Joerg Schad wrote: > I will take care of that in another patch. https://reviews.apache.org/r/48598/ - Joerg --

Review Request 48598: Added changes to upgrades.md.

2016-06-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48598/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos Descrip

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/#review137168 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (li

Re: Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

2016-06-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48597/#review137166 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

2016-06-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/#review137163 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

2016-06-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48597/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. B

Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

2016-06-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. B

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review137162 --- src/Makefile.am (lines 1950 - 1951)

Review Request 48595: Exposed the logging process `PID` in libprocess.

2016-06-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. B

Re: Review Request 48594: Added bundled zookeeper to the module-dependencies.

2016-06-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48594/#review137161 --- Ship it! Please update the testing description with the updated

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137160 --- Hi Yanyan, can you please add some test cases for your code chage?

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137159 --- Patch looks great! Reviews applied: [48593] Passed command: expo

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

2016-06-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/#review137157 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-12 Thread Yanyan Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/ --- (Updated June 12, 2016, 8:03 a.m.) Review request for mesos and Guangya Liu.

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-12 Thread Yanyan Hu
> On June 12, 2016, 3:35 a.m., haosdent huang wrote: > > src/common/values.cpp, line 310 > > > > > > Usually we perfer to return `Value::Ranges` directly. > > ``` > > Value::Ranges IntervalSet2Ranges(const In

Re: Review Request 48594: Added bundled zookeeper to the module-dependencies.

2016-06-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48594/#review137154 --- Patch looks great! Reviews applied: [48594] Passed command: expo

<    1   2